From: Dmitry Torokhov <dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: Re: [PATCH v3] input: Add support for ChipOne icn8318 based touchscreens
Date: Sat, 21 Mar 2015 21:03:05 -0700 [thread overview]
Message-ID: <20150322040305.GA40622@dtor-ws> (raw)
In-Reply-To: <1426007133-9606-1-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Hi Hans,
On Tue, Mar 10, 2015 at 06:05:33PM +0100, Hans de Goede wrote:
> + error = devm_request_threaded_irq(dev, client->irq, NULL, icn8318_irq,
> + IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
Shouldn't we let DT data tell us what trigger to use? I.e. just leave
IRQF_ONESHOT here?
No need to resubmit, just let me know if you agree/disagree...
Thanks.
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: dmitry.torokhov@gmail.com (Dmitry Torokhov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] input: Add support for ChipOne icn8318 based touchscreens
Date: Sat, 21 Mar 2015 21:03:05 -0700 [thread overview]
Message-ID: <20150322040305.GA40622@dtor-ws> (raw)
In-Reply-To: <1426007133-9606-1-git-send-email-hdegoede@redhat.com>
Hi Hans,
On Tue, Mar 10, 2015 at 06:05:33PM +0100, Hans de Goede wrote:
> + error = devm_request_threaded_irq(dev, client->irq, NULL, icn8318_irq,
> + IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
Shouldn't we let DT data tell us what trigger to use? I.e. just leave
IRQF_ONESHOT here?
No need to resubmit, just let me know if you agree/disagree...
Thanks.
--
Dmitry
next prev parent reply other threads:[~2015-03-22 4:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-10 17:05 [PATCH v3] input: Add support for ChipOne icn8318 based touchscreens Hans de Goede
2015-03-10 17:05 ` Hans de Goede
[not found] ` <1426007133-9606-1-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-03-22 4:03 ` Dmitry Torokhov [this message]
2015-03-22 4:03 ` Dmitry Torokhov
2015-03-22 11:00 ` Hans de Goede
2015-03-22 11:00 ` Hans de Goede
2015-03-22 22:42 ` Dmitry Torokhov
2015-03-22 22:42 ` Dmitry Torokhov
2015-03-24 17:45 ` Hans de Goede
2015-03-24 17:45 ` Hans de Goede
[not found] ` <5511A29F.1010404-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-03-24 18:33 ` Dmitry Torokhov
2015-03-24 18:33 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150322040305.GA40622@dtor-ws \
--to=dmitry.torokhov-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.