From: "L. Alberto Giménez" <agimenez@sysvalve.es>
To: Joe Perches <joe@perches.com>
Cc: Richard Weinberger <richard@nod.at>,
LKML <linux-kernel@vger.kernel.org>,
Andy Whitcroft <apw@canonical.com>
Subject: Re: [PATCH] checkpatch.pl: Add warning for harmful goto labels
Date: Sun, 22 Mar 2015 13:16:51 +0100 [thread overview]
Message-ID: <20150322121651.GA15680@bart.evergreen.loc> (raw)
In-Reply-To: <1426992999.20324.9.camel@perches.com>
On Sat, Mar 21, 2015 at 07:56:39PM -0700, Joe Perches wrote:
> []
> > > If something is already in the kernel code, does that mean that it's OK?
> > > I honestly don't think so, and I think that goto labels for cleanup exit
> > > paths should be a little more descriptive.
> >
> > I disagree. out and exit are perfectly fine labels.
>
> I agree with you Richard.
>
[...]
> > > It's just a proposal for a warning. If it is really not needed, it won't
> > > be applied and life will go on :)
>
> In that case, it'd be nicer to preface the patch subject with RFC
Yes, you are right, sorry about that.
Thank you for the feedback guys!
And Richard, of course I was kidding about the 'i' variable. I enjoy
sarcasm myself too :)
Best regards,
--
L. Alberto Giménez
GnuPG key ID 0xDD4E27AB
next prev parent reply other threads:[~2015-03-22 12:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-21 21:16 [PATCH] checkpatch.pl: Add warning for harmful goto labels L. Alberto Giménez
2015-03-21 21:40 ` Richard Weinberger
2015-03-21 22:06 ` L. Alberto Giménez
2015-03-21 22:12 ` Richard Weinberger
2015-03-22 2:56 ` Joe Perches
2015-03-22 12:16 ` L. Alberto Giménez [this message]
2015-03-21 21:41 ` Peter Hurley
2015-03-21 22:09 ` L. Alberto Giménez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150322121651.GA15680@bart.evergreen.loc \
--to=agimenez@sysvalve.es \
--cc=apw@canonical.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.