From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: "Uwe Kleine-König"
<u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Magnus Damm <magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Simon Horman <horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>,
Laurent Pinchart
<laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>,
Geert Uytterhoeven
<geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
Subject: Re: [PATCH v2 2/4] Documentation: i2c: describe the new slave mode
Date: Mon, 23 Mar 2015 10:04:46 +0100 [thread overview]
Message-ID: <20150323090446.GA3743@katana> (raw)
In-Reply-To: <20150323084510.GL5664-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 557 bytes --]
> I don't understand why you want to force a valid pointer here. According
> to my sense of defensive programming I'd say: If the bus driver doesn't
> expect the slave to consume/provide a value, let's pass NULL to notice
> the assumption being wrong. The wording is fine, now.
For me, an OOPS is quite much of a "notice". I assume there will be
non-upstream backends. I am not keen to see devices in the field to OOPS
because the implementation missed a case how to handle the pointer
correctly. Now, the rule of thumb is easy: Always pass the pointer.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: "Uwe Kleine-König"
<u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Magnus Damm <magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Simon Horman <horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>,
Laurent Pinchart
<laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>,
Geert Uytterhoeven
<geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
Subject: Re: [PATCH v2 2/4] Documentation: i2c: describe the new slave mode
Date: Mon, 23 Mar 2015 09:04:46 +0000 [thread overview]
Message-ID: <20150323090446.GA3743@katana> (raw)
In-Reply-To: <20150323084510.GL5664-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 557 bytes --]
> I don't understand why you want to force a valid pointer here. According
> to my sense of defensive programming I'd say: If the bus driver doesn't
> expect the slave to consume/provide a value, let's pass NULL to notice
> the assumption being wrong. The wording is fine, now.
For me, an OOPS is quite much of a "notice". I assume there will be
non-upstream backends. I am not keen to see devices in the field to OOPS
because the implementation missed a case how to handle the pointer
correctly. Now, the rule of thumb is easy: Always pass the pointer.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-03-23 9:04 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-23 8:26 [PATCH v2 0/4] i2c: slave: API updates Wolfram Sang
2015-03-23 8:26 ` Wolfram Sang
2015-03-23 8:26 ` [PATCH v2 1/4] i2c: slave: rework the slave API Wolfram Sang
2015-03-23 8:26 ` Wolfram Sang
[not found] ` <1427099199-3628-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2015-03-23 8:26 ` [PATCH v2 2/4] Documentation: i2c: describe the new slave mode Wolfram Sang
2015-03-23 8:26 ` Wolfram Sang
[not found] ` <1427099199-3628-3-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2015-03-23 8:45 ` Uwe Kleine-König
2015-03-23 8:45 ` Uwe Kleine-König
[not found] ` <20150323084510.GL5664-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2015-03-23 9:04 ` Wolfram Sang [this message]
2015-03-23 9:04 ` Wolfram Sang
2015-04-01 12:17 ` Geert Uytterhoeven
2015-04-01 12:17 ` Geert Uytterhoeven
2015-04-02 3:38 ` Wolfram Sang
2015-04-02 3:38 ` Wolfram Sang
2015-03-23 8:26 ` [PATCH v2 3/4] i2c: slave: add documentation for i2c-slave-eeprom Wolfram Sang
2015-03-23 8:26 ` Wolfram Sang
2015-03-23 8:26 ` [PATCH v2 4/4] i2c: slave-eeprom: add more info when to increase the pointer Wolfram Sang
2015-03-23 8:26 ` Wolfram Sang
[not found] ` <1427099199-3628-5-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2015-03-23 8:32 ` Uwe Kleine-König
2015-03-23 8:32 ` Uwe Kleine-König
2015-03-27 8:55 ` [PATCH v2 0/4] i2c: slave: API updates Wolfram Sang
2015-03-27 8:55 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150323090446.GA3743@katana \
--to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
--cc=geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org \
--cc=horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org \
--cc=laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.