All of lore.kernel.org
 help / color / mirror / Atom feed
From: shawn.guo@linaro.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] dts: cubox: Map gpio-keys to gpio3 8
Date: Mon, 23 Mar 2015 21:32:54 +0800	[thread overview]
Message-ID: <20150323133252.GE28410@dragon> (raw)
In-Reply-To: <1426542829-16786-1-git-send-email-george.joseph@fairview5.com>

On Mon, Mar 16, 2015 at 03:53:49PM -0600, George Joseph wrote:
> The Cubox has a recessed button between the HDMI and RJ-45 connectors
> that wasn't mapped in the device tree, so I've mapped it to gpio-keys
> BTN_0.
> 
> Signed-off-by: George Joseph <george.joseph@fairview5.com>
> Tested-by: George Joseph <george.joseph@fairview5.com>

Russell,

Are you fine with this patch?

Shawn

> ---
>  arch/arm/boot/dts/imx6qdl-cubox-i.dtsi | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl-cubox-i.dtsi b/arch/arm/boot/dts/imx6qdl-cubox-i.dtsi
> index 6a524ca..de6e3a8 100644
> --- a/arch/arm/boot/dts/imx6qdl-cubox-i.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-cubox-i.dtsi
> @@ -3,6 +3,8 @@
>   */
>  #include "imx6qdl-microsom.dtsi"
>  #include "imx6qdl-microsom-ar8035.dtsi"
> +#include <dt-bindings/input/input.h>
> +#include <dt-bindings/gpio/gpio.h>
>  
>  / {
>  	ir_recv: ir-receiver {
> @@ -66,6 +68,18 @@
>  		spdif-controller = <&spdif>;
>  		spdif-out;
>  	};
> +
> +	gpio-keys {
> +		compatible = "gpio-keys";
> +		pinctrl-0 = <&pinctrl_gpio_key>;
> +		pinctrl-names = "default";
> +
> +		button_0 {
> +			label = "Button 0";
> +			gpios = <&gpio3 8 GPIO_ACTIVE_LOW>;
> +			linux,code = <BTN_0>;
> +		};
> +	};
>  };
>  
>  &hdmi {
> @@ -170,6 +184,12 @@
>  				MX6QDL_PAD_SD2_DAT3__SD2_DATA3 0x13059
>  			>;
>  		};
> +
> +		pinctrl_gpio_key: gpio-key {
> +			fsl,pins = <
> +				MX6QDL_PAD_EIM_DA8__GPIO3_IO08	0x17059
> +			>;
> +		};
>  	};
>  };
>  
> -- 
> 2.1.0
> 

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: George Joseph
	<george.joseph-H+B1fhQ+CpcEVd8bySq3Wg@public.gmane.org>,
	Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>
Cc: Sascha Hauer <kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	Ian Campbell
	<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
	Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2] dts: cubox: Map gpio-keys to gpio3 8
Date: Mon, 23 Mar 2015 21:32:54 +0800	[thread overview]
Message-ID: <20150323133252.GE28410@dragon> (raw)
In-Reply-To: <1426542829-16786-1-git-send-email-george.joseph-H+B1fhQ+CpcEVd8bySq3Wg@public.gmane.org>

On Mon, Mar 16, 2015 at 03:53:49PM -0600, George Joseph wrote:
> The Cubox has a recessed button between the HDMI and RJ-45 connectors
> that wasn't mapped in the device tree, so I've mapped it to gpio-keys
> BTN_0.
> 
> Signed-off-by: George Joseph <george.joseph-H+B1fhQ+CpcEVd8bySq3Wg@public.gmane.org>
> Tested-by: George Joseph <george.joseph-H+B1fhQ+CpcEVd8bySq3Wg@public.gmane.org>

Russell,

Are you fine with this patch?

Shawn

> ---
>  arch/arm/boot/dts/imx6qdl-cubox-i.dtsi | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl-cubox-i.dtsi b/arch/arm/boot/dts/imx6qdl-cubox-i.dtsi
> index 6a524ca..de6e3a8 100644
> --- a/arch/arm/boot/dts/imx6qdl-cubox-i.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-cubox-i.dtsi
> @@ -3,6 +3,8 @@
>   */
>  #include "imx6qdl-microsom.dtsi"
>  #include "imx6qdl-microsom-ar8035.dtsi"
> +#include <dt-bindings/input/input.h>
> +#include <dt-bindings/gpio/gpio.h>
>  
>  / {
>  	ir_recv: ir-receiver {
> @@ -66,6 +68,18 @@
>  		spdif-controller = <&spdif>;
>  		spdif-out;
>  	};
> +
> +	gpio-keys {
> +		compatible = "gpio-keys";
> +		pinctrl-0 = <&pinctrl_gpio_key>;
> +		pinctrl-names = "default";
> +
> +		button_0 {
> +			label = "Button 0";
> +			gpios = <&gpio3 8 GPIO_ACTIVE_LOW>;
> +			linux,code = <BTN_0>;
> +		};
> +	};
>  };
>  
>  &hdmi {
> @@ -170,6 +184,12 @@
>  				MX6QDL_PAD_SD2_DAT3__SD2_DATA3 0x13059
>  			>;
>  		};
> +
> +		pinctrl_gpio_key: gpio-key {
> +			fsl,pins = <
> +				MX6QDL_PAD_EIM_DA8__GPIO3_IO08	0x17059
> +			>;
> +		};
>  	};
>  };
>  
> -- 
> 2.1.0
> 
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawn.guo@linaro.org>
To: George Joseph <george.joseph@fairview5.com>,
	Russell King <linux@arm.linux.org.uk>
Cc: Sascha Hauer <kernel@pengutronix.de>,
	Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] dts: cubox: Map gpio-keys to gpio3 8
Date: Mon, 23 Mar 2015 21:32:54 +0800	[thread overview]
Message-ID: <20150323133252.GE28410@dragon> (raw)
In-Reply-To: <1426542829-16786-1-git-send-email-george.joseph@fairview5.com>

On Mon, Mar 16, 2015 at 03:53:49PM -0600, George Joseph wrote:
> The Cubox has a recessed button between the HDMI and RJ-45 connectors
> that wasn't mapped in the device tree, so I've mapped it to gpio-keys
> BTN_0.
> 
> Signed-off-by: George Joseph <george.joseph@fairview5.com>
> Tested-by: George Joseph <george.joseph@fairview5.com>

Russell,

Are you fine with this patch?

Shawn

> ---
>  arch/arm/boot/dts/imx6qdl-cubox-i.dtsi | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl-cubox-i.dtsi b/arch/arm/boot/dts/imx6qdl-cubox-i.dtsi
> index 6a524ca..de6e3a8 100644
> --- a/arch/arm/boot/dts/imx6qdl-cubox-i.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-cubox-i.dtsi
> @@ -3,6 +3,8 @@
>   */
>  #include "imx6qdl-microsom.dtsi"
>  #include "imx6qdl-microsom-ar8035.dtsi"
> +#include <dt-bindings/input/input.h>
> +#include <dt-bindings/gpio/gpio.h>
>  
>  / {
>  	ir_recv: ir-receiver {
> @@ -66,6 +68,18 @@
>  		spdif-controller = <&spdif>;
>  		spdif-out;
>  	};
> +
> +	gpio-keys {
> +		compatible = "gpio-keys";
> +		pinctrl-0 = <&pinctrl_gpio_key>;
> +		pinctrl-names = "default";
> +
> +		button_0 {
> +			label = "Button 0";
> +			gpios = <&gpio3 8 GPIO_ACTIVE_LOW>;
> +			linux,code = <BTN_0>;
> +		};
> +	};
>  };
>  
>  &hdmi {
> @@ -170,6 +184,12 @@
>  				MX6QDL_PAD_SD2_DAT3__SD2_DATA3 0x13059
>  			>;
>  		};
> +
> +		pinctrl_gpio_key: gpio-key {
> +			fsl,pins = <
> +				MX6QDL_PAD_EIM_DA8__GPIO3_IO08	0x17059
> +			>;
> +		};
>  	};
>  };
>  
> -- 
> 2.1.0
> 

  reply	other threads:[~2015-03-23 13:32 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-16 21:53 [PATCH v2] dts: cubox: Map gpio-keys to gpio3 8 George Joseph
2015-03-16 21:53 ` George Joseph
2015-03-16 21:53 ` George Joseph
2015-03-23 13:32 ` Shawn Guo [this message]
2015-03-23 13:32   ` Shawn Guo
2015-03-23 13:32   ` Shawn Guo
2015-03-23 15:19   ` Russell King - ARM Linux
2015-03-23 15:19     ` Russell King - ARM Linux
2015-03-23 16:15     ` George Joseph
2015-03-23 16:15       ` George Joseph
2015-03-23 16:15       ` George Joseph
2015-03-24 16:31 ` [PATCH v3 0/1] " George Joseph
2015-03-24 16:31   ` George Joseph
2015-03-24 16:31   ` [PATCH v3 1/1] " George Joseph
2015-03-24 16:31     ` George Joseph
2015-03-30  3:55     ` Shawn Guo
2015-03-30  3:55       ` Shawn Guo
2015-03-30  3:55       ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150323133252.GE28410@dragon \
    --to=shawn.guo@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.