From: Dan Carpenter <dan.carpenter@oracle.com>
To: Silvan Jegen <s.jegen@gmail.com>
Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH V3] [media] mantis: fix error handling
Date: Mon, 23 Mar 2015 16:32:39 +0000 [thread overview]
Message-ID: <20150323163239.GT16501@mwanda> (raw)
In-Reply-To: <1427127953-24716-1-git-send-email-s.jegen@gmail.com>
On Mon, Mar 23, 2015 at 05:25:53PM +0100, Silvan Jegen wrote:
> Remove dead code, make goto label names more expressive and add a label
> in order to call mantis_dvb_exit if mantis_uart_init fails.
>
> Also make sure that mantis_pci_exit is called if we fail the
> mantis_stream_control call and that we call mantis_i2c_exit if
> mantis_get_mac fails.
>
> Signed-off-by: Silvan Jegen <s.jegen@gmail.com>
Looks great. Thanks!
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Silvan Jegen <s.jegen@gmail.com>
Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH V3] [media] mantis: fix error handling
Date: Mon, 23 Mar 2015 19:32:39 +0300 [thread overview]
Message-ID: <20150323163239.GT16501@mwanda> (raw)
In-Reply-To: <1427127953-24716-1-git-send-email-s.jegen@gmail.com>
On Mon, Mar 23, 2015 at 05:25:53PM +0100, Silvan Jegen wrote:
> Remove dead code, make goto label names more expressive and add a label
> in order to call mantis_dvb_exit if mantis_uart_init fails.
>
> Also make sure that mantis_pci_exit is called if we fail the
> mantis_stream_control call and that we call mantis_i2c_exit if
> mantis_get_mac fails.
>
> Signed-off-by: Silvan Jegen <s.jegen@gmail.com>
Looks great. Thanks!
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards,
dan carpenter
next prev parent reply other threads:[~2015-03-23 16:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-15 12:11 [PATCH 0/2] [media] mantis: Fix goto labels Silvan Jegen
2015-02-15 12:11 ` Silvan Jegen
2015-02-15 12:11 ` [PATCH 1/2] [media] mantis: Move jump label to activate dead code Silvan Jegen
2015-02-15 12:11 ` Silvan Jegen
2015-02-16 9:04 ` Dan Carpenter
2015-02-16 9:04 ` Dan Carpenter
2015-02-17 9:48 ` Silvan Jegen
2015-02-17 9:48 ` Silvan Jegen
2015-03-22 17:16 ` [PATCH v2] [media] mantis: fix error handling Silvan Jegen
2015-03-22 17:16 ` Silvan Jegen
2015-03-22 19:33 ` walter harms
2015-03-22 19:33 ` walter harms
2015-03-22 22:48 ` Dan Carpenter
2015-03-22 22:48 ` Dan Carpenter
2015-03-23 16:25 ` [PATCH V3] " Silvan Jegen
2015-03-23 16:25 ` Silvan Jegen
2015-03-23 16:32 ` Dan Carpenter [this message]
2015-03-23 16:32 ` Dan Carpenter
2015-02-15 12:11 ` [PATCH 2/2] [media] mantis: Use correct goto labels for cleanup on error Silvan Jegen
2015-02-15 12:11 ` Silvan Jegen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150323163239.GT16501@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=s.jegen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.