Re: [Outreachy kernel] [PATCH 2/2] Staging: iio: use the BIT macro in adc

[Greg KH <gregkh@linuxfoundation.org>]

On Sun, Mar 22, 2015 at 09:28:14PM +0300, Haneen Mohammed wrote:
> This patch replace bit shifting on 0,1,2, and 3 with the BIT(x) macro.
> Issue addressed by checkpatcg.pl.
> 
> This was done with the help of Coccinelle:
> 
> @r1@
> constant int g;
> @@
> 
> (
> 0<<g
> |
> 1<<g
> |
> 2<<g
> |
> 3<<g
> )
> 
> @script:python b@
> g2 <<r1.g;
> y;
> @@
> 
> coccinelle.y = int(g2) + 1
> 
> @c@
> constant int r1.g;
> identifier b.y;
> @@
> 
> (
> -(1 << g)
> +BIT(g)
> |
> -(0 << g)
> + 0
> |
> -(2 << g)
> +BIT(y)
> |
> -(3 << g)
> +(BIT(y)| BIT(g))
> )
> 
> Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com>
> ---
>  drivers/staging/iio/adc/ad7192.c    | 64 ++++++++++++++++++------------------
>  drivers/staging/iio/adc/ad7280a.c   | 58 ++++++++++++++++-----------------
>  drivers/staging/iio/adc/ad7780.c    | 18 +++++-----
>  drivers/staging/iio/adc/ad7816.c    |  2 +-
>  drivers/staging/iio/adc/mxs-lradc.c | 65 +++++++++++++++++++------------------
>  drivers/staging/iio/adc/spear_adc.c |  6 ++--
>  6 files changed, 107 insertions(+), 106 deletions(-)

This patch causes a bunch of compiler warnings to suddenly show up.  I
know it's not directly your fault, but I can't take this patch because
of it.  Feel free to break up your patch to not include the offending
file (hint, I'm not going to tell you because you should have caught
this yourself), or send a patch series that includes this one and then
fixes up those warnings.

thanks,

greg k-h