From: Greg KH <gregkh@linuxfoundation.org>
To: Haneen Mohammed <hamohammed.sa@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH v2] Staging: iio: use the BIT macro in adc
Date: Wed, 25 Mar 2015 12:15:42 +0100 [thread overview]
Message-ID: <20150325111542.GA24082@kroah.com> (raw)
In-Reply-To: <1427211295-26140-1-git-send-email-hamohammed.sa@gmail.com>
On Tue, Mar 24, 2015 at 06:34:55PM +0300, Haneen Mohammed wrote:
> This patch replaces bit shifting on:
> 0,1,2, and 3 with the BIT(x) macro.
> Issue addressed by checkpatcg.pl.
> This was done with the help of Coccinelle:
>
> @r1@
> constant int g;
> @@
>
> (
> 0<<g
> |
> 1<<g
> |
> 2<<g
> |
> 3<<g
> )
>
> @script:python b@
> g2 <<r1.g;
> y;
> @@
> coccinelle.y = int(g2) + 1
>
> @c@
> constant int r1.g;
> identifier b.y;
> @@
>
> (
> -(1 << g)
> +BIT(g)
> |
> -(0 << g)
> + 0
> |
> -(2 << g)
> +BIT(y)
> |
> -(3 << g)
> +(BIT(y)| BIT(g))
> )
>
> Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com>
> ---
> v2: addressed compiler warnings due to prev change by undoing the change that triggered them
This patch doesn't apply to my tree, please redo it against a "clean"
version of my staging-testing branch of staging.git and resend.
thanks,
greg k-h
next prev parent reply other threads:[~2015-03-25 11:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-22 18:17 [PATCH 0/2] Staging: iio: use the BIT macro in .h and adc Haneen Mohammed
2015-03-22 18:23 ` [PATCH 1/2] Staging: iio: use the BIT macro in .h files Haneen Mohammed
2015-03-22 18:28 ` [PATCH 2/2] Staging: iio: use the BIT macro in adc Haneen Mohammed
2015-03-23 21:25 ` [Outreachy kernel] " Greg KH
2015-03-24 15:34 ` [PATCH v2] " Haneen Mohammed
2015-03-25 11:15 ` Greg KH [this message]
2015-03-25 23:23 ` [PATCH v3] " Haneen Mohammed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150325111542.GA24082@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=hamohammed.sa@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.