From: Greg KH <gregkh@linuxfoundation.org>
To: Marianne Moeller Knudsen <marianne@masu.dk>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH] staging: sm750fb: Replace printk with pr_debug
Date: Mon, 23 Mar 2015 22:30:38 +0100 [thread overview]
Message-ID: <20150323213038.GA26335@kroah.com> (raw)
In-Reply-To: <20150322200502.GA7693@debianvm>
On Sun, Mar 22, 2015 at 09:05:02PM +0100, Marianne Moeller Knudsen wrote:
> Replace printk without loglevel with pr_debug. Issue found by
> checkpatch.
>
> Signed-off-by: Marianne Moeller Knudsen <marianne@masu.dk>
> ---
> drivers/staging/sm750fb/ddk750_display.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/sm750fb/ddk750_display.c b/drivers/staging/sm750fb/ddk750_display.c
> index c84196a..9f768a3 100644
> --- a/drivers/staging/sm750fb/ddk750_display.c
> +++ b/drivers/staging/sm750fb/ddk750_display.c
> @@ -51,7 +51,7 @@ static void setDisplayControl(int ctrl,int dispState)
> POKE32(PANEL_DISPLAY_CTRL, ulDisplayCtrlReg);
> } while((PEEK32(PANEL_DISPLAY_CTRL) & ~ulReservedBits) !=
> (ulDisplayCtrlReg & ~ulReservedBits));
> - printk("Set Panel Plane enbit:after tried %d times\n",cnt);
> + pr_debug("Set Panel Plane enbit:after tried %d times\n",cnt);
It's a driver, it should use dev_debug() instead please.
thanks,
greg k-h
next prev parent reply other threads:[~2015-03-23 23:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-22 20:05 [PATCH] staging: sm750fb: Replace printk with pr_debug Marianne Moeller Knudsen
2015-03-23 21:30 ` Greg KH [this message]
2015-03-24 6:37 ` [Outreachy kernel] " Julia Lawall
2015-03-24 9:45 ` Greg KH
2015-03-29 19:40 ` Marianne Moeller Knudsen
2015-03-29 19:44 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150323213038.GA26335@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=marianne@masu.dk \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.