Re: [Outreachy kernel] [PATCH] staging: sm750fb: Replace printk with pr_debug

[Marianne Moeller Knudsen <marianne@masu.dk>]

On Tue, Mar 24, 2015 at 10:45:14AM +0100, Greg KH wrote:
> On Tue, Mar 24, 2015 at 07:37:31AM +0100, Julia Lawall wrote:
> > 
> > 
> > On Mon, 23 Mar 2015, Greg KH wrote:
> > 
> > > On Sun, Mar 22, 2015 at 09:05:02PM +0100, Marianne Moeller Knudsen wrote:
> > > > Replace printk without loglevel with pr_debug. Issue found by
> > > > checkpatch.
> > > > 
> > > > Signed-off-by: Marianne Moeller Knudsen <marianne@masu.dk>
> > > > ---
> > > >  drivers/staging/sm750fb/ddk750_display.c |    2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > 
> > > > diff --git a/drivers/staging/sm750fb/ddk750_display.c b/drivers/staging/sm750fb/ddk750_display.c
> > > > index c84196a..9f768a3 100644
> > > > --- a/drivers/staging/sm750fb/ddk750_display.c
> > > > +++ b/drivers/staging/sm750fb/ddk750_display.c
> > > > @@ -51,7 +51,7 @@ static void setDisplayControl(int ctrl,int dispState)
> > > >  				POKE32(PANEL_DISPLAY_CTRL, ulDisplayCtrlReg);
> > > >  			} while((PEEK32(PANEL_DISPLAY_CTRL) & ~ulReservedBits) !=
> > > >  					(ulDisplayCtrlReg & ~ulReservedBits));
> > > > -			printk("Set Panel Plane enbit:after tried %d times\n",cnt);
> > > > +			pr_debug("Set Panel Plane enbit:after tried %d times\n",cnt);
> > > 
> > > It's a driver, it should use dev_debug() instead please.
> > 
> > The @@ line shows that the function only has integer arguments.  Is it 
> > acceptable to add arguments just for debug messages?
> 
> Yes, it's talking to hardware, so we need to know the exact device that
> caused the message.  Random messages like this don't help anyone out as
> it doesn't describe the device, the file, the driver, or much of
> anything else :(
> 
> thanks,
> 
> greg k-h

I've tried to make some code changes in order to use dev_dbg instead by passing fb_info. Maybe I could get some comments/hints/omgwhathaveyoudone on it? and if so how should I post it?

Thank you.