From: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: peterz@infradead.org, linuxppc-dev@lists.ozlabs.org,
Paul Mackerras <paulus@samba.org>,
linux-kernel@vger.kernel.org
Subject: Re: [8/9] powerpc/hv-24x7: Break up single_24x7_request
Date: Mon, 23 Mar 2015 14:55:19 -0700 [thread overview]
Message-ID: <20150323215519.GA6013@us.ibm.com> (raw)
In-Reply-To: <20150317022358.8DE1D14011D@ozlabs.org>
Michael Ellerman [mpe@ellerman.id.au] wrote:
| > +static void start_24x7_get_data(struct hv_24x7_request_buffer *request_buffer,
| > + struct hv_24x7_data_result_buffer *result_buffer)
| > +{
|
| Just init_24x7_request() ?
Sure.
|
| > +
| > + memset(request_buffer, 0, 4096);
| > + memset(result_buffer, 0, 4096);
| > +
| > + request_buffer->interface_version = HV_24X7_IF_VERSION_CURRENT;
| > + /* memset above set request_buffer->num_requests to 0 */
| > +}
| > +
| > +/*
| > + * Commit (i.e perform) the H_GET_24x7_DATA hcall using the data collected
| > + * by 'start_24x7_get_data()' and 'add_event_to_24x7_request()'.
| > + */
| > +static int commit_24x7_get_data(struct hv_24x7_request_buffer *request_buffer,
| > + struct hv_24x7_data_result_buffer *result_buffer)
| > +{
|
| It don't like "commit" that is a loaded term.
|
| Just make_24x7_request() perhaps?
Sure.
Thanks
Sukadev
WARNING: multiple messages have this Message-ID (diff)
From: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Paul Mackerras <paulus@samba.org>,
peterz@infradead.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [8/9] powerpc/hv-24x7: Break up single_24x7_request
Date: Mon, 23 Mar 2015 14:55:19 -0700 [thread overview]
Message-ID: <20150323215519.GA6013@us.ibm.com> (raw)
In-Reply-To: <20150317022358.8DE1D14011D@ozlabs.org>
Michael Ellerman [mpe@ellerman.id.au] wrote:
| > +static void start_24x7_get_data(struct hv_24x7_request_buffer *request_buffer,
| > + struct hv_24x7_data_result_buffer *result_buffer)
| > +{
|
| Just init_24x7_request() ?
Sure.
|
| > +
| > + memset(request_buffer, 0, 4096);
| > + memset(result_buffer, 0, 4096);
| > +
| > + request_buffer->interface_version = HV_24X7_IF_VERSION_CURRENT;
| > + /* memset above set request_buffer->num_requests to 0 */
| > +}
| > +
| > +/*
| > + * Commit (i.e perform) the H_GET_24x7_DATA hcall using the data collected
| > + * by 'start_24x7_get_data()' and 'add_event_to_24x7_request()'.
| > + */
| > +static int commit_24x7_get_data(struct hv_24x7_request_buffer *request_buffer,
| > + struct hv_24x7_data_result_buffer *result_buffer)
| > +{
|
| It don't like "commit" that is a loaded term.
|
| Just make_24x7_request() perhaps?
Sure.
Thanks
Sukadev
next prev parent reply other threads:[~2015-03-23 21:57 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-17 22:00 [PATCH 0/9] powerpc/hv-24x7: Reorganize single_24x7_request() Sukadev Bhattiprolu
2015-02-17 22:00 ` Sukadev Bhattiprolu
2015-02-17 22:00 ` [PATCH 1/9] powerpc/hv-24x7: Modify definition of request and result buffers Sukadev Bhattiprolu
2015-02-17 22:00 ` Sukadev Bhattiprolu
2015-02-17 22:00 ` [PATCH 2/9] powerpc/hv24x7: Remove unnecessary parameter Sukadev Bhattiprolu
2015-02-17 22:00 ` Sukadev Bhattiprolu
2015-03-17 0:13 ` [2/9] " Michael Ellerman
2015-03-23 22:17 ` Sukadev Bhattiprolu
2015-03-23 22:17 ` Sukadev Bhattiprolu
2015-02-17 22:00 ` [PATCH 3/9] powerpc/hv-24x7: Drop event_24x7_request() Sukadev Bhattiprolu
2015-02-17 22:00 ` Sukadev Bhattiprolu
2015-03-17 2:16 ` [3/9] " Michael Ellerman
2015-02-17 22:00 ` [PATCH 4/9] powerpc/hv24x7: Move debug prints to separate function Sukadev Bhattiprolu
2015-02-17 22:00 ` Sukadev Bhattiprolu
2015-02-17 22:00 ` [PATCH 5/9] powerpc/hv-24x7: Rename hv_24x7_event_update Sukadev Bhattiprolu
2015-02-17 22:00 ` Sukadev Bhattiprolu
2015-02-17 22:00 ` [PATCH 6/9] powerpc/hv-24x7: Define add_event_to_24x7_request() Sukadev Bhattiprolu
2015-02-17 22:00 ` Sukadev Bhattiprolu
2015-03-17 2:18 ` [6/9] " Michael Ellerman
2015-02-17 22:00 ` [PATCH 7/9] powerpc/hv-24x7: Define update_event_count() Sukadev Bhattiprolu
2015-02-17 22:00 ` Sukadev Bhattiprolu
2015-02-17 22:00 ` [PATCH 8/9] powerpc/hv-24x7: Break up single_24x7_request Sukadev Bhattiprolu
2015-02-17 22:00 ` Sukadev Bhattiprolu
2015-03-17 2:23 ` [8/9] " Michael Ellerman
2015-03-23 21:55 ` Sukadev Bhattiprolu [this message]
2015-03-23 21:55 ` Sukadev Bhattiprolu
2015-02-17 22:00 ` [PATCH 9/9] powerpc/hv-24x7: Add missing put_cpu_var() Sukadev Bhattiprolu
2015-02-17 22:00 ` Sukadev Bhattiprolu
2015-03-17 2:39 ` [9/9] " Michael Ellerman
2015-03-23 21:47 ` Sukadev Bhattiprolu
2015-03-23 21:47 ` Sukadev Bhattiprolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150323215519.GA6013@us.ibm.com \
--to=sukadev@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.