* Re: [PATCH] tty/serial: omap: fix !wakeirq message
[not found] <1427150324-12600-1-git-send-email-rdkehn@yahoo.com>
@ 2015-03-23 23:15 ` Greg KH
0 siblings, 0 replies; only message in thread
From: Greg KH @ 2015-03-23 23:15 UTC (permalink / raw)
To: Doug Kehn; +Cc: linux-sreial, linux-omap, tony
On Mon, Mar 23, 2015 at 05:38:44PM -0500, Doug Kehn wrote:
> When wakeirq is not used/enabled, "no wakeirq for uart0" is output for
> all TTY as the log message is generated before the port line is
> initialized.
>
> [ 0.802656] Serial: 8250/16550 driver, 4 ports, IRQ sharing enabled
> [ 0.811700] omap_uart 44e09000.serial: no wakeirq for uart0
> [ 0.812379] 44e09000.serial: ttyO0 at MMIO 0x44e09000 (irq = 88, base_baud = 3000000) is a OMAP UART0
> [ 1.503622] console [ttyO0] enabled
> [ 1.509836] omap_uart 48022000.serial: no wakeirq for uart0
> [ 1.516118] 48022000.serial: ttyO1 at MMIO 0x48022000 (irq = 89, base_baud = 3000000) is a OMAP UART1
> [ 1.527711] omap_uart 48024000.serial: no wakeirq for uart0
> [ 1.533881] 48024000.serial: ttyO2 at MMIO 0x48024000 (irq = 90, base_baud = 3000000) is a OMAP UART2
> [ 1.545324] omap_uart 481a6000.serial: no wakeirq for uart0
> [ 1.551410] 481a6000.serial: ttyO3 at MMIO 0x481a6000 (irq = 60, base_baud = 3000000) is a OMAP UART3
> [ 1.562946] omap_uart 481a8000.serial: no wakeirq for uart0
> [ 1.569036] 481a8000.serial: ttyO4 at MMIO 0x481a8000 (irq = 61, base_baud = 3000000) is a OMAP UART4
>
> Fix by moving wakeirq check and dev_info() call to after port line
> initialization and validation.
>
> Patch is against 3.14.36.
That's really old, please make this against a "modern" kernel, like the
4.0-rc series.
thanks,
greg k-h
^ permalink raw reply [flat|nested] only message in thread