From: Christoph Hellwig <hch@lst.de>
To: Mike Snitzer <snitzer@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>,
David Howells <dhowells@redhat.com>,
linux-nfs@vger.kernel.org, linux-mm@kvack.org,
Jens Axboe <axboe@fb.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
device-mapper development <dm-devel@redhat.com>,
linux-mtd@lists.infradead.org, Tejun Heo <tj@kernel.org>,
ceph-devel@vger.kernel.org, Jeff Moyer <jmoyer@redhat.com>
Subject: Re: [PATCH 11/12] fs: don't reassign dirty inodes to default_backing_dev_info
Date: Tue, 24 Mar 2015 07:53:25 +0100 [thread overview]
Message-ID: <20150324065325.GC3159@lst.de> (raw)
In-Reply-To: <20150323224012.GA29505@redhat.com>
On Mon, Mar 23, 2015 at 06:40:13PM -0400, Mike Snitzer wrote:
> FYI, here is the DM fix I've staged for 4.0-rc6. I'll continue testing
> the various DM targets before requesting Linus to pull.
Yeah, from looking at the bugzilla it seemed like dm was releasing the
dev_t before the queue has been freed.
I don't know this code to well, so this isn't a full review, but it looks like
the right fix to me.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Mike Snitzer <snitzer@redhat.com>
Cc: Jens Axboe <axboe@fb.com>,
linux-nfs@vger.kernel.org, Jeff Moyer <jmoyer@redhat.com>,
David Howells <dhowells@redhat.com>,
linux-mm@kvack.org,
device-mapper development <dm-devel@redhat.com>,
linux-mtd@lists.infradead.org,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Tejun Heo <tj@kernel.org>,
ceph-devel@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 11/12] fs: don't reassign dirty inodes to default_backing_dev_info
Date: Tue, 24 Mar 2015 07:53:25 +0100 [thread overview]
Message-ID: <20150324065325.GC3159@lst.de> (raw)
In-Reply-To: <20150323224012.GA29505@redhat.com>
On Mon, Mar 23, 2015 at 06:40:13PM -0400, Mike Snitzer wrote:
> FYI, here is the DM fix I've staged for 4.0-rc6. I'll continue testing
> the various DM targets before requesting Linus to pull.
Yeah, from looking at the bugzilla it seemed like dm was releasing the
dev_t before the queue has been freed.
I don't know this code to well, so this isn't a full review, but it looks like
the right fix to me.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Mike Snitzer <snitzer@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>,
David Howells <dhowells@redhat.com>,
linux-nfs@vger.kernel.org, linux-mm@kvack.org,
Jens Axboe <axboe@fb.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
device-mapper development <dm-devel@redhat.com>,
linux-mtd@lists.infradead.org, Tejun Heo <tj@kernel.org>,
ceph-devel@vger.kernel.org, Jeff Moyer <jmoyer@redhat.com>
Subject: Re: [PATCH 11/12] fs: don't reassign dirty inodes to default_backing_dev_info
Date: Tue, 24 Mar 2015 07:53:25 +0100 [thread overview]
Message-ID: <20150324065325.GC3159@lst.de> (raw)
In-Reply-To: <20150323224012.GA29505@redhat.com>
On Mon, Mar 23, 2015 at 06:40:13PM -0400, Mike Snitzer wrote:
> FYI, here is the DM fix I've staged for 4.0-rc6. I'll continue testing
> the various DM targets before requesting Linus to pull.
Yeah, from looking at the bugzilla it seemed like dm was releasing the
dev_t before the queue has been freed.
I don't know this code to well, so this isn't a full review, but it looks like
the right fix to me.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-03-24 6:53 UTC|newest]
Thread overview: 110+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-14 9:42 backing_dev_info cleanups & lifetime rule fixes V2 Christoph Hellwig
2015-01-14 9:42 ` Christoph Hellwig
2015-01-14 9:42 ` Christoph Hellwig
2015-01-14 9:42 ` [PATCH 01/12] fs: deduplicate noop_backing_dev_info Christoph Hellwig
2015-01-14 9:42 ` Christoph Hellwig
2015-01-14 9:42 ` Christoph Hellwig
2015-01-14 12:41 ` Jan Kara
2015-01-14 12:41 ` Jan Kara
2015-01-14 12:41 ` Jan Kara
2015-01-14 9:42 ` [PATCH 02/12] fs: kill BDI_CAP_SWAP_BACKED Christoph Hellwig
2015-01-14 9:42 ` Christoph Hellwig
2015-01-14 9:42 ` Christoph Hellwig
2015-01-14 12:47 ` Jan Kara
2015-01-14 12:47 ` Jan Kara
2015-01-14 12:47 ` Jan Kara
2015-01-14 9:42 ` [PATCH 03/12] fs: introduce f_op->mmap_capabilities for nommu mmap support Christoph Hellwig
2015-01-14 9:42 ` Christoph Hellwig
2015-01-14 9:42 ` Christoph Hellwig
[not found] ` <1421228561-16857-4-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2015-01-16 4:06 ` Brian Norris
2015-01-16 4:06 ` Brian Norris
2015-01-16 4:06 ` Brian Norris
2015-01-16 4:06 ` Brian Norris
2015-01-14 9:42 ` [PATCH 04/12] block_dev: only write bdev inode on close Christoph Hellwig
2015-01-14 9:42 ` Christoph Hellwig
2015-01-14 9:42 ` Christoph Hellwig
2015-01-14 12:58 ` Jan Kara
2015-01-14 12:58 ` Jan Kara
2015-01-14 12:58 ` Jan Kara
2015-01-14 9:42 ` [PATCH 05/12] block_dev: get bdev inode bdi directly from the block device Christoph Hellwig
2015-01-14 9:42 ` Christoph Hellwig
2015-01-14 9:42 ` Christoph Hellwig
2015-01-14 13:00 ` Jan Kara
2015-01-14 13:00 ` Jan Kara
2015-01-14 13:00 ` Jan Kara
2015-01-14 9:42 ` [PATCH 06/12] nilfs2: set up s_bdi like the generic mount_bdev code Christoph Hellwig
2015-01-14 9:42 ` Christoph Hellwig
2015-01-14 9:42 ` Christoph Hellwig
2015-01-14 13:05 ` Jan Kara
2015-01-14 13:05 ` Jan Kara
2015-01-14 13:05 ` Jan Kara
2015-01-14 9:42 ` [PATCH 07/12] fs: export inode_to_bdi and use it in favor of mapping->backing_dev_info Christoph Hellwig
2015-01-14 9:42 ` Christoph Hellwig
2015-01-14 9:42 ` Christoph Hellwig
2015-01-14 13:31 ` Jan Kara
2015-01-14 13:31 ` Jan Kara
2015-01-14 13:31 ` Jan Kara
2015-01-14 9:42 ` [PATCH 08/12] fs: remove mapping->backing_dev_info Christoph Hellwig
2015-01-14 9:42 ` Christoph Hellwig
2015-01-14 9:42 ` Christoph Hellwig
2015-01-15 10:57 ` Jan Kara
2015-01-15 10:57 ` Jan Kara
2015-01-15 10:57 ` Jan Kara
[not found] ` <1421228561-16857-1-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2015-01-14 9:42 ` [PATCH 09/12] ceph: remove call to bdi_unregister Christoph Hellwig
2015-01-14 9:42 ` Christoph Hellwig
2015-01-14 9:42 ` Christoph Hellwig
2015-01-14 9:42 ` Christoph Hellwig
2015-01-14 13:44 ` Jan Kara
2015-01-14 13:44 ` Jan Kara
2015-01-14 13:44 ` Jan Kara
2015-01-14 9:42 ` [PATCH 10/12] nfs: don't call bdi_unregister Christoph Hellwig
2015-01-14 9:42 ` Christoph Hellwig
2015-01-14 9:42 ` Christoph Hellwig
2015-01-14 13:51 ` Jan Kara
2015-01-14 13:51 ` Jan Kara
2015-01-14 13:51 ` Jan Kara
2015-01-14 9:42 ` [PATCH 11/12] fs: don't reassign dirty inodes to default_backing_dev_info Christoph Hellwig
2015-01-14 9:42 ` Christoph Hellwig
2015-01-14 9:42 ` Christoph Hellwig
[not found] ` <1421228561-16857-12-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2015-01-14 13:59 ` Jan Kara
2015-01-14 13:59 ` Jan Kara
2015-01-14 13:59 ` Jan Kara
2015-01-14 13:59 ` Jan Kara
2015-03-21 15:11 ` Mike Snitzer
2015-03-21 15:11 ` Mike Snitzer
2015-03-21 15:11 ` Mike Snitzer
2015-03-21 15:11 ` Mike Snitzer
2015-03-23 22:40 ` Mike Snitzer
2015-03-23 22:40 ` Mike Snitzer
2015-03-23 22:40 ` Mike Snitzer
2015-03-23 22:40 ` Mike Snitzer
2015-03-24 6:53 ` Christoph Hellwig [this message]
2015-03-24 6:53 ` Christoph Hellwig
2015-03-24 6:53 ` Christoph Hellwig
2015-01-14 9:42 ` [PATCH 12/12] fs: remove default_backing_dev_info Christoph Hellwig
2015-01-14 9:42 ` Christoph Hellwig
2015-01-14 9:42 ` Christoph Hellwig
2015-01-14 14:05 ` Jan Kara
2015-01-14 14:05 ` Jan Kara
2015-01-14 14:05 ` Jan Kara
2015-01-20 21:08 ` backing_dev_info cleanups & lifetime rule fixes V2 Jens Axboe
2015-01-20 21:08 ` Jens Axboe
2015-01-20 21:08 ` Jens Axboe
2015-01-20 21:08 ` Jens Axboe
2015-02-01 6:31 ` Al Viro
2015-02-01 6:31 ` Al Viro
2015-02-01 6:31 ` Al Viro
[not found] ` <20150201063116.GP29656-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@public.gmane.org>
2015-02-02 8:06 ` Christoph Hellwig
2015-02-02 8:06 ` Christoph Hellwig
2015-02-02 8:06 ` Christoph Hellwig
2015-02-02 8:06 ` Christoph Hellwig
2015-02-02 17:08 ` Jens Axboe
2015-02-02 17:08 ` Jens Axboe
2015-02-02 17:08 ` Jens Axboe
2015-02-02 17:08 ` Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2015-01-08 17:45 backing_dev_info cleanups & lifetime rule fixes Christoph Hellwig
2015-01-08 17:45 ` [PATCH 11/12] fs: don't reassign dirty inodes to default_backing_dev_info Christoph Hellwig
2015-01-08 17:45 ` Christoph Hellwig
2015-01-08 17:45 ` Christoph Hellwig
2015-01-11 18:33 ` Tejun Heo
2015-01-11 18:33 ` Tejun Heo
2015-01-11 18:33 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150324065325.GC3159@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=ceph-devel@vger.kernel.org \
--cc=dhowells@redhat.com \
--cc=dm-devel@redhat.com \
--cc=jmoyer@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-nfs@vger.kernel.org \
--cc=snitzer@redhat.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.