All of lore.kernel.org
 help / color / mirror / Atom feed
From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: cygnus: fix const declaration bcm_cygnus_dt_compat
Date: Tue, 24 Mar 2015 08:21:34 +0100	[thread overview]
Message-ID: <20150324072134.GO5664@pengutronix.de> (raw)
In-Reply-To: <1426981535-1800-1-git-send-email-stefan@agner.ch>

Hello Stefan,

On Sun, Mar 22, 2015 at 12:45:35AM +0100, Stefan Agner wrote:
> The const declaration for char* is actually duplicated, however
> the array of strings is currently not constant. However, typically
> the dt_compat array is declared as const char *const. Follow
> that convention and also add the __initconst macro for constant
> initialization data.
> 
> Signed-off-by: Stefan Agner <stefan@agner.ch>
Acked-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>

Thanks
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

WARNING: multiple messages have this Message-ID (diff)
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Stefan Agner <stefan@agner.ch>
Cc: rjui@broadcom.com, sbranden@broadcom.com, f.fainelli@gmail.com,
	linux@arm.linux.org.uk, bcm@fixthebug.org,
	llvmlinux@lists.linuxfoundation.org,
	linux-kernel@vger.kernel.org, mporter@linaro.org,
	jonathar@broadcom.com, bcm-kernel-feedback-list@broadcom.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: cygnus: fix const declaration bcm_cygnus_dt_compat
Date: Tue, 24 Mar 2015 08:21:34 +0100	[thread overview]
Message-ID: <20150324072134.GO5664@pengutronix.de> (raw)
In-Reply-To: <1426981535-1800-1-git-send-email-stefan@agner.ch>

Hello Stefan,

On Sun, Mar 22, 2015 at 12:45:35AM +0100, Stefan Agner wrote:
> The const declaration for char* is actually duplicated, however
> the array of strings is currently not constant. However, typically
> the dt_compat array is declared as const char *const. Follow
> that convention and also add the __initconst macro for constant
> initialization data.
> 
> Signed-off-by: Stefan Agner <stefan@agner.ch>
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Thanks
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

  parent reply	other threads:[~2015-03-24  7:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-21 23:45 [PATCH] ARM: cygnus: fix const declaration bcm_cygnus_dt_compat Stefan Agner
2015-03-21 23:45 ` Stefan Agner
2015-03-24  5:18 ` Scott Branden
2015-03-24  5:18   ` Scott Branden
2015-03-24  5:22   ` Ray Jui
2015-03-24  5:22     ` Ray Jui
2015-03-24  7:21 ` Uwe Kleine-König [this message]
2015-03-24  7:21   ` Uwe Kleine-König
2015-03-24 22:14 ` Florian Fainelli
2015-03-24 22:14   ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150324072134.GO5664@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.