From: Mark Brown <broonie@kernel.org>
To: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Cc: lgirdwood@gmail.com, linux-kernel@vger.kernel.org,
patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH] regulator: arizona-ldo1: Add ramp time for HI_PWR
Date: Tue, 24 Mar 2015 09:06:09 -0700 [thread overview]
Message-ID: <20150324160609.GD17265@sirena.org.uk> (raw)
In-Reply-To: <1427207276-28038-1-git-send-email-ckeepax@opensource.wolfsonmicro.com>
[-- Attachment #1: Type: text/plain, Size: 618 bytes --]
On Tue, Mar 24, 2015 at 02:27:56PM +0000, Charles Keepax wrote:
> +static int arizona_ldo1_hc_set_voltage_time_sel(struct regulator_dev *rdev,
> + unsigned int old_selector,
> + unsigned int new_selector)
> +{
> + /* if moving to 1.8v allow time for it to reach voltage */
> + if (new_selector == rdev->desc->n_voltages - 1)
> + return 25;
> + else
> + return 0;
> +}
So changes to move to the top voltage always take constant time while
all other voltage changes are instantaneous? That doesn't seem right.
I'd expect something more like a calculation based on some number of
miliseconds per milivolt.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-03-24 16:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-24 14:27 [PATCH] regulator: arizona-ldo1: Add ramp time for HI_PWR Charles Keepax
2015-03-24 16:06 ` Mark Brown [this message]
2015-03-24 16:40 ` Charles Keepax
2015-03-24 17:05 ` Charles Keepax
2015-03-24 17:20 ` Mark Brown
2015-03-24 17:05 ` Mark Brown
2015-03-24 17:19 ` Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150324160609.GD17265@sirena.org.uk \
--to=broonie@kernel.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.