All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-ide@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	rsarmah@amcc.com, Alexey Brodkin <Alexey.Brodkin@synopsys.com>
Subject: Re: [PATCH v1 2/2] sata_dwc_460ex: re-use hsdev->dev instead of dwc_dev
Date: Tue, 24 Mar 2015 13:51:16 -0400	[thread overview]
Message-ID: <20150324175116.GL3880@htj.duckdns.org> (raw)
In-Reply-To: <1425415282-3750-3-git-send-email-andriy.shevchenko@linux.intel.com>

On Tue, Mar 03, 2015 at 10:41:22PM +0200, Andy Shevchenko wrote:
> This patch re-uses hsdev->dev which is allocated on heap. Therefore, the
> private structure, which is global variable, is reduced by one field.
> 
> In one case ap->dev is used and there it seems to be right decision.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Applied 1-2 to libata/for-4.1.

Thanks.

-- 
tejun

WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Alexey Brodkin <Alexey.Brodkin@synopsys.com>,
	linux-ide@vger.kernel.org, rsarmah@amcc.com,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v1 2/2] sata_dwc_460ex: re-use hsdev->dev instead of dwc_dev
Date: Tue, 24 Mar 2015 13:51:16 -0400	[thread overview]
Message-ID: <20150324175116.GL3880@htj.duckdns.org> (raw)
In-Reply-To: <1425415282-3750-3-git-send-email-andriy.shevchenko@linux.intel.com>

On Tue, Mar 03, 2015 at 10:41:22PM +0200, Andy Shevchenko wrote:
> This patch re-uses hsdev->dev which is allocated on heap. Therefore, the
> private structure, which is global variable, is reduced by one field.
> 
> In one case ap->dev is used and there it seems to be right decision.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Applied 1-2 to libata/for-4.1.

Thanks.

-- 
tejun

  reply	other threads:[~2015-03-24 17:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-03 20:41 [PATCH v1 0/2] sata_dwc_460ex: move to generic DMA driver Andy Shevchenko
2015-03-03 20:41 ` [PATCH v1 1/2] " Andy Shevchenko
2015-11-22 13:03   ` Måns Rullgård
2015-11-22 13:03     ` Måns Rullgård
2015-11-23 10:10     ` Andy Shevchenko
2015-11-23 11:58       ` Måns Rullgård
2015-11-23 11:58         ` Måns Rullgård
2015-03-03 20:41 ` [PATCH v1 2/2] sata_dwc_460ex: re-use hsdev->dev instead of dwc_dev Andy Shevchenko
2015-03-24 17:51   ` Tejun Heo [this message]
2015-03-24 17:51     ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150324175116.GL3880@htj.duckdns.org \
    --to=tj@kernel.org \
    --cc=Alexey.Brodkin@synopsys.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=benh@kernel.crashing.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=rsarmah@amcc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.