Re: [PATCH] drm/i915: make unsupported fb modifier message DRM_DEBUG

From: Daniel Vetter <daniel@ffwll.ch>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: make unsupported fb modifier message	DRM_DEBUG
Date: Wed, 25 Mar 2015 14:28:47 +0100	[thread overview]
Message-ID: <20150325132847.GA1349@phenom.ffwll.local> (raw)
In-Reply-To: <87mw32u7rk.fsf@intel.com>

On Tue, Mar 24, 2015 at 10:19:59AM +0200, Jani Nikula wrote:
> On Mon, 23 Mar 2015, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> > Or users can just spam the log all they want.
> >
> > References: https://bugs.freedesktop.org/show_bug.cgi?id=89628
> > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> 
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>

Queued for -next, thanks for the patch. And please reference the commit
that introduce some broken code and cc author/reviewer of said commit.
We're just going through some fun because a cherry-pick broke -rc and it's
hard to find all the fixups in -next because they're not properly
referenced.
-Daniel

> 
> 
> > ---
> >  drivers/gpu/drm/i915/intel_display.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> > index 589addf..c48e2d7 100644
> > --- a/drivers/gpu/drm/i915/intel_display.c
> > +++ b/drivers/gpu/drm/i915/intel_display.c
> > @@ -12831,8 +12831,8 @@ static int intel_framebuffer_init(struct drm_device *dev,
> >  	case I915_FORMAT_MOD_X_TILED:
> >  		break;
> >  	default:
> > -		DRM_ERROR("Unsupported fb modifier 0x%llx!\n",
> > -				mode_cmd->modifier[0]);
> > +		DRM_DEBUG("Unsupported fb modifier 0x%llx!\n",
> > +			  mode_cmd->modifier[0]);
> >  		return -EINVAL;
> >  	}
> >  
> > -- 
> > 1.9.1
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
> 
> -- 
> Jani Nikula, Intel Open Source Technology Center
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx