All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Jesse Barnes <jbarnes@virtuousgeek.org>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: make unsupported fb modifier message DRM_DEBUG
Date: Tue, 24 Mar 2015 11:23:48 +0000	[thread overview]
Message-ID: <55114944.3010908@linux.intel.com> (raw)
In-Reply-To: <1427139830-18720-1-git-send-email-jbarnes@virtuousgeek.org>


On 03/23/2015 07:43 PM, Jesse Barnes wrote:
> Or users can just spam the log all they want.
>
> References: https://bugs.freedesktop.org/show_bug.cgi?id=89628
> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> ---
>   drivers/gpu/drm/i915/intel_display.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 589addf..c48e2d7 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -12831,8 +12831,8 @@ static int intel_framebuffer_init(struct drm_device *dev,
>   	case I915_FORMAT_MOD_X_TILED:
>   		break;
>   	default:
> -		DRM_ERROR("Unsupported fb modifier 0x%llx!\n",
> -				mode_cmd->modifier[0]);
> +		DRM_DEBUG("Unsupported fb modifier 0x%llx!\n",
> +			  mode_cmd->modifier[0]);
>   		return -EINVAL;
>   	}

Ooops! The one that got away.. I always think about this very issue as 
you can see from three DRM_DEBUGs just above this offender. No idea how 
this one sneaked in but thanks for fixing it!

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2015-03-24 11:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-23 19:43 [PATCH] drm/i915: make unsupported fb modifier message DRM_DEBUG Jesse Barnes
2015-03-24  8:19 ` Jani Nikula
2015-03-25 13:28   ` Daniel Vetter
2015-03-25 15:47     ` Jesse Barnes
2015-03-25 17:24       ` Daniel Vetter
2015-03-24 11:23 ` Tvrtko Ursulin [this message]
2015-03-24 14:33   ` Jesse Barnes
2015-03-25  3:44 ` shuang.he

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55114944.3010908@linux.intel.com \
    --to=tvrtko.ursulin@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jbarnes@virtuousgeek.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.