All of lore.kernel.org
 help / color / mirror / Atom feed
From: Minchan Kim <minchan@kernel.org>
To: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Nitin Gupta <ngupta@vflare.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Subject: Re: [PATCH 2/2] zsmalloc: micro-optimize zs_object_copy()
Date: Thu, 26 Mar 2015 00:07:50 +0900	[thread overview]
Message-ID: <20150325150750.GD3814@blaptop> (raw)
In-Reply-To: <1427210687-6634-3-git-send-email-sergey.senozhatsky@gmail.com>

On Wed, Mar 25, 2015 at 12:24:47AM +0900, Sergey Senozhatsky wrote:
> A micro-optimization. Avoid additional branching and reduce
> (a bit) registry pressure (f.e. s_off += size; d_off += size;
> may be calculated twise: first for >= PAGE_SIZE check and later
> for offset update in "else" clause).
> 
> /scripts/bloat-o-meter shows some improvement
> 
> add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-10 (-10)
> function                          old     new   delta
> zs_object_copy                    550     540     -10
> 
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>

Acked-by: Minchan Kim <minchan@kernel.org>

Thanks.

-- 
Kind regards,
Minchan Kim

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Minchan Kim <minchan@kernel.org>
To: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Nitin Gupta <ngupta@vflare.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Subject: Re: [PATCH 2/2] zsmalloc: micro-optimize zs_object_copy()
Date: Thu, 26 Mar 2015 00:07:50 +0900	[thread overview]
Message-ID: <20150325150750.GD3814@blaptop> (raw)
In-Reply-To: <1427210687-6634-3-git-send-email-sergey.senozhatsky@gmail.com>

On Wed, Mar 25, 2015 at 12:24:47AM +0900, Sergey Senozhatsky wrote:
> A micro-optimization. Avoid additional branching and reduce
> (a bit) registry pressure (f.e. s_off += size; d_off += size;
> may be calculated twise: first for >= PAGE_SIZE check and later
> for offset update in "else" clause).
> 
> /scripts/bloat-o-meter shows some improvement
> 
> add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-10 (-10)
> function                          old     new   delta
> zs_object_copy                    550     540     -10
> 
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>

Acked-by: Minchan Kim <minchan@kernel.org>

Thanks.

-- 
Kind regards,
Minchan Kim

  reply	other threads:[~2015-03-25 15:07 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-24 15:24 [PATCH 0/2] zs_object_copy() micro-optimizations Sergey Senozhatsky
2015-03-24 15:24 ` Sergey Senozhatsky
2015-03-24 15:24 ` [PATCH 1/2] zsmalloc: do not remap dst page while prepare next src page Sergey Senozhatsky
2015-03-24 15:24   ` Sergey Senozhatsky
2015-03-25  5:05   ` Heesub Shin
2015-03-25  5:05     ` Heesub Shin
2015-03-25  5:29     ` Sergey Senozhatsky
2015-03-25  5:29       ` Sergey Senozhatsky
2015-03-24 15:24 ` [PATCH 2/2] zsmalloc: micro-optimize zs_object_copy() Sergey Senozhatsky
2015-03-24 15:24   ` Sergey Senozhatsky
2015-03-25 15:07   ` Minchan Kim [this message]
2015-03-25 15:07     ` Minchan Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150325150750.GD3814@blaptop \
    --to=minchan@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ngupta@vflare.org \
    --cc=sergey.senozhatsky.work@gmail.com \
    --cc=sergey.senozhatsky@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.