From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
To: David Miller <davem@davemloft.net>
Cc: aik@au1.ibm.com, anton@au1.ibm.com, paulus@samba.org,
sparclinux@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v6 0/3] Generic IOMMU pooled allocator
Date: Wed, 25 Mar 2015 13:36:01 -0400 [thread overview]
Message-ID: <20150325173601.GA31861@oracle.com> (raw)
In-Reply-To: <20150324.181617.1094177939652695812.davem@davemloft.net>
On (03/24/15 18:16), David Miller wrote:
> Generally this looks fine to me.
>
> But about patch #2, I see no reason to have multiple iommu_pool_hash
> tables. Even from a purely sparc perspective, we can always just do
> with just one of them.
>
> Furthermore, you can even probably move it down into lib/iommu-common.c
> itself. iommu_tbl_pool_init() can do the one time initialization.
fixed in v7.
Ben, Alexey, do you need more time to review this?
--Sowmini
WARNING: multiple messages have this Message-ID (diff)
From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
To: David Miller <davem@davemloft.net>
Cc: aik@au1.ibm.com, anton@au1.ibm.com, paulus@samba.org,
sparclinux@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v6 0/3] Generic IOMMU pooled allocator
Date: Wed, 25 Mar 2015 17:36:01 +0000 [thread overview]
Message-ID: <20150325173601.GA31861@oracle.com> (raw)
In-Reply-To: <20150324.181617.1094177939652695812.davem@davemloft.net>
On (03/24/15 18:16), David Miller wrote:
> Generally this looks fine to me.
>
> But about patch #2, I see no reason to have multiple iommu_pool_hash
> tables. Even from a purely sparc perspective, we can always just do
> with just one of them.
>
> Furthermore, you can even probably move it down into lib/iommu-common.c
> itself. iommu_tbl_pool_init() can do the one time initialization.
fixed in v7.
Ben, Alexey, do you need more time to review this?
--Sowmini
next prev parent reply other threads:[~2015-03-25 17:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-24 17:10 [PATCH v6 0/3] Generic IOMMU pooled allocator Sowmini Varadhan
2015-03-24 17:10 ` Sowmini Varadhan
2015-03-24 17:10 ` [PATCH v6 RFC 1/3] sparc: Break up monolithic iommu table/lock into finer graularity pools and lock Sowmini Varadhan
2015-03-24 17:10 ` Sowmini Varadhan
2015-03-24 17:10 ` [PATCH v6 RFC 2/3] sparc: Make sparc64 use scalable lib/iommu-common.c functions Sowmini Varadhan
2015-03-24 17:10 ` Sowmini Varadhan
2015-03-24 17:10 ` [PATCH v6 RFC 3/3] sparc: Make LDC use common iommu poll management functions Sowmini Varadhan
2015-03-24 17:10 ` Sowmini Varadhan
2015-03-24 22:16 ` [PATCH v6 0/3] Generic IOMMU pooled allocator David Miller
2015-03-24 22:16 ` David Miller
2015-03-25 17:36 ` Sowmini Varadhan [this message]
2015-03-25 17:36 ` Sowmini Varadhan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150325173601.GA31861@oracle.com \
--to=sowmini.varadhan@oracle.com \
--cc=aik@au1.ibm.com \
--cc=anton@au1.ibm.com \
--cc=davem@davemloft.net \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.