All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Gerd Hoffmann <kraxel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: virtio-dev-sDuHXQ4OtrM4h7I2RyI4rWD2FQJk+8+b@public.gmane.org,
	Dave Airlie <airlied-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Dave Airlie <airlied-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	David Airlie <airlied-cv59FeDIM0c@public.gmane.org>,
	Rusty Russell <rusty-8n+1lVoiYb80n/F98K4Iww@public.gmane.org>,
	open list <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"open list:DRM DRIVERS"
	<dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>,
	"open list:VIRTIO CORE,
	NET..."
	<virtualization-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
	"open list:ABI/API"
	<linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [virtio-dev] Re: [PATCH] Add virtio gpu driver.
Date: Thu, 26 Mar 2015 17:47:09 +0100	[thread overview]
Message-ID: <20150326174401-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <1427382436.8786.15.camel-3OfP5uLMi4C46o+2HkPkLj4oCIwMql/M@public.gmane.org>

On Thu, Mar 26, 2015 at 04:07:16PM +0100, Gerd Hoffmann wrote:
>   Hi,
> 
> > I don't know. This seems exactly like the kind of thing
> > we had in mind when we added the virtio pci capability.
> > For example, we have text in spec that requires drivers
> > to skip unknown capabilities.
> > 
> > And yes, if bios pokes at a specific bar then we do
> > need to list this info in the virtio spec so this makes
> > it an issue that is virtio related.
> 
> Hmm, virtio-vga is a two-in-one device basically.  When virtio is
> enabled it behaves like virtio-gpu-pci, otherwise it behaves very
> simliar to stdvga.  So you need to know nothing about virtio to handle
> the vga side, and I want keep it that way.
> 
> When no vga compatibility is needed there always is the option to just
> use virtio-gpu-pci instead.
> 
> > Yes, it's not about what we put there now. It's about being able
> > to move things about in the future without breaking guests.
> 
> We don't have that today for stdvga, and I still fail to see what this
> buys us.
> 
> 
> Completely different thing crossing my mind:  I think we can make
> virtio-vga fully compatible with stdvga.  stdvga has two bars, memory
> (#0) and mmio (#2).  We can make the mmio bar larger and place all the
> virtio regions there.
> 

Full compatibility with some standard sounds like a better motivation,
yes.

> 
> I think in any case I'll go split off the vga compatibility bits to a
> different patch (and possible a separate patch series).
> 
> cheers,
>   Gerd

Will you still need me to change core to claim specific memory only?


-- 
MST

WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: virtio-dev@lists.oasis-open.org, Dave Airlie <airlied@gmail.com>,
	Dave Airlie <airlied@redhat.com>, David Airlie <airlied@linux.ie>,
	Rusty Russell <rusty@rustcorp.com.au>,
	open list <linux-kernel@vger.kernel.org>,
	"open list:DRM DRIVERS" <dri-devel@lists.freedesktop.org>,
	"open list:VIRTIO CORE,
	NET..."  <virtualization@lists.linux-foundation.org>,
	"open list:ABI/API" <linux-api@vger.kernel.org>
Subject: Re: [virtio-dev] Re: [PATCH] Add virtio gpu driver.
Date: Thu, 26 Mar 2015 17:47:09 +0100	[thread overview]
Message-ID: <20150326174401-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <1427382436.8786.15.camel@nilsson.home.kraxel.org>

On Thu, Mar 26, 2015 at 04:07:16PM +0100, Gerd Hoffmann wrote:
>   Hi,
> 
> > I don't know. This seems exactly like the kind of thing
> > we had in mind when we added the virtio pci capability.
> > For example, we have text in spec that requires drivers
> > to skip unknown capabilities.
> > 
> > And yes, if bios pokes at a specific bar then we do
> > need to list this info in the virtio spec so this makes
> > it an issue that is virtio related.
> 
> Hmm, virtio-vga is a two-in-one device basically.  When virtio is
> enabled it behaves like virtio-gpu-pci, otherwise it behaves very
> simliar to stdvga.  So you need to know nothing about virtio to handle
> the vga side, and I want keep it that way.
> 
> When no vga compatibility is needed there always is the option to just
> use virtio-gpu-pci instead.
> 
> > Yes, it's not about what we put there now. It's about being able
> > to move things about in the future without breaking guests.
> 
> We don't have that today for stdvga, and I still fail to see what this
> buys us.
> 
> 
> Completely different thing crossing my mind:  I think we can make
> virtio-vga fully compatible with stdvga.  stdvga has two bars, memory
> (#0) and mmio (#2).  We can make the mmio bar larger and place all the
> virtio regions there.
> 

Full compatibility with some standard sounds like a better motivation,
yes.

> 
> I think in any case I'll go split off the vga compatibility bits to a
> different patch (and possible a separate patch series).
> 
> cheers,
>   Gerd

Will you still need me to change core to claim specific memory only?


-- 
MST

  parent reply	other threads:[~2015-03-26 16:47 UTC|newest]

Thread overview: 98+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-24 16:07 [PATCH] Add virtio gpu driver Gerd Hoffmann
2015-03-24 16:07 ` Gerd Hoffmann
2015-03-24 16:15 ` Michael S. Tsirkin
2015-03-25 14:52   ` Gerd Hoffmann
2015-03-25 14:52   ` Gerd Hoffmann
2015-03-25 14:52     ` Gerd Hoffmann
     [not found]     ` <1427295121.23304.5.camel-3OfP5uLMi4C46o+2HkPkLj4oCIwMql/M@public.gmane.org>
2015-03-25 15:24       ` Michael S. Tsirkin
2015-03-25 15:24         ` Michael S. Tsirkin
2015-03-25 15:37         ` Gerd Hoffmann
2015-03-25 15:37         ` Gerd Hoffmann
2015-03-25 15:37           ` Gerd Hoffmann
2015-03-25 17:09           ` Michael S. Tsirkin
2015-03-26  7:12             ` Gerd Hoffmann
2015-03-26  7:12             ` Gerd Hoffmann
2015-03-26  7:12               ` Gerd Hoffmann
2015-03-26  8:18               ` Michael S. Tsirkin
     [not found]               ` <1427353959.9779.2.camel-3OfP5uLMi4C46o+2HkPkLj4oCIwMql/M@public.gmane.org>
2015-03-26  8:18                 ` Michael S. Tsirkin
2015-03-26  8:18                   ` Michael S. Tsirkin
2015-03-26  8:42                   ` [virtio-dev] " Gerd Hoffmann
2015-03-26  8:42                   ` Gerd Hoffmann
2015-03-26  8:42                     ` Gerd Hoffmann
2015-03-26  9:04                     ` Michael S. Tsirkin
2015-03-26  9:04                       ` Michael S. Tsirkin
2015-03-26 11:38                       ` Gerd Hoffmann
2015-03-26 11:38                         ` Gerd Hoffmann
     [not found]                         ` <1427369923.9779.18.camel-3OfP5uLMi4C46o+2HkPkLj4oCIwMql/M@public.gmane.org>
2015-03-26 11:53                           ` Michael S. Tsirkin
2015-03-26 11:53                             ` Michael S. Tsirkin
2015-03-26 15:07                             ` Gerd Hoffmann
2015-03-26 15:07                               ` Gerd Hoffmann
     [not found]                               ` <1427382436.8786.15.camel-3OfP5uLMi4C46o+2HkPkLj4oCIwMql/M@public.gmane.org>
2015-03-26 16:47                                 ` Michael S. Tsirkin [this message]
2015-03-26 16:47                                   ` Michael S. Tsirkin
2015-03-26 22:49                                   ` Alex Elsayed
2015-03-27  8:08                                   ` Gerd Hoffmann
2015-03-27  8:08                                   ` Gerd Hoffmann
2015-03-26 16:47                               ` Michael S. Tsirkin
2015-03-26 15:07                             ` Gerd Hoffmann
2015-03-26 11:53                         ` Michael S. Tsirkin
2015-03-26 16:52                         ` One Thousand Gnomes
2015-03-26 16:52                         ` One Thousand Gnomes
2015-03-26 11:38                       ` Gerd Hoffmann
2015-03-26  9:04                     ` Michael S. Tsirkin
2015-03-25 17:09           ` Michael S. Tsirkin
2015-03-25 15:24     ` Michael S. Tsirkin
2015-03-24 16:15 ` Michael S. Tsirkin
2015-03-24 16:50 ` Daniel Vetter
2015-03-24 17:04 ` Michael S. Tsirkin
2015-03-24 17:04 ` Michael S. Tsirkin
2015-03-24 17:04   ` Michael S. Tsirkin
2015-03-24 20:47 ` Paul Bolle
     [not found] ` <1427213239-8775-1-git-send-email-kraxel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-03-24 16:50   ` Daniel Vetter
2015-03-24 16:50     ` Daniel Vetter
2015-03-25 14:53     ` Gerd Hoffmann
2015-03-25 14:53       ` Gerd Hoffmann
2015-03-26  8:53       ` Daniel Vetter
     [not found]       ` <1427295189.23304.6.camel-3OfP5uLMi4C46o+2HkPkLj4oCIwMql/M@public.gmane.org>
2015-03-26  8:53         ` Daniel Vetter
2015-03-26  8:53           ` Daniel Vetter
2015-03-30 12:23     ` Gerd Hoffmann
2015-03-30 12:23     ` Gerd Hoffmann
2015-03-30 12:23       ` Gerd Hoffmann
2015-03-30 14:49       ` Daniel Vetter
2015-03-30 14:49       ` Daniel Vetter
2016-05-25 16:40         ` Daniel Vetter
2016-05-25 16:40         ` Daniel Vetter
2016-05-25 16:44           ` Emil Velikov
2016-05-27  7:48           ` Gerd Hoffmann
     [not found]           ` <CAKMK7uFUNT193f5djZD6T8cgRxxnZL73yrqbupPHOd2P-+Y=pQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-05-25 16:44             ` Emil Velikov
2016-05-25 16:44               ` Emil Velikov
2016-05-27  7:48             ` Gerd Hoffmann
2016-05-27  7:48               ` Gerd Hoffmann
2016-05-27  9:03               ` Daniel Vetter
2016-05-27  9:03               ` Daniel Vetter
2016-05-27  9:03                 ` Daniel Vetter
2016-05-30 13:50                 ` Gerd Hoffmann
2016-05-30 14:47                   ` Daniel Vetter
2016-05-30 14:47                     ` Daniel Vetter
2016-05-31  6:29                     ` Gerd Hoffmann
2016-05-31  6:55                       ` Daniel Vetter
     [not found]                       ` <1464676160.5978.24.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-05-31  6:55                         ` Daniel Vetter
2016-05-31  6:55                           ` Daniel Vetter
2016-05-31  7:00                         ` Pekka Paalanen
2016-05-31  7:00                           ` Pekka Paalanen
2016-05-31  7:00                       ` Pekka Paalanen
2016-05-31  6:29                     ` Gerd Hoffmann
2016-05-30 14:47                   ` Daniel Vetter
2016-05-30 13:50                 ` Gerd Hoffmann
2015-03-24 20:47   ` Paul Bolle
2015-03-24 20:47     ` Paul Bolle
2015-03-24 22:50   ` Daniel Stone
2015-03-24 22:50     ` Daniel Stone
     [not found]     ` <CAPj87rN4pXHukDRD-e=ZrO1hcts04cSz1Hr9TNAgicGVWE5_-Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-03-25  0:00       ` Dave Airlie
2015-03-25  0:00         ` Dave Airlie
2015-03-25  5:47         ` Daniel Stone
2015-03-25  5:47         ` Daniel Stone
2015-03-25  0:00     ` Dave Airlie
2015-03-25 15:19     ` Gerd Hoffmann
2015-03-25 15:19     ` Gerd Hoffmann
2015-03-25 15:19       ` Gerd Hoffmann
2015-03-24 22:50 ` Daniel Stone

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150326174401-mutt-send-email-mst@redhat.com \
    --to=mst-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=airlied-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=airlied-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=airlied-cv59FeDIM0c@public.gmane.org \
    --cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=kraxel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=rusty-8n+1lVoiYb80n/F98K4Iww@public.gmane.org \
    --cc=virtio-dev-sDuHXQ4OtrM4h7I2RyI4rWD2FQJk+8+b@public.gmane.org \
    --cc=virtualization-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.