From: Alberto Garcia <berto@igalia.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 0/7] Block Throttle Group Support
Date: Thu, 26 Mar 2015 19:52:50 +0100 [thread overview]
Message-ID: <20150326185250.GA23415@igalia.com> (raw)
In-Reply-To: <cover.1427389742.git.berto@igalia.com>
On Thu, Mar 26, 2015 at 07:24:54PM +0200, Alberto Garcia wrote:
> - The creation/destruction of ThrottleTimers is now handled internally
> when a BlockDriverState is added/removed from a group, since
> there's not much point on keeping them separate. This also hides
> the timer callbacks from the outside, which makes things a bit
> nicer and easier for some of the other changes included in these
> series.
Hmm... this actually breaks the new test because now BDS are required
to have an AioContext attached when they're added to a group, which
doesn't happen in qtest:
bdrv = bdrv_new();
throttle_group_register_bs(bdrv, "bar");
I'm unsure of how to proceed with this, I don't see a clear way to
attach the AioContext here (unless I do bdrv->aio_context = ctx).
Suggestions are welcome.
Berto
next prev parent reply other threads:[~2015-03-26 18:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-26 17:24 [Qemu-devel] [PATCH v4 0/7] Block Throttle Group Support Alberto Garcia
2015-03-26 17:24 ` [Qemu-devel] [PATCH 1/7] throttle: Extract timers from ThrottleState into a separate structure Alberto Garcia
2015-03-26 17:24 ` [Qemu-devel] [PATCH 2/7] throttle: Add throttle group infrastructure Alberto Garcia
2015-03-26 17:24 ` [Qemu-devel] [PATCH 3/7] throttle: Add throttle group infrastructure tests Alberto Garcia
2015-03-26 17:24 ` [Qemu-devel] [PATCH 4/7] throttle: Add throttle group support Alberto Garcia
2015-03-26 17:24 ` [Qemu-devel] [PATCH 5/7] throttle: acquire the ThrottleGroup lock in bdrv_swap() Alberto Garcia
2015-03-26 17:25 ` [Qemu-devel] [PATCH 6/7] throttle: add the name of the ThrottleGroup to BlockDeviceInfo Alberto Garcia
2015-03-26 17:25 ` [Qemu-devel] [PATCH 7/7] throttle: Update throttle infrastructure copyright Alberto Garcia
2015-03-26 18:52 ` Alberto Garcia [this message]
2015-03-27 1:11 ` [Qemu-devel] [PATCH v4 0/7] Block Throttle Group Support Fam Zheng
2015-03-27 7:23 ` Alberto Garcia
2015-03-27 8:35 ` Fam Zheng
2015-03-30 15:24 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150326185250.GA23415@igalia.com \
--to=berto@igalia.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.