From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Michael Wang <yun.wang@profitbricks.com>
Cc: Doug Ledford <dledford@redhat.com>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-nfs@vger.kernel.org, netdev@vger.kernel.org,
Roland Dreier <roland@kernel.org>,
Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
Ira Weiny <ira.weiny@intel.com>,
Trond Myklebust <trond.myklebust@primarydata.com>,
"J. Bruce Fields" <bfields@fieldses.org>,
"David S. Miller" <davem@davemloft.net>,
Moni Shoua <monis@mellanox.com>,
Or Gerlitz <ogerlitz@mellanox.com>,
Tatyana Nikolova <Tatyana.E.Nikolova@intel.com>,
Steve Wise <swise@opengridcomputing.com>,
Yan Burman <yanb@mellanox.com>,
Jack Morgenstein <jackm@dev.mellanox.co.il>,
Bart Van Assche <bvanassche@acm.org>,
Yann Droneaud <ydroneaud@opteya.com>,
Colin Ian King <colin.king@canonical.com>,
Jiri Kosina <jkosina@suse.cz>, Matan Barak <matanb@mellanox.com>,
Majd Dibbiny <majd@mellanox.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
Mel Gorman <mgorman@suse.de>, Alex Estrin <alex.estrin@intel.com>,
Eric Dumazet <edumazet@google.com>,
Erez Shitrit <erezsh@mellanox.com>,
Sagi Grimberg <sagig@mellanox.com>,
Haggai Eran <haggaie@mellanox.com>,
Shachar Raindel <raindel@mellanox.com>,
Mike Marciniszyn <mike.marciniszyn@intel.com>,
Tom Tucker <tom@ogc.us>, Chuck Lever <chuck.lever@oracle.com>
Subject: Re: [PATCH 0/2 RESEND] IB/Verbs: Use helpers to refine the checking on transport and link layer
Date: Thu, 26 Mar 2015 15:13:34 -0600 [thread overview]
Message-ID: <20150326211334.GA3359@obsidianresearch.com> (raw)
In-Reply-To: <55143AAC.8040206@profitbricks.com>
On Thu, Mar 26, 2015 at 05:58:20PM +0100, Michael Wang wrote:
> The questions is just wondering how the transition method could be, but
> if we have to do the changes for vendor, that sounds like a tough job...
I would see changing how the information is represented in the struct
as a follow on issue. The first patch should go through and replace
all direct access to the link layer/transport/etc with an
appropriately narrow is_XX() test like Doug was suggesting.
That means looking at each code site and determining what it needs,
making a is_XX for it and a kdoc describing exactly what is needed for
the test to return true.
The follow on patch can then rework the is_XX and drop the link
layer/transport stuff..
Some ideas for is_XX:
IB compatible SA
QP0 SMP mechanism
IB SMP format
OPA SMP format
QP1 GMP mechanism
IB compatible CM
GID addressing
IP/IPv6 addressing
Ethernet VLAN
...
Jason
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Michael Wang <yun.wang-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
Cc: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Roland Dreier <roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Hal Rosenstock
<hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Trond Myklebust
<trond.myklebust-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org>,
"J. Bruce Fields"
<bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>,
"David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
Moni Shoua <monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Tatyana Nikolova
<Tatyana.E.Nikolova-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Steve Wise
<swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>,
Yan Burman <yanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Jack Morgenstein
<jackm-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>,
Bart Van Assche <bvanassche-HInyCGIudOg@public.gmane.org>,
Yann Droneaud <ydroneaud-RlY5vtjFyJ3QT0dZR+AlfA@public.gmane.org>,
Colin Ian King
<colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>,
Jiri Kosina <jkosina-AlSwsSmVLrQ@public.gmane.org>,
Matan Barak <matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Majd Dibbiny <majd@mellanox.c>
Subject: Re: [PATCH 0/2 RESEND] IB/Verbs: Use helpers to refine the checking on transport and link layer
Date: Thu, 26 Mar 2015 15:13:34 -0600 [thread overview]
Message-ID: <20150326211334.GA3359@obsidianresearch.com> (raw)
In-Reply-To: <55143AAC.8040206-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
On Thu, Mar 26, 2015 at 05:58:20PM +0100, Michael Wang wrote:
> The questions is just wondering how the transition method could be, but
> if we have to do the changes for vendor, that sounds like a tough job...
I would see changing how the information is represented in the struct
as a follow on issue. The first patch should go through and replace
all direct access to the link layer/transport/etc with an
appropriately narrow is_XX() test like Doug was suggesting.
That means looking at each code site and determining what it needs,
making a is_XX for it and a kdoc describing exactly what is needed for
the test to return true.
The follow on patch can then rework the is_XX and drop the link
layer/transport stuff..
Some ideas for is_XX:
IB compatible SA
QP0 SMP mechanism
IB SMP format
OPA SMP format
QP1 GMP mechanism
IB compatible CM
GID addressing
IP/IPv6 addressing
Ethernet VLAN
...
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Michael Wang <yun.wang-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
Cc: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Roland Dreier <roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Hal Rosenstock
<hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Trond Myklebust
<trond.myklebust-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org>,
"J. Bruce Fields"
<bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>,
"David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
Moni Shoua <monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Tatyana Nikolova
<Tatyana.E.Nikolova-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Steve Wise
<swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>,
Yan Burman <yanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Jack Morgenstein
<jackm-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>,
Bart Van Assche <bvanassche-HInyCGIudOg@public.gmane.org>,
Yann Droneaud <ydroneaud-RlY5vtjFyJ3QT0dZR+AlfA@public.gmane.org>,
Colin Ian King
<colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>,
Jiri Kosina <jkosina-AlSwsSmVLrQ@public.gmane.org>,
Matan Barak <matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Majd Dibbiny <majd@mellanox.c
Subject: Re: [PATCH 0/2 RESEND] IB/Verbs: Use helpers to refine the checking on transport and link layer
Date: Thu, 26 Mar 2015 15:13:34 -0600 [thread overview]
Message-ID: <20150326211334.GA3359@obsidianresearch.com> (raw)
In-Reply-To: <55143AAC.8040206-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
On Thu, Mar 26, 2015 at 05:58:20PM +0100, Michael Wang wrote:
> The questions is just wondering how the transition method could be, but
> if we have to do the changes for vendor, that sounds like a tough job...
I would see changing how the information is represented in the struct
as a follow on issue. The first patch should go through and replace
all direct access to the link layer/transport/etc with an
appropriately narrow is_XX() test like Doug was suggesting.
That means looking at each code site and determining what it needs,
making a is_XX for it and a kdoc describing exactly what is needed for
the test to return true.
The follow on patch can then rework the is_XX and drop the link
layer/transport stuff..
Some ideas for is_XX:
IB compatible SA
QP0 SMP mechanism
IB SMP format
OPA SMP format
QP1 GMP mechanism
IB compatible CM
GID addressing
IP/IPv6 addressing
Ethernet VLAN
...
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-03-26 21:13 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-25 15:09 [PATCH 0/2 RESEND] IB/Verbs: Use helpers to refine the checking on transport and link layer Michael Wang
2015-03-25 15:09 ` Michael Wang
2015-03-25 15:09 ` Michael Wang
2015-03-25 15:12 ` [PATCH 1/2 RESEND] IB/Verbs: Use helpers to check " Michael Wang
2015-03-25 15:12 ` Michael Wang
2015-03-25 15:12 ` Michael Wang
2015-03-25 15:14 ` [PATCH 2/2 RESEND] IB/Verbs: Use helpers to check IBoE technology Michael Wang
2015-03-25 15:14 ` Michael Wang
2015-03-25 15:14 ` Michael Wang
2015-03-26 14:09 ` [PATCH 0/2 RESEND] IB/Verbs: Use helpers to refine the checking on transport and link layer Doug Ledford
2015-03-26 14:09 ` Doug Ledford
2015-03-26 14:09 ` Doug Ledford
2015-03-26 16:04 ` Michael Wang
2015-03-26 16:04 ` Michael Wang
2015-03-26 16:04 ` Michael Wang
2015-03-26 16:27 ` Doug Ledford
2015-03-26 16:27 ` Doug Ledford
2015-03-26 16:27 ` Doug Ledford
2015-03-26 16:58 ` Michael Wang
2015-03-26 16:58 ` Michael Wang
2015-03-26 16:58 ` Michael Wang
2015-03-26 21:13 ` Jason Gunthorpe [this message]
2015-03-26 21:13 ` Jason Gunthorpe
2015-03-26 21:13 ` Jason Gunthorpe
2015-03-27 9:52 ` Michael Wang
2015-03-27 9:52 ` Michael Wang
2015-03-27 9:52 ` Michael Wang
2015-03-27 15:55 ` Jason Gunthorpe
2015-03-27 15:55 ` Jason Gunthorpe
2015-03-27 15:55 ` Jason Gunthorpe
2015-03-27 16:03 ` Michael Wang
2015-03-27 16:03 ` Michael Wang
2015-03-27 16:03 ` Michael Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150326211334.GA3359@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=Tatyana.E.Nikolova@intel.com \
--cc=alex.estrin@intel.com \
--cc=bfields@fieldses.org \
--cc=bvanassche@acm.org \
--cc=chuck.lever@oracle.com \
--cc=colin.king@canonical.com \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=dledford@redhat.com \
--cc=edumazet@google.com \
--cc=erezsh@mellanox.com \
--cc=haggaie@mellanox.com \
--cc=hal.rosenstock@gmail.com \
--cc=ira.weiny@intel.com \
--cc=jackm@dev.mellanox.co.il \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=majd@mellanox.com \
--cc=matanb@mellanox.com \
--cc=mgorman@suse.de \
--cc=mike.marciniszyn@intel.com \
--cc=monis@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=raindel@mellanox.com \
--cc=roland@kernel.org \
--cc=sagig@mellanox.com \
--cc=sean.hefty@intel.com \
--cc=swise@opengridcomputing.com \
--cc=tom@ogc.us \
--cc=trond.myklebust@primarydata.com \
--cc=yanb@mellanox.com \
--cc=ydroneaud@opteya.com \
--cc=yun.wang@profitbricks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.