All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Dave Martin <Dave.Martin@arm.com>
Cc: Russell King <linux@arm.linux.org.uk>,
	Andre Przywara <Andre.Przywara@arm.com>,
	Andrew Jackson <Andrew.Jackson@arm.com>,
	Graeme Gregory <gg@slimlogic.co.uk>,
	linux-serial@vger.kernel.org, popcorn mix <popcornmix@gmail.com>,
	Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/2] serial/amba-pl011: Leave the TX IRQ alone when the UART is not open
Date: Thu, 26 Mar 2015 22:26:41 +0100	[thread overview]
Message-ID: <20150326212641.GA21554@kroah.com> (raw)
In-Reply-To: <1426262182-2298-3-git-send-email-Dave.Martin@arm.com>

On Fri, Mar 13, 2015 at 03:56:22PM +0000, Dave Martin wrote:
> Getting the TX IRQ re-asserted from scratch can be inefficient in
> some setups.
> 
> This patch avoids clearing the TX IRQ across pl011_shutdown()...
> pl011_startup(), so that if the port is closed and reopened, the
> IRQ will still work afterwards without having to bootstrap it again.
> 
> The TX IRQ continues to be masked in IMSC when the UART is not in
> use.
> 
> Signed-off-by: Dave Martin <Dave.Martin@arm.com>
> ---
>  drivers/tty/serial/amba-pl011.c |    5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)

This doesn't apply to my tty-testing branch of tty.git on git.kernel.org
:(

Can you please rebase it and resend?

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: gregkh@linuxfoundation.org (Greg Kroah-Hartman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/2] serial/amba-pl011: Leave the TX IRQ alone when the UART is not open
Date: Thu, 26 Mar 2015 22:26:41 +0100	[thread overview]
Message-ID: <20150326212641.GA21554@kroah.com> (raw)
In-Reply-To: <1426262182-2298-3-git-send-email-Dave.Martin@arm.com>

On Fri, Mar 13, 2015 at 03:56:22PM +0000, Dave Martin wrote:
> Getting the TX IRQ re-asserted from scratch can be inefficient in
> some setups.
> 
> This patch avoids clearing the TX IRQ across pl011_shutdown()...
> pl011_startup(), so that if the port is closed and reopened, the
> IRQ will still work afterwards without having to bootstrap it again.
> 
> The TX IRQ continues to be masked in IMSC when the UART is not in
> use.
> 
> Signed-off-by: Dave Martin <Dave.Martin@arm.com>
> ---
>  drivers/tty/serial/amba-pl011.c |    5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)

This doesn't apply to my tty-testing branch of tty.git on git.kernel.org
:(

Can you please rebase it and resend?

thanks,

greg k-h

  reply	other threads:[~2015-03-26 21:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-13 15:56 [PATCH v2 0/2] serial/amba-pl011: Activate TX IRQ passively Dave Martin
2015-03-13 15:56 ` Dave Martin
2015-03-13 15:56 ` [PATCH v2 1/2] " Dave Martin
2015-03-13 15:56   ` Dave Martin
2015-03-26 21:27   ` Greg Kroah-Hartman
2015-03-26 21:27     ` Greg Kroah-Hartman
2015-03-13 15:56 ` [PATCH v2 2/2] serial/amba-pl011: Leave the TX IRQ alone when the UART is not open Dave Martin
2015-03-13 15:56   ` Dave Martin
2015-03-26 21:26   ` Greg Kroah-Hartman [this message]
2015-03-26 21:26     ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150326212641.GA21554@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Andre.Przywara@arm.com \
    --cc=Andrew.Jackson@arm.com \
    --cc=Dave.Martin@arm.com \
    --cc=gg@slimlogic.co.uk \
    --cc=jorge.ramirez-ortiz@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=popcornmix@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.