From: Greg KH <gregkh@linuxfoundation.org>
To: Jiada Wang <jiada_wang@mentor.com>
Cc: jslaby@suse.cz, linux-arm-kernel@lists.infradead.org,
linux-serial@vger.kernel.org
Subject: Re: [PATCH] serial: imx: protect Soft Reset of port with lock
Date: Thu, 26 Mar 2015 23:01:13 +0100 [thread overview]
Message-ID: <20150326220113.GA24630@kroah.com> (raw)
In-Reply-To: <1426228691-20529-1-git-send-email-jiada_wang@mentor.com>
On Fri, Mar 13, 2015 at 03:38:11PM +0900, Jiada Wang wrote:
> Previously Soft Reset (clear of SRST bit in UCR2 register)
> of UART in startup is not protected by lock, which may have race
> with console_write, as console_write may occur at anytime even
> when UART port is shutdown.
>
> To avoid this race, protect Soft reset of UART port with spin_lock.
>
> Signed-off-by: Jiada Wang <jiada_wang@mentor.com>
> ---
> drivers/tty/serial/imx.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
Doesn't apply to my tree :(
WARNING: multiple messages have this Message-ID (diff)
From: gregkh@linuxfoundation.org (Greg KH)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] serial: imx: protect Soft Reset of port with lock
Date: Thu, 26 Mar 2015 23:01:13 +0100 [thread overview]
Message-ID: <20150326220113.GA24630@kroah.com> (raw)
In-Reply-To: <1426228691-20529-1-git-send-email-jiada_wang@mentor.com>
On Fri, Mar 13, 2015 at 03:38:11PM +0900, Jiada Wang wrote:
> Previously Soft Reset (clear of SRST bit in UCR2 register)
> of UART in startup is not protected by lock, which may have race
> with console_write, as console_write may occur at anytime even
> when UART port is shutdown.
>
> To avoid this race, protect Soft reset of UART port with spin_lock.
>
> Signed-off-by: Jiada Wang <jiada_wang@mentor.com>
> ---
> drivers/tty/serial/imx.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
Doesn't apply to my tree :(
next prev parent reply other threads:[~2015-03-26 22:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-13 6:38 [PATCH] serial: imx: protect Soft Reset of port with lock Jiada Wang
2015-03-13 6:38 ` Jiada Wang
2015-03-26 22:01 ` Greg KH [this message]
2015-03-26 22:01 ` Greg KH
2015-04-13 6:52 ` jiwang
2015-04-13 6:52 ` jiwang
2015-04-13 7:20 ` Greg KH
2015-04-13 7:20 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150326220113.GA24630@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jiada_wang@mentor.com \
--cc=jslaby@suse.cz \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.