From: Will Deacon <will.deacon@arm.com>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: Andre Przywara <Andre.Przywara@arm.com>,
Dave P Martin <Dave.Martin@arm.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Catalin Marinas <Catalin.Marinas@arm.com>,
"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>
Subject: Re: [PATCH 2/5] arm64: alternative: Allow immediate branch as alternative instruction
Date: Thu, 26 Mar 2015 22:31:51 +0000 [thread overview]
Message-ID: <20150326223150.GD23836@arm.com> (raw)
In-Reply-To: <20150326221955.4b8fe6f0@arm.com>
On Thu, Mar 26, 2015 at 10:19:55PM +0000, Marc Zyngier wrote:
> On Thu, 26 Mar 2015 22:03:23 +0000
> Will Deacon <will.deacon@arm.com> wrote:
> > On Thu, Mar 19, 2015 at 01:59:33PM +0000, Marc Zyngier wrote:
> > > + for (i = 0; i < alt->alt_len; i += sizeof(insn)) {
> > > + insn = get_alt_insn(origptr + i, replptr + i);
> > > + *(u32 *)(origptr + i) = insn;
> >
> > My brain's not firing on all cylinders right now, but do you need a
> > cpu_to_le32 here?
>
> I'm not 100% awake myself (probably some acute form of firmwaritis),
> but I suspect you're quite right (get_alt_insn calls aarch64_insn_read,
> which does a le32_to_cpu). Obviously, we need to revert the conversion
> when writing the instruction back.
>
> Do you want a fixup on top of this, or would you prefer me to respin
> the series?
Please respin and add my acks.
Will
WARNING: multiple messages have this Message-ID (diff)
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/5] arm64: alternative: Allow immediate branch as alternative instruction
Date: Thu, 26 Mar 2015 22:31:51 +0000 [thread overview]
Message-ID: <20150326223150.GD23836@arm.com> (raw)
In-Reply-To: <20150326221955.4b8fe6f0@arm.com>
On Thu, Mar 26, 2015 at 10:19:55PM +0000, Marc Zyngier wrote:
> On Thu, 26 Mar 2015 22:03:23 +0000
> Will Deacon <will.deacon@arm.com> wrote:
> > On Thu, Mar 19, 2015 at 01:59:33PM +0000, Marc Zyngier wrote:
> > > + for (i = 0; i < alt->alt_len; i += sizeof(insn)) {
> > > + insn = get_alt_insn(origptr + i, replptr + i);
> > > + *(u32 *)(origptr + i) = insn;
> >
> > My brain's not firing on all cylinders right now, but do you need a
> > cpu_to_le32 here?
>
> I'm not 100% awake myself (probably some acute form of firmwaritis),
> but I suspect you're quite right (get_alt_insn calls aarch64_insn_read,
> which does a le32_to_cpu). Obviously, we need to revert the conversion
> when writing the instruction back.
>
> Do you want a fixup on top of this, or would you prefer me to respin
> the series?
Please respin and add my acks.
Will
next prev parent reply other threads:[~2015-03-26 22:24 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 13:59 [PATCH 0/5] arm64: Patching branches for fun and profit Marc Zyngier
2015-03-19 13:59 ` Marc Zyngier
2015-03-19 13:59 ` [PATCH 1/5] arm64: insn: Add aarch64_insn_decode_immediate Marc Zyngier
2015-03-19 13:59 ` Marc Zyngier
2015-03-19 13:59 ` [PATCH 2/5] arm64: alternative: Allow immediate branch as alternative instruction Marc Zyngier
2015-03-19 13:59 ` Marc Zyngier
2015-03-26 22:03 ` Will Deacon
2015-03-26 22:03 ` Will Deacon
2015-03-26 22:19 ` Marc Zyngier
2015-03-26 22:19 ` Marc Zyngier
2015-03-26 22:31 ` Will Deacon [this message]
2015-03-26 22:31 ` Will Deacon
2015-03-27 10:42 ` Jon Medhurst (Tixy)
2015-03-27 10:42 ` Jon Medhurst (Tixy)
2015-03-27 11:08 ` Marc Zyngier
2015-03-27 11:08 ` Marc Zyngier
2015-03-19 13:59 ` [PATCH 3/5] arm64: Extract feature parsing code from cpu_errata.c Marc Zyngier
2015-03-19 13:59 ` Marc Zyngier
2015-03-19 13:59 ` [PATCH 4/5] arm64: alternative: Introduce feature for GICv3 CPU interface Marc Zyngier
2015-03-19 13:59 ` Marc Zyngier
2015-03-19 13:59 ` [PATCH 5/5] arm64: KVM: Switch vgic save/restore to alternative_insn Marc Zyngier
2015-03-19 13:59 ` Marc Zyngier
2015-03-26 22:04 ` [PATCH 0/5] arm64: Patching branches for fun and profit Will Deacon
2015-03-26 22:04 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150326223150.GD23836@arm.com \
--to=will.deacon@arm.com \
--cc=Andre.Przywara@arm.com \
--cc=Catalin.Marinas@arm.com \
--cc=Dave.Martin@arm.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=marc.zyngier@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.