From: boris.brezillon@free-electrons.com (Boris Brezillon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] net/macb: fix capabilities configuration
Date: Sat, 28 Mar 2015 00:02:35 +0100 [thread overview]
Message-ID: <20150328000235.30337361@bbrezillon> (raw)
In-Reply-To: <bd7194896b4e4517a7675ae02fe7bed01f19a02d.1427469791.git.nicolas.ferre@atmel.com>
Hi Nicolas,
On Fri, 27 Mar 2015 16:34:11 +0100
Nicolas Ferre <nicolas.ferre@atmel.com> wrote:
> Capabilities configuration by macb_configure_caps() was moved far too late by
> 421d9df0628b (net/macb: merge at91_ether driver into macb driver) which would
> lead to badly configured hardware.
Indeed, the macb_configure_caps function is called a bit too late,
but ...
> So, move this function to early probe and modify its prototype to re-gain its
> original behavior.
> DT data retrieval is also moved to simplify the probe code flow.
... I'm not happy with these changes.
I tried to keep specific init steps of macb and at91_ether separated
and you're moving macb_configure_caps call (not required on at91_ether
HW) into macb_probe (the common probe part).
How about moving macb_configure_caps a bit earlier in the macb_init
function [1] ?
Best Regards,
Boris
[1]http://code.bulix.org/8gyi6b-88141
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: <davem@davemloft.net>, <netdev@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
Cyrille Pitchen <cyrille.pitchen@atmel.com>, <monstr@monstr.eu>,
<michal.simek@xilinx.com>, <punnaia@xilinx.com>
Subject: Re: [PATCH 3/4] net/macb: fix capabilities configuration
Date: Sat, 28 Mar 2015 00:02:35 +0100 [thread overview]
Message-ID: <20150328000235.30337361@bbrezillon> (raw)
In-Reply-To: <bd7194896b4e4517a7675ae02fe7bed01f19a02d.1427469791.git.nicolas.ferre@atmel.com>
Hi Nicolas,
On Fri, 27 Mar 2015 16:34:11 +0100
Nicolas Ferre <nicolas.ferre@atmel.com> wrote:
> Capabilities configuration by macb_configure_caps() was moved far too late by
> 421d9df0628b (net/macb: merge at91_ether driver into macb driver) which would
> lead to badly configured hardware.
Indeed, the macb_configure_caps function is called a bit too late,
but ...
> So, move this function to early probe and modify its prototype to re-gain its
> original behavior.
> DT data retrieval is also moved to simplify the probe code flow.
... I'm not happy with these changes.
I tried to keep specific init steps of macb and at91_ether separated
and you're moving macb_configure_caps call (not required on at91_ether
HW) into macb_probe (the common probe part).
How about moving macb_configure_caps a bit earlier in the macb_init
function [1] ?
Best Regards,
Boris
[1]http://code.bulix.org/8gyi6b-88141
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-03-27 23:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-27 15:34 [PATCH 0/4] net/macb: fixes after big driver update Nicolas Ferre
2015-03-27 15:34 ` Nicolas Ferre
2015-03-27 15:34 ` [PATCH 1/4] net/macb: only probe queues once and use stored values Nicolas Ferre
2015-03-27 15:34 ` Nicolas Ferre
2015-03-27 16:24 ` Cyrille Pitchen
2015-03-27 16:24 ` Cyrille Pitchen
2015-03-30 6:30 ` Nicolas Ferre
2015-03-30 6:30 ` Nicolas Ferre
2015-03-27 22:36 ` Boris Brezillon
2015-03-27 22:36 ` Boris Brezillon
2015-03-27 15:34 ` [PATCH 2/4] net/macb: add comment in macb_probe_queues Nicolas Ferre
2015-03-27 15:34 ` Nicolas Ferre
2015-03-27 15:34 ` [PATCH 3/4] net/macb: fix capabilities configuration Nicolas Ferre
2015-03-27 15:34 ` Nicolas Ferre
2015-03-27 23:02 ` Boris Brezillon [this message]
2015-03-27 23:02 ` Boris Brezillon
2015-03-30 6:33 ` Nicolas Ferre
2015-03-30 6:33 ` Nicolas Ferre
2015-03-27 15:34 ` [PATCH 4/4] net/macb: trivial: correct wording of for caps Nicolas Ferre
2015-03-27 15:34 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150328000235.30337361@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.