* [PATCH] Staging: rtl8712: Remove duplicated argument to | @ 2015-03-28 1:30 Cristina Opriceana 2015-03-28 6:07 ` [Outreachy kernel] " Julia Lawall 0 siblings, 1 reply; 4+ messages in thread From: Cristina Opriceana @ 2015-03-28 1:30 UTC (permalink / raw) To: outreachy-kernel; +Cc: outreachy-kernel Delete duplicated argument to | for the state argument in the _clr_fwstate_() function call as it is redundant. Detected with coccinelle. Signed-off-by: Cristina Opriceana <cristina.opriceana@gmail.com> --- drivers/staging/rtl8712/rtl871x_ioctl_set.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_set.c b/drivers/staging/rtl8712/rtl871x_ioctl_set.c index bd1d1b7..22262b3 100644 --- a/drivers/staging/rtl8712/rtl871x_ioctl_set.c +++ b/drivers/staging/rtl8712/rtl871x_ioctl_set.c @@ -266,8 +266,7 @@ void r8712_set_802_11_infrastructure_mode(struct _adapter *padapter, /* clear WIFI_STATION_STATE; WIFI_AP_STATE; WIFI_ADHOC_STATE; * WIFI_ADHOC_MASTER_STATE */ _clr_fwstate_(pmlmepriv, WIFI_STATION_STATE | WIFI_AP_STATE | - WIFI_ADHOC_STATE | WIFI_ADHOC_MASTER_STATE | - WIFI_AP_STATE); + WIFI_ADHOC_STATE | WIFI_ADHOC_MASTER_STATE); switch (networktype) { case Ndis802_11IBSS: set_fwstate(pmlmepriv, WIFI_ADHOC_STATE); -- 1.9.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: rtl8712: Remove duplicated argument to | 2015-03-28 1:30 [PATCH] Staging: rtl8712: Remove duplicated argument to | Cristina Opriceana @ 2015-03-28 6:07 ` Julia Lawall 2015-03-29 12:31 ` Cristina Georgiana Opriceana 0 siblings, 1 reply; 4+ messages in thread From: Julia Lawall @ 2015-03-28 6:07 UTC (permalink / raw) To: Cristina Opriceana; +Cc: outreachy-kernel On Sat, 28 Mar 2015, Cristina Opriceana wrote: > Delete duplicated argument to | for the state argument in > the _clr_fwstate_() function call as it is redundant. > Detected with coccinelle. > > Signed-off-by: Cristina Opriceana <cristina.opriceana@gmail.com> > --- > drivers/staging/rtl8712/rtl871x_ioctl_set.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_set.c b/drivers/staging/rtl8712/rtl871x_ioctl_set.c > index bd1d1b7..22262b3 100644 > --- a/drivers/staging/rtl8712/rtl871x_ioctl_set.c > +++ b/drivers/staging/rtl8712/rtl871x_ioctl_set.c > @@ -266,8 +266,7 @@ void r8712_set_802_11_infrastructure_mode(struct _adapter *padapter, > /* clear WIFI_STATION_STATE; WIFI_AP_STATE; WIFI_ADHOC_STATE; > * WIFI_ADHOC_MASTER_STATE */ > _clr_fwstate_(pmlmepriv, WIFI_STATION_STATE | WIFI_AP_STATE | > - WIFI_ADHOC_STATE | WIFI_ADHOC_MASTER_STATE | > - WIFI_AP_STATE); > + WIFI_ADHOC_STATE | WIFI_ADHOC_MASTER_STATE); For these, you should normally check the nearby code to see if they actually meant something else, but thanks to the comment that seems unlikely in this case. How did you find it? julia > switch (networktype) { > case Ndis802_11IBSS: > set_fwstate(pmlmepriv, WIFI_ADHOC_STATE); > -- > 1.9.1 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20150328013012.GA7624%40Inspiron. > For more options, visit https://groups.google.com/d/optout. > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: rtl8712: Remove duplicated argument to | 2015-03-28 6:07 ` [Outreachy kernel] " Julia Lawall @ 2015-03-29 12:31 ` Cristina Georgiana Opriceana 2015-03-29 12:39 ` Julia Lawall 0 siblings, 1 reply; 4+ messages in thread From: Cristina Georgiana Opriceana @ 2015-03-29 12:31 UTC (permalink / raw) To: outreachy-kernel; +Cc: cristina.opriceana [-- Attachment #1.1: Type: text/plain, Size: 2328 bytes --] On Saturday, March 28, 2015 at 8:07:40 AM UTC+2, Julia Lawall wrote: > > On Sat, 28 Mar 2015, Cristina Opriceana wrote: > > > Delete duplicated argument to | for the state argument in > > the _clr_fwstate_() function call as it is redundant. > > Detected with coccinelle. > > > > Signed-off-by: Cristina Opriceana <cristina....@gmail.com <javascript:>> > > > --- > > drivers/staging/rtl8712/rtl871x_ioctl_set.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_set.c > b/drivers/staging/rtl8712/rtl871x_ioctl_set.c > > index bd1d1b7..22262b3 100644 > > --- a/drivers/staging/rtl8712/rtl871x_ioctl_set.c > > +++ b/drivers/staging/rtl8712/rtl871x_ioctl_set.c > > @@ -266,8 +266,7 @@ void r8712_set_802_11_infrastructure_mode(struct > _adapter *padapter, > > /* clear WIFI_STATION_STATE; WIFI_AP_STATE; > WIFI_ADHOC_STATE; > > * WIFI_ADHOC_MASTER_STATE */ > > _clr_fwstate_(pmlmepriv, WIFI_STATION_STATE | > WIFI_AP_STATE | > > - WIFI_ADHOC_STATE | > WIFI_ADHOC_MASTER_STATE | > > - WIFI_AP_STATE); > > + WIFI_ADHOC_STATE | > WIFI_ADHOC_MASTER_STATE); > > For these, you should normally check the nearby code to see if they > actually meant something else, but thanks to the comment that seems > unlikely in this case. How did you find it? > > julia > Well, it was detected with coccinelle, then I followed the code and saw it was duplicated. > > > switch (networktype) { > > case Ndis802_11IBSS: > > set_fwstate(pmlmepriv, WIFI_ADHOC_STATE); > > -- > > 1.9.1 > > > > -- > > You received this message because you are subscribed to the Google > Groups "outreachy-kernel" group. > > To unsubscribe from this group and stop receiving emails from it, send > an email to outreachy-kern...@googlegroups.com <javascript:>. > > To post to this group, send email to outreach...@googlegroups.com > <javascript:>. > > To view this discussion on the web visit > https://groups.google.com/d/msgid/outreachy-kernel/20150328013012.GA7624%40Inspiron. > > > For more options, visit https://groups.google.com/d/optout. > > > [-- Attachment #1.2: Type: text/html, Size: 4272 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: rtl8712: Remove duplicated argument to | 2015-03-29 12:31 ` Cristina Georgiana Opriceana @ 2015-03-29 12:39 ` Julia Lawall 0 siblings, 0 replies; 4+ messages in thread From: Julia Lawall @ 2015-03-29 12:39 UTC (permalink / raw) To: Cristina Georgiana Opriceana; +Cc: outreachy-kernel [-- Attachment #1: Type: TEXT/PLAIN, Size: 3420 bytes --] On Sun, 29 Mar 2015, Cristina Georgiana Opriceana wrote: > > On Saturday, March 28, 2015 at 8:07:40 AM UTC+2, Julia Lawall wrote: > On Sat, 28 Mar 2015, Cristina Opriceana wrote: > > > Delete duplicated argument to | for the state argument in > > the _clr_fwstate_() function call as it is redundant. > > Detected with coccinelle. > > > > Signed-off-by: Cristina Opriceana <cristina....@gmail.com> > > --- > > drivers/staging/rtl8712/rtl871x_ioctl_set.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_set.c > b/drivers/staging/rtl8712/rtl871x_ioctl_set.c > > index bd1d1b7..22262b3 100644 > > --- a/drivers/staging/rtl8712/rtl871x_ioctl_set.c > > +++ b/drivers/staging/rtl8712/rtl871x_ioctl_set.c > > @@ -266,8 +266,7 @@ void > r8712_set_802_11_infrastructure_mode(struct _adapter *padapter, > > /* clear WIFI_STATION_STATE; WIFI_AP_STATE; > WIFI_ADHOC_STATE; > > * WIFI_ADHOC_MASTER_STATE */ > > _clr_fwstate_(pmlmepriv, WIFI_STATION_STATE | > WIFI_AP_STATE | > > - WIFI_ADHOC_STATE | > WIFI_ADHOC_MASTER_STATE | > > - WIFI_AP_STATE); > > + WIFI_ADHOC_STATE | > WIFI_ADHOC_MASTER_STATE); > > For these, you should normally check the nearby code to see if > they > actually meant something else, but thanks to the comment that > seems > unlikely in this case. How did you find it? > > julia > > > Well, it was detected with coccinelle, then I followed the code and saw it > was duplicated. Oops, I missed that you already said that in the commit message :) julia > > > > > switch (networktype) { > > case Ndis802_11IBSS: > > set_fwstate(pmlmepriv, > WIFI_ADHOC_STATE); > > -- > > 1.9.1 > > > > -- > > You received this message because you are subscribed to the > Google Groups "outreachy-kernel" group. > > To unsubscribe from this group and stop receiving emails from > it, send an email to outreachy-kern...@googlegroups.com. > > To post to this group, send email to > outreach...@googlegroups.com. > > To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/20150328013012.GA7624%40 > Inspiron. > > For more options, visit https://groups.google.com/d/optout. > > > > -- > You received this message because you are subscribed to the Google Groups > "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/15b6d646-9754-4212-a199- > 83d1b23ddd30%40googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > > ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-03-29 12:40 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-03-28 1:30 [PATCH] Staging: rtl8712: Remove duplicated argument to | Cristina Opriceana 2015-03-28 6:07 ` [Outreachy kernel] " Julia Lawall 2015-03-29 12:31 ` Cristina Georgiana Opriceana 2015-03-29 12:39 ` Julia Lawall
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.