From: Lee Jones <lee.jones@linaro.org>
To: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
Tony Lindgren <tony@atomide.com>, Felipe Balbi <balbi@ti.com>
Subject: Re: [PATCH 2/3] mfd: menelaus: drop support for SW controller VCORE
Date: Mon, 30 Mar 2015 08:15:14 +0100 [thread overview]
Message-ID: <20150330071514.GI457@x1> (raw)
In-Reply-To: <1427575537-28508-3-git-send-email-aaro.koskinen@iki.fi>
On Sat, 28 Mar 2015, Aaro Koskinen wrote:
> Drop support for SW controlled VCORE, nobody uses it.
>
> Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
> ---
> drivers/mfd/menelaus.c | 23 -----------------------
> include/linux/mfd/menelaus.h | 1 -
> 2 files changed, 24 deletions(-)
Applied, thanks.
> diff --git a/drivers/mfd/menelaus.c b/drivers/mfd/menelaus.c
> index 9f01aef..917fa86 100644
> --- a/drivers/mfd/menelaus.c
> +++ b/drivers/mfd/menelaus.c
> @@ -532,29 +532,6 @@ static const struct menelaus_vtg_value vcore_values[] = {
> { 1450, 18 },
> };
>
> -int menelaus_set_vcore_sw(unsigned int mV)
> -{
> - int val, ret;
> - struct i2c_client *c = the_menelaus->client;
> -
> - val = menelaus_get_vtg_value(mV, vcore_values,
> - ARRAY_SIZE(vcore_values));
> - if (val < 0)
> - return -EINVAL;
> -
> - dev_dbg(&c->dev, "Setting VCORE to %d mV (val 0x%02x)\n", mV, val);
> -
> - /* Set SW mode and the voltage in one go. */
> - mutex_lock(&the_menelaus->lock);
> - ret = menelaus_write_reg(MENELAUS_VCORE_CTRL1, val);
> - if (ret == 0)
> - the_menelaus->vcore_hw_mode = 0;
> - mutex_unlock(&the_menelaus->lock);
> - msleep(1);
> -
> - return ret;
> -}
> -
> int menelaus_set_vcore_hw(unsigned int roof_mV, unsigned int floor_mV)
> {
> int fval, rval, val, ret;
> diff --git a/include/linux/mfd/menelaus.h b/include/linux/mfd/menelaus.h
> index a1e12bf3..9e85ac0 100644
> --- a/include/linux/mfd/menelaus.h
> +++ b/include/linux/mfd/menelaus.h
> @@ -24,7 +24,6 @@ extern int menelaus_set_vaux(unsigned int mV);
> extern int menelaus_set_vdcdc(int dcdc, unsigned int mV);
> extern int menelaus_set_slot_sel(int enable);
> extern int menelaus_get_slot_pin_states(void);
> -extern int menelaus_set_vcore_sw(unsigned int mV);
> extern int menelaus_set_vcore_hw(unsigned int roof_mV, unsigned int floor_mV);
>
> #define EN_VPLL_SLEEP (1 << 7)
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
Tony Lindgren <tony@atomide.com>, Felipe Balbi <balbi@ti.com>
Subject: Re: [PATCH 2/3] mfd: menelaus: drop support for SW controller VCORE
Date: Mon, 30 Mar 2015 08:15:14 +0100 [thread overview]
Message-ID: <20150330071514.GI457@x1> (raw)
In-Reply-To: <1427575537-28508-3-git-send-email-aaro.koskinen@iki.fi>
On Sat, 28 Mar 2015, Aaro Koskinen wrote:
> Drop support for SW controlled VCORE, nobody uses it.
>
> Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
> ---
> drivers/mfd/menelaus.c | 23 -----------------------
> include/linux/mfd/menelaus.h | 1 -
> 2 files changed, 24 deletions(-)
Applied, thanks.
> diff --git a/drivers/mfd/menelaus.c b/drivers/mfd/menelaus.c
> index 9f01aef..917fa86 100644
> --- a/drivers/mfd/menelaus.c
> +++ b/drivers/mfd/menelaus.c
> @@ -532,29 +532,6 @@ static const struct menelaus_vtg_value vcore_values[] = {
> { 1450, 18 },
> };
>
> -int menelaus_set_vcore_sw(unsigned int mV)
> -{
> - int val, ret;
> - struct i2c_client *c = the_menelaus->client;
> -
> - val = menelaus_get_vtg_value(mV, vcore_values,
> - ARRAY_SIZE(vcore_values));
> - if (val < 0)
> - return -EINVAL;
> -
> - dev_dbg(&c->dev, "Setting VCORE to %d mV (val 0x%02x)\n", mV, val);
> -
> - /* Set SW mode and the voltage in one go. */
> - mutex_lock(&the_menelaus->lock);
> - ret = menelaus_write_reg(MENELAUS_VCORE_CTRL1, val);
> - if (ret == 0)
> - the_menelaus->vcore_hw_mode = 0;
> - mutex_unlock(&the_menelaus->lock);
> - msleep(1);
> -
> - return ret;
> -}
> -
> int menelaus_set_vcore_hw(unsigned int roof_mV, unsigned int floor_mV)
> {
> int fval, rval, val, ret;
> diff --git a/include/linux/mfd/menelaus.h b/include/linux/mfd/menelaus.h
> index a1e12bf3..9e85ac0 100644
> --- a/include/linux/mfd/menelaus.h
> +++ b/include/linux/mfd/menelaus.h
> @@ -24,7 +24,6 @@ extern int menelaus_set_vaux(unsigned int mV);
> extern int menelaus_set_vdcdc(int dcdc, unsigned int mV);
> extern int menelaus_set_slot_sel(int enable);
> extern int menelaus_get_slot_pin_states(void);
> -extern int menelaus_set_vcore_sw(unsigned int mV);
> extern int menelaus_set_vcore_hw(unsigned int roof_mV, unsigned int floor_mV);
>
> #define EN_VPLL_SLEEP (1 << 7)
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2015-03-30 7:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-28 20:45 [PATCH 0/3] mfd: menelaus: couple simple cleanups Aaro Koskinen
2015-03-28 20:45 ` [PATCH 1/3] mfd: menelaus: delete omap_has_menelaus Aaro Koskinen
2015-03-30 7:14 ` Lee Jones
2015-03-30 7:14 ` Lee Jones
2015-03-28 20:45 ` [PATCH 2/3] mfd: menelaus: drop support for SW controller VCORE Aaro Koskinen
2015-03-30 7:15 ` Lee Jones [this message]
2015-03-30 7:15 ` Lee Jones
2015-03-28 20:45 ` [PATCH 3/3] mfd: menelaus: use macro for magic number Aaro Koskinen
2015-03-30 7:15 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150330071514.GI457@x1 \
--to=lee.jones@linaro.org \
--cc=aaro.koskinen@iki.fi \
--cc=balbi@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.