All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Michal Hocko <mhocko@suse.cz>
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	hannes@cmpxchg.org, Christoph Lameter <cl@linux.com>,
	Linaro Kernel Mailman List <linaro-kernel@lists.linaro.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	vinmenon@codeaurora.org, shashim@codeaurora.org, mgorman@suse.de,
	dave@stgolabs.net, koct9i@gmail.com,
	Linux Memory Management List <linux-mm@kvack.org>,
	Suresh Siddha <suresh.b.siddha@intel.com>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [RFC] vmstat: Avoid waking up idle-cpu to service shepherd work
Date: Mon, 30 Mar 2015 17:14:31 +0200	[thread overview]
Message-ID: <20150330151431.GA23123@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20150330150818.GE3909@dhcp22.suse.cz>

On Mon, Mar 30, 2015 at 05:08:18PM +0200, Michal Hocko wrote:
> On Sat 28-03-15 10:53:22, Peter Zijlstra wrote:
> [...]
> > Alternatively the thing hocko suggests is an utter fail too. You cannot
> > stuff that into hardirq context, that's insane.
> 
> I guess you are referring to
> http://article.gmane.org/gmane.linux.kernel.mm/127569, right?
> 
> Why cannot we do something like refresh_cpu_vm_stats from the IRQ
> context?  Especially the first zone stat part.

Big machines have big zone counts. There are machines with >200 nodes.
Although with the current trend of bigger nodes, the number of nodes
seems to come down as well. Still.

> The per-cpu pagesets is
> more costly and it would need a special treatment, alright. A simple
> way would be to splice the lists from the per-cpu context and then free
> those pages from the kthread context.
> 
> I am still wondering why those two things were squashed into a single
> place. Why kswapd is not doing the pcp cleanup?

Probably because they could be. The problem with kswapd is that its per
node, not per cpu.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: Michal Hocko <mhocko@suse.cz>
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	hannes@cmpxchg.org, Christoph Lameter <cl@linux.com>,
	Linaro Kernel Mailman List <linaro-kernel@lists.linaro.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	vinmenon@codeaurora.org, shashim@codeaurora.org, mgorman@suse.de,
	dave@stgolabs.net, koct9i@gmail.com,
	Linux Memory Management List <linux-mm@kvack.org>,
	Suresh Siddha <suresh.b.siddha@intel.com>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [RFC] vmstat: Avoid waking up idle-cpu to service shepherd work
Date: Mon, 30 Mar 2015 17:14:31 +0200	[thread overview]
Message-ID: <20150330151431.GA23123@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20150330150818.GE3909@dhcp22.suse.cz>

On Mon, Mar 30, 2015 at 05:08:18PM +0200, Michal Hocko wrote:
> On Sat 28-03-15 10:53:22, Peter Zijlstra wrote:
> [...]
> > Alternatively the thing hocko suggests is an utter fail too. You cannot
> > stuff that into hardirq context, that's insane.
> 
> I guess you are referring to
> http://article.gmane.org/gmane.linux.kernel.mm/127569, right?
> 
> Why cannot we do something like refresh_cpu_vm_stats from the IRQ
> context?  Especially the first zone stat part.

Big machines have big zone counts. There are machines with >200 nodes.
Although with the current trend of bigger nodes, the number of nodes
seems to come down as well. Still.

> The per-cpu pagesets is
> more costly and it would need a special treatment, alright. A simple
> way would be to splice the lists from the per-cpu context and then free
> those pages from the kthread context.
> 
> I am still wondering why those two things were squashed into a single
> place. Why kswapd is not doing the pcp cleanup?

Probably because they could be. The problem with kswapd is that its per
node, not per cpu.

  reply	other threads:[~2015-03-30 15:14 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-26  5:39 [RFC] vmstat: Avoid waking up idle-cpu to service shepherd work Viresh Kumar
2015-03-26  5:39 ` Viresh Kumar
2015-03-26 20:18 ` Andrew Morton
2015-03-26 20:18   ` Andrew Morton
2015-03-27  4:49   ` Viresh Kumar
2015-03-27  4:49     ` Viresh Kumar
2015-03-27  9:16     ` Peter Zijlstra
2015-03-27  9:16       ` Peter Zijlstra
2015-03-27  9:30       ` Peter Zijlstra
2015-03-27  9:30         ` Peter Zijlstra
2015-03-27 11:11         ` Christoph Lameter
2015-03-27 11:11           ` Christoph Lameter
2015-03-27 12:02           ` Peter Zijlstra
2015-03-27 12:02             ` Peter Zijlstra
2015-03-27 19:45             ` Christoph Lameter
2015-03-27 19:45               ` Christoph Lameter
2015-03-28  4:28             ` Viresh Kumar
2015-03-28  4:28               ` Viresh Kumar
2015-03-28 11:41               ` Peter Zijlstra
2015-03-28 11:41                 ` Peter Zijlstra
2015-03-28  4:18         ` Viresh Kumar
2015-03-28  4:18           ` Viresh Kumar
2015-03-28  9:53           ` Peter Zijlstra
2015-03-28  9:53             ` Peter Zijlstra
2015-03-28 11:57             ` viresh kumar
2015-03-28 11:57               ` viresh kumar
2015-03-28 12:04               ` Viresh Kumar
2015-03-28 12:04                 ` Viresh Kumar
2015-03-28 13:44               ` Peter Zijlstra
2015-03-28 13:44                 ` Peter Zijlstra
2015-03-29 10:24                 ` Peter Zijlstra
2015-03-29 10:24                   ` Peter Zijlstra
2015-03-30 12:02                   ` Viresh Kumar
2015-03-30 12:02                     ` Viresh Kumar
2015-03-30 12:47                     ` Peter Zijlstra
2015-03-30 12:47                       ` Peter Zijlstra
2015-03-30 13:14                       ` Viresh Kumar
2015-03-30 13:14                         ` Viresh Kumar
2015-03-30 13:59                         ` Peter Zijlstra
2015-03-30 13:59                           ` Peter Zijlstra
2015-03-30 16:17                           ` Viresh Kumar
2015-03-30 16:17                             ` Viresh Kumar
2015-03-30 16:25                             ` Peter Zijlstra
2015-03-30 16:25                               ` Peter Zijlstra
2015-03-29 12:01                 ` Viresh Kumar
2015-03-29 12:01                   ` Viresh Kumar
2015-03-29 17:24                   ` Peter Zijlstra
2015-03-29 17:24                     ` Peter Zijlstra
2015-03-30 15:08             ` Michal Hocko
2015-03-30 15:08               ` Michal Hocko
2015-03-30 15:14               ` Peter Zijlstra [this message]
2015-03-30 15:14                 ` Peter Zijlstra
2015-03-30 15:42               ` Christoph Lameter
2015-03-30 15:42                 ` Christoph Lameter
2015-03-27 14:19 ` Michal Hocko
2015-03-27 14:19   ` Michal Hocko
2015-03-28  4:34   ` Viresh Kumar
2015-03-28  4:34     ` Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150330151431.GA23123@twins.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux.com \
    --cc=dave@stgolabs.net \
    --cc=hannes@cmpxchg.org \
    --cc=koct9i@gmail.com \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=mhocko@suse.cz \
    --cc=shashim@codeaurora.org \
    --cc=suresh.b.siddha@intel.com \
    --cc=tglx@linutronix.de \
    --cc=vinmenon@codeaurora.org \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.