* [PATCH v2] Staging: comedi: addi_apci_1564: Delete Whitespace
@ 2015-03-31 5:44 Charlie Wong Super
2015-03-31 5:46 ` [Outreachy kernel] " Julia Lawall
0 siblings, 1 reply; 3+ messages in thread
From: Charlie Wong Super @ 2015-03-31 5:44 UTC (permalink / raw)
To: outreachy-kernel
Fix the checkpatch.pl WARNING: line over 80 characters
Signed-off-by: Charlie Wong Super <1213charlie@gmail.com>
---
drivers/staging/comedi/drivers/addi_apci_1564.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/comedi/drivers/addi_apci_1564.c b/drivers/staging/comedi/drivers/addi_apci_1564.c
index c481c48..dd335e8 100644
--- a/drivers/staging/comedi/drivers/addi_apci_1564.c
+++ b/drivers/staging/comedi/drivers/addi_apci_1564.c
@@ -106,12 +106,12 @@
#define APCI1564_COUNTER(x) ((x) * 0x20)
struct apci1564_private {
- unsigned long eeprom; /* base address of EEPROM register */
- unsigned long timer; /* base address of 12-bit timer */
- unsigned long counters; /* base address of 32-bit counters */
- unsigned int mode1; /* riding-edge/high level channels */
- unsigned int mode2; /* falling-edge/low level channels */
- unsigned int ctrl; /* interrupt mode OR (edge) . AND (level) */
+ unsigned long eeprom; /*base address of EEPROM register*/
+ unsigned long timer; /*base address of 12-bit timer*/
+ unsigned long counters; /*base address of 32-bit counters*/
+ unsigned int mode1; /*riding-edge/high level channels*/
+ unsigned int mode2; /*falling-edge/low level channels*/
+ unsigned int ctrl; /*interrupt mode OR (edge).AND(level)*/
struct task_struct *tsk_current;
};
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Outreachy kernel] [PATCH v2] Staging: comedi: addi_apci_1564: Delete Whitespace
2015-03-31 5:44 [PATCH v2] Staging: comedi: addi_apci_1564: Delete Whitespace Charlie Wong Super
@ 2015-03-31 5:46 ` Julia Lawall
0 siblings, 0 replies; 3+ messages in thread
From: Julia Lawall @ 2015-03-31 5:46 UTC (permalink / raw)
To: Charlie Wong Super; +Cc: outreachy-kernel
On Tue, 31 Mar 2015, Charlie Wong Super wrote:
> Fix the checkpatch.pl WARNING: line over 80 characters
>
> Signed-off-by: Charlie Wong Super <1213charlie@gmail.com>
> ---
You need to explain here (under the ---) what has changed since the
previous version.
julia
> drivers/staging/comedi/drivers/addi_apci_1564.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/addi_apci_1564.c b/drivers/staging/comedi/drivers/addi_apci_1564.c
> index c481c48..dd335e8 100644
> --- a/drivers/staging/comedi/drivers/addi_apci_1564.c
> +++ b/drivers/staging/comedi/drivers/addi_apci_1564.c
> @@ -106,12 +106,12 @@
> #define APCI1564_COUNTER(x) ((x) * 0x20)
>
> struct apci1564_private {
> - unsigned long eeprom; /* base address of EEPROM register */
> - unsigned long timer; /* base address of 12-bit timer */
> - unsigned long counters; /* base address of 32-bit counters */
> - unsigned int mode1; /* riding-edge/high level channels */
> - unsigned int mode2; /* falling-edge/low level channels */
> - unsigned int ctrl; /* interrupt mode OR (edge) . AND (level) */
> + unsigned long eeprom; /*base address of EEPROM register*/
> + unsigned long timer; /*base address of 12-bit timer*/
> + unsigned long counters; /*base address of 32-bit counters*/
> + unsigned int mode1; /*riding-edge/high level channels*/
> + unsigned int mode2; /*falling-edge/low level channels*/
> + unsigned int ctrl; /*interrupt mode OR (edge).AND(level)*/
> struct task_struct *tsk_current;
> };
>
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20150331054435.GA15859%40ThinkPad.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2] Staging: comedi: addi_apci_1564: Delete Whitespace
@ 2015-03-31 5:56 Charlie Wong Super
0 siblings, 0 replies; 3+ messages in thread
From: Charlie Wong Super @ 2015-03-31 5:56 UTC (permalink / raw)
To: outreachy-kernel
Fix the checkpatch.pl WARNING: line over 80 characters
Signed-off-by: Charlie Wong Super <1213charlie@gmail.com>
---
Changes in v2:
1) edit the commit message, make it clear!
drivers/staging/comedi/drivers/addi_apci_1564.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/comedi/drivers/addi_apci_1564.c b/drivers/staging/comedi/drivers/addi_apci_1564.c
index c481c48..dd335e8 100644
--- a/drivers/staging/comedi/drivers/addi_apci_1564.c
+++ b/drivers/staging/comedi/drivers/addi_apci_1564.c
@@ -106,12 +106,12 @@
#define APCI1564_COUNTER(x) ((x) * 0x20)
struct apci1564_private {
- unsigned long eeprom; /* base address of EEPROM register */
- unsigned long timer; /* base address of 12-bit timer */
- unsigned long counters; /* base address of 32-bit counters */
- unsigned int mode1; /* riding-edge/high level channels */
- unsigned int mode2; /* falling-edge/low level channels */
- unsigned int ctrl; /* interrupt mode OR (edge) . AND (level) */
+ unsigned long eeprom; /*base address of EEPROM register*/
+ unsigned long timer; /*base address of 12-bit timer*/
+ unsigned long counters; /*base address of 32-bit counters*/
+ unsigned int mode1; /*riding-edge/high level channels*/
+ unsigned int mode2; /*falling-edge/low level channels*/
+ unsigned int ctrl; /*interrupt mode OR (edge).AND(level)*/
struct task_struct *tsk_current;
};
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-31 5:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-31 5:44 [PATCH v2] Staging: comedi: addi_apci_1564: Delete Whitespace Charlie Wong Super
2015-03-31 5:46 ` [Outreachy kernel] " Julia Lawall
-- strict thread matches above, loose matches on Subject: below --
2015-03-31 5:56 Charlie Wong Super
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.