All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] add CUnit test suite
  2014-10-21 21:02 [meta-oe][PATCH] " Mike Holmes
@ 2014-10-21 21:02 ` Mike Holmes
  2014-10-21 22:26   ` Martin Jansa
  0 siblings, 1 reply; 12+ messages in thread
From: Mike Holmes @ 2014-10-21 21:02 UTC (permalink / raw)
  To: openembedded-core

Signed-off-by: Mike Holmes <mike.holmes@linaro.org>
---
 meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb

diff --git a/meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb b/meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb
new file mode 100644
index 0000000..0e9b2ff
--- /dev/null
+++ b/meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb
@@ -0,0 +1,18 @@
+DESCRIPTION = "CUnit is a C framework for unit testing. Test output supports comandline and GUI reults reporting"
+HOMEPAGE = "http://cunit.sourceforge.net"
+LICENSE = "LGPL-2"
+SECTION = "libs"
+LIC_FILES_CHKSUM = "file://COPYING;md5=7734aa853b85d6f935466f081490ddbb"
+
+S = "${WORKDIR}/CUnit-${PV}"
+
+SRC_URI = "http://downloads.sourceforge.net/project/cunit/CUnit/${PV}/CUnit-${PV}.tar.bz2"
+SRC_URI[md5sum] = "b5f1a9f6093869c070c6e4a9450cc10c"
+SRC_URI[sha256sum] = "f5b29137f845bb08b77ec60584fdb728b4e58f1023e6f249a464efa49a40f214"
+
+inherit autotools-brokensep
+
+EXTRA_OECONF = "--srcdir=`pwd` --prefix=$INSTALL_HOME --enable-debug --enable-memtrace --enable-automated --enable-basic --enable-console"
+
+FILES_${PN}-doc += "doc"
+FILES_${PN}-dev += "${prefix}/share"
-- 
1.9.1



^ permalink raw reply related	[flat|nested] 12+ messages in thread

* Re: [PATCH] add CUnit test suite
  2014-10-21 21:02 ` [PATCH] " Mike Holmes
@ 2014-10-21 22:26   ` Martin Jansa
  0 siblings, 0 replies; 12+ messages in thread
From: Martin Jansa @ 2014-10-21 22:26 UTC (permalink / raw)
  To: Mike Holmes; +Cc: openembedded-core

[-- Attachment #1: Type: text/plain, Size: 1839 bytes --]

On Tue, Oct 21, 2014 at 05:02:37PM -0400, Mike Holmes wrote:
> Signed-off-by: Mike Holmes <mike.holmes@linaro.org>
> ---
>  meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb | 18 ++++++++++++++++++

meta-oe changes belong to openembedded-devel@lists.openembedded.org

>  1 file changed, 18 insertions(+)
>  create mode 100644 meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb
> 
> diff --git a/meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb b/meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb
> new file mode 100644
> index 0000000..0e9b2ff
> --- /dev/null
> +++ b/meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb
> @@ -0,0 +1,18 @@
> +DESCRIPTION = "CUnit is a C framework for unit testing. Test output supports comandline and GUI reults reporting"
> +HOMEPAGE = "http://cunit.sourceforge.net"
> +LICENSE = "LGPL-2"
> +SECTION = "libs"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=7734aa853b85d6f935466f081490ddbb"
> +
> +S = "${WORKDIR}/CUnit-${PV}"
> +
> +SRC_URI = "http://downloads.sourceforge.net/project/cunit/CUnit/${PV}/CUnit-${PV}.tar.bz2"
> +SRC_URI[md5sum] = "b5f1a9f6093869c070c6e4a9450cc10c"
> +SRC_URI[sha256sum] = "f5b29137f845bb08b77ec60584fdb728b4e58f1023e6f249a464efa49a40f214"
> +
> +inherit autotools-brokensep
> +
> +EXTRA_OECONF = "--srcdir=`pwd` --prefix=$INSTALL_HOME --enable-debug --enable-memtrace --enable-automated --enable-basic --enable-console"

`pwd` == ${S}?
what's INSTALL_HOME?

> +FILES_${PN}-doc += "doc"
this doesn't look correct

> +FILES_${PN}-dev += "${prefix}/share"

this is datadir

> -- 
> 1.9.1
> 
> -- 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [PATCH] add CUnit test suite
@ 2014-10-22 15:49 Mike Holmes
  2014-10-22 16:21 ` Martin Jansa
  2015-03-31  4:10 ` [meta-oe][PATCH V2] " Gary S. Robertson
  0 siblings, 2 replies; 12+ messages in thread
From: Mike Holmes @ 2014-10-22 15:49 UTC (permalink / raw)
  To: openembedded-devel

Signed-off-by: Mike Holmes <mike.holmes@linaro.org>
---
 meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb

diff --git a/meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb b/meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb
new file mode 100644
index 0000000..e869852
--- /dev/null
+++ b/meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb
@@ -0,0 +1,18 @@
+DESCRIPTION = "CUnit is a C framework for unit testing. Test output supports comandline and GUI reults reporting"
+HOMEPAGE = "http://cunit.sourceforge.net"
+LICENSE = "LGPL-2.0"
+SECTION = "libs"
+LIC_FILES_CHKSUM = "file://COPYING;md5=7734aa853b85d6f935466f081490ddbb"
+
+S = "${WORKDIR}/CUnit-${PV}"
+
+SRC_URI = "http://downloads.sourceforge.net/project/cunit/CUnit/${PV}/CUnit-${PV}.tar.bz2"
+SRC_URI[md5sum] = "b5f1a9f6093869c070c6e4a9450cc10c"
+SRC_URI[sha256sum] = "f5b29137f845bb08b77ec60584fdb728b4e58f1023e6f249a464efa49a40f214"
+
+inherit autotools-brokensep
+
+EXTRA_OECONF = "--enable-debug --enable-memtrace --enable-automated --enable-basic --enable-console"
+
+FILES_${PN}-doc += "${prefix}/doc"
+FILES_${PN}-dev += "${datadir}"
-- 
1.9.1



^ permalink raw reply related	[flat|nested] 12+ messages in thread

* Re: [PATCH] add CUnit test suite
  2014-10-22 15:49 [PATCH] add CUnit test suite Mike Holmes
@ 2014-10-22 16:21 ` Martin Jansa
  2014-10-22 16:34   ` Mike Holmes
  2014-10-22 20:19   ` Mike Holmes
  2015-03-31  4:10 ` [meta-oe][PATCH V2] " Gary S. Robertson
  1 sibling, 2 replies; 12+ messages in thread
From: Martin Jansa @ 2014-10-22 16:21 UTC (permalink / raw)
  To: openembedded-devel

[-- Attachment #1: Type: text/plain, Size: 1723 bytes --]

On Wed, Oct 22, 2014 at 11:49:05AM -0400, Mike Holmes wrote:
> Signed-off-by: Mike Holmes <mike.holmes@linaro.org>
> ---
>  meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>  create mode 100644 meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb
> 
> diff --git a/meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb b/meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb
> new file mode 100644
> index 0000000..e869852
> --- /dev/null
> +++ b/meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb
> @@ -0,0 +1,18 @@
> +DESCRIPTION = "CUnit is a C framework for unit testing. Test output supports comandline and GUI reults reporting"
> +HOMEPAGE = "http://cunit.sourceforge.net"
> +LICENSE = "LGPL-2.0"
> +SECTION = "libs"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=7734aa853b85d6f935466f081490ddbb"
> +
> +S = "${WORKDIR}/CUnit-${PV}"
> +
> +SRC_URI = "http://downloads.sourceforge.net/project/cunit/CUnit/${PV}/CUnit-${PV}.tar.bz2"
> +SRC_URI[md5sum] = "b5f1a9f6093869c070c6e4a9450cc10c"
> +SRC_URI[sha256sum] = "f5b29137f845bb08b77ec60584fdb728b4e58f1023e6f249a464efa49a40f214"
> +
> +inherit autotools-brokensep
> +
> +EXTRA_OECONF = "--enable-debug --enable-memtrace --enable-automated --enable-basic --enable-console"
> +
> +FILES_${PN}-doc += "${prefix}/doc"

Why doesn't it use ${datadir}/doc == ${docdir} as everything else?

> +FILES_${PN}-dev += "${datadir}"
> -- 
> 1.9.1
> 
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] add CUnit test suite
  2014-10-22 16:21 ` Martin Jansa
@ 2014-10-22 16:34   ` Mike Holmes
  2014-10-22 20:19   ` Mike Holmes
  1 sibling, 0 replies; 12+ messages in thread
From: Mike Holmes @ 2014-10-22 16:34 UTC (permalink / raw)
  To: openembedded-devel

On 22 October 2014 12:21, Martin Jansa <martin.jansa@gmail.com> wrote:

> On Wed, Oct 22, 2014 at 11:49:05AM -0400, Mike Holmes wrote:
> > Signed-off-by: Mike Holmes <mike.holmes@linaro.org>
> > ---
> >  meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb | 18 ++++++++++++++++++
> >  1 file changed, 18 insertions(+)
> >  create mode 100644 meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb
> >
> > diff --git a/meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb
> b/meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb
> > new file mode 100644
> > index 0000000..e869852
> > --- /dev/null
> > +++ b/meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb
> > @@ -0,0 +1,18 @@
> > +DESCRIPTION = "CUnit is a C framework for unit testing. Test output
> supports comandline and GUI reults reporting"
> > +HOMEPAGE = "http://cunit.sourceforge.net"
> > +LICENSE = "LGPL-2.0"
> > +SECTION = "libs"
> > +LIC_FILES_CHKSUM = "file://COPYING;md5=7734aa853b85d6f935466f081490ddbb"
> > +
> > +S = "${WORKDIR}/CUnit-${PV}"
> > +
> > +SRC_URI = "
> http://downloads.sourceforge.net/project/cunit/CUnit/${PV}/CUnit-${PV}.tar.bz2
> "
> > +SRC_URI[md5sum] = "b5f1a9f6093869c070c6e4a9450cc10c"
> > +SRC_URI[sha256sum] =
> "f5b29137f845bb08b77ec60584fdb728b4e58f1023e6f249a464efa49a40f214"
> > +
> > +inherit autotools-brokensep
> > +
> > +EXTRA_OECONF = "--enable-debug --enable-memtrace --enable-automated
> --enable-basic --enable-console"
> > +
> > +FILES_${PN}-doc += "${prefix}/doc"
>
> Why doesn't it use ${datadir}/doc == ${docdir} as everything else?
>

My inexperience with OE most likely, I will try that, thank you.


>
> > +FILES_${PN}-dev += "${datadir}"
> > --
> > 1.9.1
> >
> > --
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
> --
> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
>


-- 
*Mike Holmes*
Linaro  Sr Technical Manager
LNG - ODP


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] add CUnit test suite
  2014-10-22 16:21 ` Martin Jansa
  2014-10-22 16:34   ` Mike Holmes
@ 2014-10-22 20:19   ` Mike Holmes
  2014-10-22 20:28     ` Burton, Ross
  1 sibling, 1 reply; 12+ messages in thread
From: Mike Holmes @ 2014-10-22 20:19 UTC (permalink / raw)
  To: openembedded-devel

On 22 October 2014 12:21, Martin Jansa <martin.jansa@gmail.com> wrote:

> On Wed, Oct 22, 2014 at 11:49:05AM -0400, Mike Holmes wrote:
> > Signed-off-by: Mike Holmes <mike.holmes@linaro.org>
> > ---
> >  meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb | 18 ++++++++++++++++++
> >  1 file changed, 18 insertions(+)
> >  create mode 100644 meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb
> >
> > diff --git a/meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb
> b/meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb
> > new file mode 100644
> > index 0000000..e869852
> > --- /dev/null
> > +++ b/meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb
> > @@ -0,0 +1,18 @@
> > +DESCRIPTION = "CUnit is a C framework for unit testing. Test output
> supports comandline and GUI reults reporting"
> > +HOMEPAGE = "http://cunit.sourceforge.net"
> > +LICENSE = "LGPL-2.0"
> > +SECTION = "libs"
> > +LIC_FILES_CHKSUM = "file://COPYING;md5=7734aa853b85d6f935466f081490ddbb"
> > +
> > +S = "${WORKDIR}/CUnit-${PV}"
> > +
> > +SRC_URI = "
> http://downloads.sourceforge.net/project/cunit/CUnit/${PV}/CUnit-${PV}.tar.bz2
> "
> > +SRC_URI[md5sum] = "b5f1a9f6093869c070c6e4a9450cc10c"
> > +SRC_URI[sha256sum] =
> "f5b29137f845bb08b77ec60584fdb728b4e58f1023e6f249a464efa49a40f214"
> > +
> > +inherit autotools-brokensep
> > +
> > +EXTRA_OECONF = "--enable-debug --enable-memtrace --enable-automated
> --enable-basic --enable-console"
> > +
> > +FILES_${PN}-doc += "${prefix}/doc"
>
> Why doesn't it use ${datadir}/doc == ${docdir} as everything else?
>

I think the reason is because CUnit places its docs in /usr/doc/CUnit which
is not the same as docdir (usr/share/doc)


>
> > +FILES_${PN}-dev += "${datadir}"
> > --
> > 1.9.1
> >
> > --
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
> --
> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
>


-- 
*Mike Holmes*
Linaro  Sr Technical Manager
LNG - ODP


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] add CUnit test suite
  2014-10-22 20:19   ` Mike Holmes
@ 2014-10-22 20:28     ` Burton, Ross
  0 siblings, 0 replies; 12+ messages in thread
From: Burton, Ross @ 2014-10-22 20:28 UTC (permalink / raw)
  To: OE-devel

On 22 October 2014 21:19, Mike Holmes <mike.holmes@linaro.org> wrote:

> I think the reason is because CUnit places its docs in /usr/doc/CUnit which
> is not the same as docdir (usr/share/doc)
>

In that case the recipe should fix the location.

Ross


^ permalink raw reply	[flat|nested] 12+ messages in thread

* [meta-oe][PATCH V2] add CUnit test suite
  2014-10-22 15:49 [PATCH] add CUnit test suite Mike Holmes
  2014-10-22 16:21 ` Martin Jansa
@ 2015-03-31  4:10 ` Gary S. Robertson
  2015-03-31  4:10   ` [PATCH] " Gary S. Robertson
  1 sibling, 1 reply; 12+ messages in thread
From: Gary S. Robertson @ 2015-03-31  4:10 UTC (permalink / raw)
  To: Martin Jansa, Ross Burton; +Cc: openembedded-devel

Mike Holmes has asked me to resubmit this patch on his behalf, as other
duties have currently preempted his efforts to pursue acceptance of this
new recipe in OE.

A new patch file was added which sets the path configuration variables
to place documentation and headers in locations consistent with the
OE filesystem layout.

Looking in the ${WORKDIR}/*destdir and ${WORKDIR}/deploy-ipks subdirectories
after performing the recipe build, it appears that everything is being placed
into the appropriate locations.

We believe this version of the recipe addresses the concerns
raised in the email exchanges regarding the initial recipe submission,
and hope you will now find it acceptable.



^ permalink raw reply	[flat|nested] 12+ messages in thread

* [PATCH] add CUnit test suite
  2015-03-31  4:10 ` [meta-oe][PATCH V2] " Gary S. Robertson
@ 2015-03-31  4:10   ` Gary S. Robertson
  2015-03-31  7:07     ` Martin Jansa
  0 siblings, 1 reply; 12+ messages in thread
From: Gary S. Robertson @ 2015-03-31  4:10 UTC (permalink / raw)
  To: Martin Jansa, Ross Burton; +Cc: openembedded-devel

From: Mike Holmes <mike.holmes@linaro.org>

This patch adds a recipe for building the CUnit test framework libraries

Upstream Status - not applicable - recipe addition only

Signed-off-by: Mike Holmes <mike.holmes@linaro.org>
Signed-off-by: Gary S. Robertson <gary.robertson@linaro.org>
---
 meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb      | 19 ++++++++++++
 .../cunit/files/fixup-install-docdir.patch         | 36 ++++++++++++++++++++++
 2 files changed, 55 insertions(+)
 create mode 100644 meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb
 create mode 100644 meta-oe/recipes-devtools/cunit/files/fixup-install-docdir.patch

diff --git a/meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb b/meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb
new file mode 100644
index 0000000..246a121
--- /dev/null
+++ b/meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb
@@ -0,0 +1,19 @@
+DESCRIPTION = "CUnit is a C framework for unit testing. Test output supports comandline and GUI results reporting"
+HOMEPAGE = "http://cunit.sourceforge.net"
+LICENSE = "LGPL-2.0"
+SECTION = "libs"
+LIC_FILES_CHKSUM = "file://COPYING;md5=7734aa853b85d6f935466f081490ddbb"
+
+S = "${WORKDIR}/CUnit-${PV}"
+
+SRC_URI = "http://downloads.sourceforge.net/project/cunit/CUnit/${PV}/CUnit-${PV}.tar.bz2 \
+		file://fixup-install-docdir.patch;patch=1"
+SRC_URI[md5sum] = "b5f1a9f6093869c070c6e4a9450cc10c"
+SRC_URI[sha256sum] = "f5b29137f845bb08b77ec60584fdb728b4e58f1023e6f249a464efa49a40f214"
+
+inherit autotools-brokensep
+
+EXTRA_OECONF = "--enable-memtrace --enable-automated --enable-basic --enable-console"
+
+FILES_${PN}-dev += "${datadir}/CUnit"
+FILES_${PN}-doc += "${docdir}"
diff --git a/meta-oe/recipes-devtools/cunit/files/fixup-install-docdir.patch b/meta-oe/recipes-devtools/cunit/files/fixup-install-docdir.patch
new file mode 100644
index 0000000..a9dc4bc
--- /dev/null
+++ b/meta-oe/recipes-devtools/cunit/files/fixup-install-docdir.patch
@@ -0,0 +1,36 @@
+From: "Mike Holmes" <mike.holmes@linaro.org>
+Date: Thu, 30 October 2014 16:21:03 -0500
+Subject: [PATCH] fixup-install-docdir
+
+The default configuration macros for CUnit install the documentation and
+header files in locations not consistent with the OE filesystem layout.
+This patch specifies new locations which are consistent with OE filesystems.
+
+Upstream Status - not applicable - customizes configs for OE build environment
+
+Signed-off-by: Mike Holmes <mike.holmes@linaro.org>
+Signed-off-by: Gary S. Robertson <gary.robertson@linaro.org>
+---
+
+diff -uNr a/doc/headers/Makefile.am b/doc/headers/Makefile.am
+--- a/doc/headers/Makefile.am	2014-10-30 22:06:29.704574162 +0100
++++ b/doc/headers/Makefile.am	2014-10-30 22:07:43.578524791 +0100
+@@ -1,6 +1,6 @@
+ ## Process this file with automake to produce Makefile.in
+ 
+-dochdrdir = $(prefix)/doc/@PACKAGE@/headers
++dochdrdir = $(docdir)/headers
+ 
+ INCLUDE_FILES = \
+ 	Automated.h \
+diff -uNr a/doc/Makefile.am b/doc/Makefile.am
+--- a/doc/Makefile.am	2014-10-30 22:06:29.704574162 +0100
++++ b/doc/Makefile.am	2014-10-30 22:07:01.461412166 +0100
+@@ -1,7 +1,5 @@
+ ## Process this file with automake to produce Makefile.in
+ 
+-docdir = $(prefix)/doc/@PACKAGE@
+-
+ doc_DATA = \
+ 	CUnit_doc.css \
+ 	error_handling.html \
-- 
1.9.1



^ permalink raw reply related	[flat|nested] 12+ messages in thread

* Re: [PATCH] add CUnit test suite
  2015-03-31  4:10   ` [PATCH] " Gary S. Robertson
@ 2015-03-31  7:07     ` Martin Jansa
  2015-04-01 21:50       ` [meta-oe][PATCH V3] " Gary S. Robertson
  0 siblings, 1 reply; 12+ messages in thread
From: Martin Jansa @ 2015-03-31  7:07 UTC (permalink / raw)
  To: Gary S. Robertson; +Cc: openembedded-devel

[-- Attachment #1: Type: text/plain, Size: 3979 bytes --]

On Mon, Mar 30, 2015 at 11:10:41PM -0500, Gary S. Robertson wrote:
> From: Mike Holmes <mike.holmes@linaro.org>
> 
> This patch adds a recipe for building the CUnit test framework libraries
> 
> Upstream Status - not applicable - recipe addition only

Upstream-Status belongs to .patch files not metadata commit messages.

> 
> Signed-off-by: Mike Holmes <mike.holmes@linaro.org>
> Signed-off-by: Gary S. Robertson <gary.robertson@linaro.org>
> ---
>  meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb      | 19 ++++++++++++
>  .../cunit/files/fixup-install-docdir.patch         | 36 ++++++++++++++++++++++
>  2 files changed, 55 insertions(+)
>  create mode 100644 meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb
>  create mode 100644 meta-oe/recipes-devtools/cunit/files/fixup-install-docdir.patch
> 
> diff --git a/meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb b/meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb
> new file mode 100644
> index 0000000..246a121
> --- /dev/null
> +++ b/meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb
> @@ -0,0 +1,19 @@
> +DESCRIPTION = "CUnit is a C framework for unit testing. Test output supports comandline and GUI results reporting"
> +HOMEPAGE = "http://cunit.sourceforge.net"
> +LICENSE = "LGPL-2.0"
> +SECTION = "libs"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=7734aa853b85d6f935466f081490ddbb"
> +
> +S = "${WORKDIR}/CUnit-${PV}"
> +
> +SRC_URI = "http://downloads.sourceforge.net/project/cunit/CUnit/${PV}/CUnit-${PV}.tar.bz2 \
> +		file://fixup-install-docdir.patch;patch=1"

Use 4 spaces for indentation and ";patch=1" shouldn't be needed, drop
it.

Use SOURCEFORGE_MIRROR = "http://downloads.sourceforge.net" variable.

> +SRC_URI[md5sum] = "b5f1a9f6093869c070c6e4a9450cc10c"
> +SRC_URI[sha256sum] = "f5b29137f845bb08b77ec60584fdb728b4e58f1023e6f249a464efa49a40f214"
> +
> +inherit autotools-brokensep
> +
> +EXTRA_OECONF = "--enable-memtrace --enable-automated --enable-basic --enable-console"
> +
> +FILES_${PN}-dev += "${datadir}/CUnit"
> +FILES_${PN}-doc += "${docdir}"
> diff --git a/meta-oe/recipes-devtools/cunit/files/fixup-install-docdir.patch b/meta-oe/recipes-devtools/cunit/files/fixup-install-docdir.patch
> new file mode 100644
> index 0000000..a9dc4bc
> --- /dev/null
> +++ b/meta-oe/recipes-devtools/cunit/files/fixup-install-docdir.patch
> @@ -0,0 +1,36 @@
> +From: "Mike Holmes" <mike.holmes@linaro.org>
> +Date: Thu, 30 October 2014 16:21:03 -0500
> +Subject: [PATCH] fixup-install-docdir
> +
> +The default configuration macros for CUnit install the documentation and
> +header files in locations not consistent with the OE filesystem layout.
> +This patch specifies new locations which are consistent with OE filesystems.
> +
> +Upstream Status - not applicable - customizes configs for OE build environment

See:
http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines#Patch_Header_Recommendations
for proper format

> +
> +Signed-off-by: Mike Holmes <mike.holmes@linaro.org>
> +Signed-off-by: Gary S. Robertson <gary.robertson@linaro.org>
> +---
> +
> +diff -uNr a/doc/headers/Makefile.am b/doc/headers/Makefile.am
> +--- a/doc/headers/Makefile.am	2014-10-30 22:06:29.704574162 +0100
> ++++ b/doc/headers/Makefile.am	2014-10-30 22:07:43.578524791 +0100
> +@@ -1,6 +1,6 @@
> + ## Process this file with automake to produce Makefile.in
> + 
> +-dochdrdir = $(prefix)/doc/@PACKAGE@/headers
> ++dochdrdir = $(docdir)/headers
> + 
> + INCLUDE_FILES = \
> + 	Automated.h \
> +diff -uNr a/doc/Makefile.am b/doc/Makefile.am
> +--- a/doc/Makefile.am	2014-10-30 22:06:29.704574162 +0100
> ++++ b/doc/Makefile.am	2014-10-30 22:07:01.461412166 +0100
> +@@ -1,7 +1,5 @@
> + ## Process this file with automake to produce Makefile.in
> + 
> +-docdir = $(prefix)/doc/@PACKAGE@
> +-
> + doc_DATA = \
> + 	CUnit_doc.css \
> + 	error_handling.html \
> -- 
> 1.9.1
> 

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [meta-oe][PATCH V3] add CUnit test suite
  2015-03-31  7:07     ` Martin Jansa
@ 2015-04-01 21:50       ` Gary S. Robertson
  2015-04-01 21:50         ` [PATCH] " Gary S. Robertson
  0 siblings, 1 reply; 12+ messages in thread
From: Gary S. Robertson @ 2015-04-01 21:50 UTC (permalink / raw)
  To: Martin Jansa, Ross Burton; +Cc: openembedded-devel

Thanks very much for your prompt reply, critique, and for the link to the
patch submission guidelines document.  I see by reading that document that
I made some of the canonical irritating mistakes mentioned there.
I appreciate your patience as I slowly learn the fine points of
upstreaming patches properly.

I have attempted to properly incorporate all your cleanup suggestions
and hope this version of the recipe will be satisfactory.

Thanks,

Gary Robertson



^ permalink raw reply	[flat|nested] 12+ messages in thread

* [PATCH] add CUnit test suite
  2015-04-01 21:50       ` [meta-oe][PATCH V3] " Gary S. Robertson
@ 2015-04-01 21:50         ` Gary S. Robertson
  0 siblings, 0 replies; 12+ messages in thread
From: Gary S. Robertson @ 2015-04-01 21:50 UTC (permalink / raw)
  To: Martin Jansa, Ross Burton; +Cc: openembedded-devel

From: Mike Holmes <mike.holmes@linaro.org>

Adds a new recipe for building the CUnit test framework libraries

Signed-off-by: Mike Holmes <mike.holmes@linaro.org>
Signed-off-by: Gary S. Robertson <gary.robertson@linaro.org>
---
 meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb      | 19 ++++++++++++
 .../cunit/files/fixup-install-docdir.patch         | 36 ++++++++++++++++++++++
 2 files changed, 55 insertions(+)
 create mode 100644 meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb
 create mode 100644 meta-oe/recipes-devtools/cunit/files/fixup-install-docdir.patch

diff --git a/meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb b/meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb
new file mode 100644
index 0000000..085f4be
--- /dev/null
+++ b/meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb
@@ -0,0 +1,19 @@
+DESCRIPTION = "CUnit is a C framework for unit testing. Test output supports comandline and GUI results reporting"
+HOMEPAGE = "http://cunit.sourceforge.net"
+LICENSE = "LGPL-2.0"
+SECTION = "libs"
+LIC_FILES_CHKSUM = "file://COPYING;md5=7734aa853b85d6f935466f081490ddbb"
+
+S = "${WORKDIR}/CUnit-${PV}"
+
+SRC_URI = "${SOURCEFORGE_MIRROR}/project/cunit/CUnit/${PV}/CUnit-${PV}.tar.bz2 \
+    file://fixup-install-docdir.patch"
+SRC_URI[md5sum] = "b5f1a9f6093869c070c6e4a9450cc10c"
+SRC_URI[sha256sum] = "f5b29137f845bb08b77ec60584fdb728b4e58f1023e6f249a464efa49a40f214"
+
+inherit autotools-brokensep
+
+EXTRA_OECONF = "--enable-memtrace --enable-automated --enable-basic --enable-console"
+
+FILES_${PN}-dev += "${datadir}/CUnit"
+FILES_${PN}-doc += "${docdir}"
diff --git a/meta-oe/recipes-devtools/cunit/files/fixup-install-docdir.patch b/meta-oe/recipes-devtools/cunit/files/fixup-install-docdir.patch
new file mode 100644
index 0000000..c328227
--- /dev/null
+++ b/meta-oe/recipes-devtools/cunit/files/fixup-install-docdir.patch
@@ -0,0 +1,36 @@
+From: "Mike Holmes" <mike.holmes@linaro.org>
+Date: Thu, 30 October 2014 16:21:03 -0500
+Subject: [PATCH] fixup-install-docdir
+
+The default configuration macros for CUnit install the documentation and
+header files in locations not consistent with the OE filesystem layout.
+So here we specify new locations which are consistent with OE filesystems.
+
+Upstream-Status: Inappropriate - configuration for OE build environment
+
+Signed-off-by: Mike Holmes <mike.holmes@linaro.org>
+Signed-off-by: Gary S. Robertson <gary.robertson@linaro.org>
+---
+
+diff -uNr a/doc/headers/Makefile.am b/doc/headers/Makefile.am
+--- a/doc/headers/Makefile.am	2014-10-30 22:06:29.704574162 +0100
++++ b/doc/headers/Makefile.am	2014-10-30 22:07:43.578524791 +0100
+@@ -1,6 +1,6 @@
+ ## Process this file with automake to produce Makefile.in
+ 
+-dochdrdir = $(prefix)/doc/@PACKAGE@/headers
++dochdrdir = $(docdir)/headers
+ 
+ INCLUDE_FILES = \
+ 	Automated.h \
+diff -uNr a/doc/Makefile.am b/doc/Makefile.am
+--- a/doc/Makefile.am	2014-10-30 22:06:29.704574162 +0100
++++ b/doc/Makefile.am	2014-10-30 22:07:01.461412166 +0100
+@@ -1,7 +1,5 @@
+ ## Process this file with automake to produce Makefile.in
+ 
+-docdir = $(prefix)/doc/@PACKAGE@
+-
+ doc_DATA = \
+ 	CUnit_doc.css \
+ 	error_handling.html \
-- 
1.9.1



^ permalink raw reply related	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2015-04-01 21:50 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-22 15:49 [PATCH] add CUnit test suite Mike Holmes
2014-10-22 16:21 ` Martin Jansa
2014-10-22 16:34   ` Mike Holmes
2014-10-22 20:19   ` Mike Holmes
2014-10-22 20:28     ` Burton, Ross
2015-03-31  4:10 ` [meta-oe][PATCH V2] " Gary S. Robertson
2015-03-31  4:10   ` [PATCH] " Gary S. Robertson
2015-03-31  7:07     ` Martin Jansa
2015-04-01 21:50       ` [meta-oe][PATCH V3] " Gary S. Robertson
2015-04-01 21:50         ` [PATCH] " Gary S. Robertson
  -- strict thread matches above, loose matches on Subject: below --
2014-10-21 21:02 [meta-oe][PATCH] " Mike Holmes
2014-10-21 21:02 ` [PATCH] " Mike Holmes
2014-10-21 22:26   ` Martin Jansa

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.