All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Mueller <mimu@linux.vnet.ibm.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org,
	linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
	Eduardo Habkost <ehabkost@redhat.com>,
	Gleb Natapov <gleb@kernel.org>, Alexander Graf <agraf@suse.de>,
	"Jason J. Herne" <jjherne@linux.vnet.ibm.com>,
	Cornelia Huck <cornelia.huck@de.ibm.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Andreas Faerber <afaerber@suse.de>,
	Richard Henderson <rth@twiddle.net>,
	Daniel Hansel <daniel.hansel@linux.vnet.ibm.com>
Subject: Re: [PATCH v4 07/15] target-s390x: Update linux-headers/asm-s390/kvm.h
Date: Tue, 31 Mar 2015 09:25:45 +0200	[thread overview]
Message-ID: <20150331092545.2139b79a@bee> (raw)
In-Reply-To: <5519A5B6.9090803@de.ibm.com>

On Mon, 30 Mar 2015 21:36:22 +0200
Christian Borntraeger <borntraeger@de.ibm.com> wrote:

> Am 30.03.2015 um 16:28 schrieb Michael Mueller:
> > Signed-off-by: Michael Mueller <mimu@linux.vnet.ibm.com>
> > ---
> >  linux-headers/asm-s390/kvm.h | 18 +++++++++---------
> >  1 file changed, 9 insertions(+), 9 deletions(-)
> > 
> 
> Looks like a leftover. Drop that patch and rename ibc_range to ibc in the other patch.

Will drop the patch and stay with the current name used upstream already.
> 
> 
> > diff --git a/linux-headers/asm-s390/kvm.h b/linux-headers/asm-s390/kvm.h
> > index c5a93eb..bfe6925 100644
> > --- a/linux-headers/asm-s390/kvm.h
> > +++ b/linux-headers/asm-s390/kvm.h
> > @@ -70,8 +70,14 @@ struct kvm_s390_io_adapter_req {
> >  #define KVM_S390_VM_TOD_LOW		0
> >  #define KVM_S390_VM_TOD_HIGH		1
> > 
> > +/* kvm attributes for crypto */
> > +#define KVM_S390_VM_CRYPTO_ENABLE_AES_KW	0
> > +#define KVM_S390_VM_CRYPTO_ENABLE_DEA_KW	1
> > +#define KVM_S390_VM_CRYPTO_DISABLE_AES_KW	2
> > +#define KVM_S390_VM_CRYPTO_DISABLE_DEA_KW	3
> > +
> >  /* kvm attributes for KVM_S390_VM_CPU_MODEL */
> > -/* processor related attributes are r/w */
> > +/* kvm S390 processor related attributes are r/w */
> >  #define KVM_S390_VM_CPU_PROCESSOR	0
> >  struct kvm_s390_vm_cpu_processor {
> >  	__u64 cpuid;
> > @@ -80,22 +86,16 @@ struct kvm_s390_vm_cpu_processor {
> >  	__u64 fac_list[256];
> >  };
> > 
> > -/* machine related attributes are r/o */
> > +/* kvm S390 machine related attributes are r/o */
> >  #define KVM_S390_VM_CPU_MACHINE		1
> >  struct kvm_s390_vm_cpu_machine {
> >  	__u64 cpuid;
> > -	__u32 ibc;
> > +	__u32 ibc_range;
> >  	__u8  pad[4];
> >  	__u64 fac_mask[256];
> >  	__u64 fac_list[256];
> >  };
> > 
> > -/* kvm attributes for crypto */
> > -#define KVM_S390_VM_CRYPTO_ENABLE_AES_KW	0
> > -#define KVM_S390_VM_CRYPTO_ENABLE_DEA_KW	1
> > -#define KVM_S390_VM_CRYPTO_DISABLE_AES_KW	2
> > -#define KVM_S390_VM_CRYPTO_DISABLE_DEA_KW	3
> > -
> >  /* for KVM_GET_REGS and KVM_SET_REGS */
> >  struct kvm_regs {
> >  	/* general purpose regs for s390 */
> > 
> 

WARNING: multiple messages have this Message-ID (diff)
From: Michael Mueller <mimu@linux.vnet.ibm.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: linux-s390@vger.kernel.org, Eduardo Habkost <ehabkost@redhat.com>,
	kvm@vger.kernel.org, Gleb Natapov <gleb@kernel.org>,
	qemu-devel@nongnu.org, linux-kernel@vger.kernel.org,
	Daniel Hansel <daniel.hansel@linux.vnet.ibm.com>,
	Alexander Graf <agraf@suse.de>,
	"Jason J. Herne" <jjherne@linux.vnet.ibm.com>,
	Cornelia Huck <cornelia.huck@de.ibm.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Andreas Faerber <afaerber@suse.de>,
	Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v4 07/15] target-s390x: Update linux-headers/asm-s390/kvm.h
Date: Tue, 31 Mar 2015 09:25:45 +0200	[thread overview]
Message-ID: <20150331092545.2139b79a@bee> (raw)
In-Reply-To: <5519A5B6.9090803@de.ibm.com>

On Mon, 30 Mar 2015 21:36:22 +0200
Christian Borntraeger <borntraeger@de.ibm.com> wrote:

> Am 30.03.2015 um 16:28 schrieb Michael Mueller:
> > Signed-off-by: Michael Mueller <mimu@linux.vnet.ibm.com>
> > ---
> >  linux-headers/asm-s390/kvm.h | 18 +++++++++---------
> >  1 file changed, 9 insertions(+), 9 deletions(-)
> > 
> 
> Looks like a leftover. Drop that patch and rename ibc_range to ibc in the other patch.

Will drop the patch and stay with the current name used upstream already.
> 
> 
> > diff --git a/linux-headers/asm-s390/kvm.h b/linux-headers/asm-s390/kvm.h
> > index c5a93eb..bfe6925 100644
> > --- a/linux-headers/asm-s390/kvm.h
> > +++ b/linux-headers/asm-s390/kvm.h
> > @@ -70,8 +70,14 @@ struct kvm_s390_io_adapter_req {
> >  #define KVM_S390_VM_TOD_LOW		0
> >  #define KVM_S390_VM_TOD_HIGH		1
> > 
> > +/* kvm attributes for crypto */
> > +#define KVM_S390_VM_CRYPTO_ENABLE_AES_KW	0
> > +#define KVM_S390_VM_CRYPTO_ENABLE_DEA_KW	1
> > +#define KVM_S390_VM_CRYPTO_DISABLE_AES_KW	2
> > +#define KVM_S390_VM_CRYPTO_DISABLE_DEA_KW	3
> > +
> >  /* kvm attributes for KVM_S390_VM_CPU_MODEL */
> > -/* processor related attributes are r/w */
> > +/* kvm S390 processor related attributes are r/w */
> >  #define KVM_S390_VM_CPU_PROCESSOR	0
> >  struct kvm_s390_vm_cpu_processor {
> >  	__u64 cpuid;
> > @@ -80,22 +86,16 @@ struct kvm_s390_vm_cpu_processor {
> >  	__u64 fac_list[256];
> >  };
> > 
> > -/* machine related attributes are r/o */
> > +/* kvm S390 machine related attributes are r/o */
> >  #define KVM_S390_VM_CPU_MACHINE		1
> >  struct kvm_s390_vm_cpu_machine {
> >  	__u64 cpuid;
> > -	__u32 ibc;
> > +	__u32 ibc_range;
> >  	__u8  pad[4];
> >  	__u64 fac_mask[256];
> >  	__u64 fac_list[256];
> >  };
> > 
> > -/* kvm attributes for crypto */
> > -#define KVM_S390_VM_CRYPTO_ENABLE_AES_KW	0
> > -#define KVM_S390_VM_CRYPTO_ENABLE_DEA_KW	1
> > -#define KVM_S390_VM_CRYPTO_DISABLE_AES_KW	2
> > -#define KVM_S390_VM_CRYPTO_DISABLE_DEA_KW	3
> > -
> >  /* for KVM_GET_REGS and KVM_SET_REGS */
> >  struct kvm_regs {
> >  	/* general purpose regs for s390 */
> > 
> 

  reply	other threads:[~2015-03-31  7:25 UTC|newest]

Thread overview: 109+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-30 14:28 [PATCH v4 00/15] s390x cpu model implementation Michael Mueller
2015-03-30 14:28 ` [Qemu-devel] " Michael Mueller
2015-03-30 14:28 ` [PATCH v4 01/15] Introduce stub routine cpu_desc_avail Michael Mueller
2015-03-30 14:28   ` [Qemu-devel] " Michael Mueller
2015-03-30 14:28 ` [PATCH v4 02/15] target-s390x: Introduce cpu facilities Michael Mueller
2015-03-30 14:28   ` [Qemu-devel] " Michael Mueller
2015-03-30 14:28   ` Michael Mueller
2015-03-30 14:28 ` [PATCH v4 03/15] target-s390x: Generate facility defines per cpu model Michael Mueller
2015-03-30 14:28   ` [Qemu-devel] " Michael Mueller
2015-03-30 14:28 ` [PATCH v4 04/15] target-s390x: Introduce cpu models Michael Mueller
2015-03-30 14:28   ` [Qemu-devel] " Michael Mueller
2015-03-30 14:28   ` Michael Mueller
2015-03-30 14:28 ` [PATCH v4 05/15] target-s390x: Define cpu model specific facility lists Michael Mueller
2015-03-30 14:28   ` [Qemu-devel] " Michael Mueller
2015-03-30 14:28   ` Michael Mueller
2015-03-30 14:28 ` [PATCH v4 06/15] target-s390x: Add cpu model alias definition routines Michael Mueller
2015-03-30 14:28   ` [Qemu-devel] " Michael Mueller
2015-03-30 14:28 ` [PATCH v4 07/15] target-s390x: Update linux-headers/asm-s390/kvm.h Michael Mueller
2015-03-30 14:28   ` [Qemu-devel] " Michael Mueller
2015-03-30 14:28   ` Michael Mueller
2015-03-30 19:36   ` Christian Borntraeger
2015-03-30 19:36     ` [Qemu-devel] " Christian Borntraeger
2015-03-30 19:36     ` Christian Borntraeger
2015-03-31  7:25     ` Michael Mueller [this message]
2015-03-31  7:25       ` [Qemu-devel] " Michael Mueller
2015-03-30 14:28 ` [PATCH v4 08/15] target-s390x: Add KVM VM attribute interface for cpu models Michael Mueller
2015-03-30 14:28   ` [Qemu-devel] " Michael Mueller
2015-03-30 14:28   ` Michael Mueller
2015-03-30 14:28 ` [PATCH v4 09/15] target-s390x: Add cpu class initialization routines Michael Mueller
2015-03-30 14:28   ` [Qemu-devel] " Michael Mueller
2015-03-30 14:28   ` Michael Mueller
2015-03-30 14:28 ` [PATCH v4 10/15] target-s390x: Prepare accelerator during cpu object realization Michael Mueller
2015-03-30 14:28   ` [Qemu-devel] " Michael Mueller
2015-03-30 19:33   ` Eduardo Habkost
2015-03-30 19:33     ` [Qemu-devel] " Eduardo Habkost
2015-03-31 10:26     ` Michael Mueller
2015-03-31 10:26       ` Michael Mueller
2015-03-30 14:28 ` [PATCH v4 11/15] target-s390x: New QMP command query-cpu-model Michael Mueller
2015-03-30 14:28   ` [Qemu-devel] " Michael Mueller
2015-03-30 19:50   ` Eduardo Habkost
2015-03-30 19:50     ` [Qemu-devel] " Eduardo Habkost
2015-03-31  9:10     ` Michael Mueller
2015-03-31  9:10       ` Michael Mueller
2015-03-30 20:17   ` Eduardo Habkost
2015-03-30 20:17     ` [Qemu-devel] " Eduardo Habkost
2015-03-30 20:17     ` Eduardo Habkost
2015-03-30 20:20     ` Eric Blake
2015-03-30 20:20       ` [Qemu-devel] " Eric Blake
2015-03-30 20:20       ` Eric Blake
2015-03-31 13:16       ` Eduardo Habkost
2015-03-31 13:16         ` Eduardo Habkost
2015-03-31 11:21     ` Michael Mueller
2015-03-31 11:21       ` Michael Mueller
2015-03-31 18:28       ` Eduardo Habkost
2015-03-31 18:28         ` Eduardo Habkost
2015-03-30 20:19   ` Eric Blake
2015-03-30 20:19     ` Eric Blake
2015-03-31  7:56     ` Michael Mueller
2015-03-31  7:56       ` Michael Mueller
2015-03-31  7:56       ` Michael Mueller
2015-03-31 18:35   ` Eduardo Habkost
2015-03-31 18:35     ` [Qemu-devel] " Eduardo Habkost
2015-03-31 20:09     ` Michael Mueller
2015-03-31 20:09       ` [Qemu-devel] " Michael Mueller
2015-03-31 20:09       ` Michael Mueller
2015-04-01 13:01       ` Eduardo Habkost
2015-04-01 13:01         ` [Qemu-devel] " Eduardo Habkost
2015-04-01 16:31         ` Michael Mueller
2015-04-01 16:31           ` Michael Mueller
2015-04-01 16:59           ` Eduardo Habkost
2015-04-01 16:59             ` [Qemu-devel] " Eduardo Habkost
2015-04-01 16:59             ` Eduardo Habkost
2015-04-01 19:05             ` Michael Mueller
2015-04-01 19:05               ` [Qemu-devel] " Michael Mueller
2015-04-01 19:05               ` Michael Mueller
2015-04-01 19:10               ` Michael Mueller
2015-04-01 19:10                 ` Michael Mueller
2015-04-01 23:05               ` Eduardo Habkost
2015-04-01 23:05                 ` [Qemu-devel] " Eduardo Habkost
2015-04-01 23:05                 ` Eduardo Habkost
2015-04-02  7:09                 ` Michael Mueller
2015-04-02  7:09                   ` [Qemu-devel] " Michael Mueller
2015-04-02  7:09                   ` Michael Mueller
2015-04-02 15:15                   ` Eduardo Habkost
2015-04-02 15:15                     ` Eduardo Habkost
2015-03-30 14:28 ` [PATCH v4 12/15] Add optional parameters to QMP command query-cpu-definitions Michael Mueller
2015-03-30 14:28   ` [Qemu-devel] " Michael Mueller
2015-03-30 20:28   ` Eric Blake
2015-03-30 20:28     ` Eric Blake
2015-03-31  7:42     ` Michael Mueller
2015-03-31  7:42       ` Michael Mueller
2015-03-31  7:42       ` Michael Mueller
2015-03-31 19:46   ` Eduardo Habkost
2015-03-31 19:46     ` [Qemu-devel] " Eduardo Habkost
2015-03-31 19:46     ` Eduardo Habkost
2015-03-31 19:50     ` Eric Blake
2015-03-31 19:50       ` [Qemu-devel] " Eric Blake
2015-03-31 19:50       ` Eric Blake
2015-03-31 20:22     ` [Qemu-devel] " Michael Mueller
2015-03-31 20:22       ` Michael Mueller
2015-03-30 14:28 ` [PATCH v4 13/15] target-s390x: Extend " Michael Mueller
2015-03-30 14:28   ` [Qemu-devel] " Michael Mueller
2015-03-30 19:54   ` Eduardo Habkost
2015-03-30 19:54     ` [Qemu-devel] " Eduardo Habkost
2015-03-30 14:28 ` [PATCH v4 14/15] target-s390x: Introduce facility test routine Michael Mueller
2015-03-30 14:28   ` [Qemu-devel] " Michael Mueller
2015-03-30 14:28   ` Michael Mueller
2015-03-30 14:28 ` [PATCH v4 15/15] target-s390x: Enable cpu model usage Michael Mueller
2015-03-30 14:28   ` [Qemu-devel] " Michael Mueller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150331092545.2139b79a@bee \
    --to=mimu@linux.vnet.ibm.com \
    --cc=afaerber@suse.de \
    --cc=agraf@suse.de \
    --cc=borntraeger@de.ibm.com \
    --cc=cornelia.huck@de.ibm.com \
    --cc=daniel.hansel@linux.vnet.ibm.com \
    --cc=ehabkost@redhat.com \
    --cc=gleb@kernel.org \
    --cc=jjherne@linux.vnet.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.