* [PATCH peterz-queue] perf/x86: allocate_excl_cntrs() can be static
2015-03-31 13:32 [peterz-queue:master 2112/2183] arch/x86/kernel/cpu/perf_event_intel.c:2204:25: sparse: symbol 'allocate_excl_cntrs' was not declared. Should it be static? kbuild test robot
@ 2015-03-31 13:32 ` kbuild test robot
0 siblings, 0 replies; 2+ messages in thread
From: kbuild test robot @ 2015-03-31 13:32 UTC (permalink / raw)
To: Maria Dimakopoulou
Cc: kbuild-all, Peter Zijlstra, Paul Mackerras, Ingo Molnar,
Arnaldo Carvalho de Melo, Thomas Gleixner, H. Peter Anvin, x86,
linux-kernel
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
perf_event_intel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/cpu/perf_event_intel.c b/arch/x86/kernel/cpu/perf_event_intel.c
index d7b6eee..8e18f44 100644
--- a/arch/x86/kernel/cpu/perf_event_intel.c
+++ b/arch/x86/kernel/cpu/perf_event_intel.c
@@ -2201,7 +2201,7 @@ struct intel_shared_regs *allocate_shared_regs(int cpu)
return regs;
}
-struct intel_excl_cntrs *allocate_excl_cntrs(int cpu)
+static struct intel_excl_cntrs *allocate_excl_cntrs(int cpu)
{
struct intel_excl_cntrs *c;
int i;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [peterz-queue:master 2112/2183] arch/x86/kernel/cpu/perf_event_intel.c:2204:25: sparse: symbol 'allocate_excl_cntrs' was not declared. Should it be static?
@ 2015-03-31 13:32 kbuild test robot
2015-03-31 13:32 ` [PATCH peterz-queue] perf/x86: allocate_excl_cntrs() can be static kbuild test robot
0 siblings, 1 reply; 2+ messages in thread
From: kbuild test robot @ 2015-03-31 13:32 UTC (permalink / raw)
To: Maria Dimakopoulou
Cc: kbuild-all, Peter Zijlstra, Paul Mackerras, Ingo Molnar,
Arnaldo Carvalho de Melo, Thomas Gleixner, H. Peter Anvin, x86,
linux-kernel
tree: git://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git master
head: dc457a0288847522525701d01c1d43d564d06132
commit: cafb328c12993896509de8309f9874949f64e5a4 [2112/2183] perf/x86: add cross-HT counter exclusion infrastructure
reproduce:
# apt-get install sparse
git checkout cafb328c12993896509de8309f9874949f64e5a4
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
arch/x86/kernel/cpu/perf_event_intel.c:196:18: sparse: symbol 'nhm_events_attrs' was not declared. Should it be static?
arch/x86/kernel/cpu/perf_event_intel.c:201:18: sparse: symbol 'snb_events_attrs' was not declared. Should it be static?
arch/x86/kernel/cpu/perf_event_intel.c:223:25: sparse: symbol 'intel_bdw_event_constraints' was not declared. Should it be static?
>> arch/x86/kernel/cpu/perf_event_intel.c:2204:25: sparse: symbol 'allocate_excl_cntrs' was not declared. Should it be static?
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-31 13:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-31 13:32 [peterz-queue:master 2112/2183] arch/x86/kernel/cpu/perf_event_intel.c:2204:25: sparse: symbol 'allocate_excl_cntrs' was not declared. Should it be static? kbuild test robot
2015-03-31 13:32 ` [PATCH peterz-queue] perf/x86: allocate_excl_cntrs() can be static kbuild test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.