All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Peter Griffin <peter.griffin@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, maxime.coquelin@st.com,
	patrice.chotard@st.com, srinivas.kandagatla@gmail.com,
	lee.jones@linaro.org, devicetree@vger.kernel.org,
	linux-ide@vger.kernel.org
Subject: Re: [PATCH 3/3] ahci: st: st_configure_oob must be called after IP is clocked.
Date: Tue, 31 Mar 2015 11:29:58 -0400	[thread overview]
Message-ID: <20150331152958.GF9974@htj.duckdns.org> (raw)
In-Reply-To: <1427787309-1601-4-git-send-email-peter.griffin@linaro.org>

On Tue, Mar 31, 2015 at 08:35:09AM +0100, Peter Griffin wrote:
> Currently the ahci_st driver will hang the system on probe, as the
> st_configure_oob function does some register writes before the IP
> is clocked. This patch moves the function call to after
> ahci_platform_enable_resources (which enables the IP clock), and
> resolves the hang.
> 
> Addtionally st_ahci_configure_oob should be called in the st_ahci_resume
> function, so we also rectify that ensuring it is also called after
> the IP clock has been enabled.
> 
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> Acked-by: Lee Jones <lee.jones@linaro.org>
> Acked-by: Maxime Coquelin <maxime.coquelin@st.com>

How should this patch be routed?  Should I pick this up and apply to
libata/for-4.1 or should it go together with the other patches?  If
the latter, please feel free to add my acked-by.

Thanks.

-- 
tejun

WARNING: multiple messages have this Message-ID (diff)
From: tj@kernel.org (Tejun Heo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] ahci: st: st_configure_oob must be called after IP is clocked.
Date: Tue, 31 Mar 2015 11:29:58 -0400	[thread overview]
Message-ID: <20150331152958.GF9974@htj.duckdns.org> (raw)
In-Reply-To: <1427787309-1601-4-git-send-email-peter.griffin@linaro.org>

On Tue, Mar 31, 2015 at 08:35:09AM +0100, Peter Griffin wrote:
> Currently the ahci_st driver will hang the system on probe, as the
> st_configure_oob function does some register writes before the IP
> is clocked. This patch moves the function call to after
> ahci_platform_enable_resources (which enables the IP clock), and
> resolves the hang.
> 
> Addtionally st_ahci_configure_oob should be called in the st_ahci_resume
> function, so we also rectify that ensuring it is also called after
> the IP clock has been enabled.
> 
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> Acked-by: Lee Jones <lee.jones@linaro.org>
> Acked-by: Maxime Coquelin <maxime.coquelin@st.com>

How should this patch be routed?  Should I pick this up and apply to
libata/for-4.1 or should it go together with the other patches?  If
the latter, please feel free to add my acked-by.

Thanks.

-- 
tejun

  reply	other threads:[~2015-03-31 15:29 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-31  7:35 [PATCH RESEND 0/3] Enable ahci_st for stih407 and fix hang Peter Griffin
2015-03-31  7:35 ` Peter Griffin
2015-03-31  7:35 ` [PATCH 1/3] ahci: st: Update the ahci_st DT documentation Peter Griffin
2015-03-31  7:35   ` Peter Griffin
2015-03-31  7:35 ` [PATCH 2/3] ARM: DT: STi: STiH407: Add sata DT nodes Peter Griffin
2015-03-31  7:35   ` Peter Griffin
2015-04-30 11:06   ` Maxime Coquelin
2015-04-30 11:06     ` Maxime Coquelin
2015-04-30 11:06     ` Maxime Coquelin
2015-03-31  7:35 ` [PATCH 3/3] ahci: st: st_configure_oob must be called after IP is clocked Peter Griffin
2015-03-31  7:35   ` Peter Griffin
2015-03-31 15:29   ` Tejun Heo [this message]
2015-03-31 15:29     ` Tejun Heo
2015-03-31 15:33     ` Maxime Coquelin
2015-03-31 15:33       ` Maxime Coquelin
2015-03-31 15:33       ` Maxime Coquelin
     [not found]     ` <20150331152958.GF9974-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2015-03-31 15:36       ` Peter Griffin
2015-03-31 15:36         ` Peter Griffin
2015-03-31 15:36         ` Peter Griffin
2015-03-31 15:59         ` Tejun Heo
2015-03-31 15:59           ` Tejun Heo
2015-03-31 17:33           ` Peter Griffin
2015-03-31 17:33             ` Peter Griffin
     [not found]   ` <1427787309-1601-4-git-send-email-peter.griffin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-04-01 16:07     ` Tejun Heo
2015-04-01 16:07       ` Tejun Heo
2015-04-01 16:07       ` Tejun Heo
  -- strict thread matches above, loose matches on Subject: below --
2015-03-02 12:48 [PATCH 0/3] Enable ahci_st for stih407 and fix hang Peter Griffin
2015-03-02 12:48 ` [PATCH 3/3] ahci: st: st_configure_oob must be called after IP is clocked Peter Griffin
2015-03-02 12:48   ` Peter Griffin
2015-03-02 17:03   ` Lee Jones
2015-03-02 17:03     ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150331152958.GF9974@htj.duckdns.org \
    --to=tj@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxime.coquelin@st.com \
    --cc=patrice.chotard@st.com \
    --cc=peter.griffin@linaro.org \
    --cc=srinivas.kandagatla@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.