From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Dmitry Monakhov <dmonakhov@openvz.org>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
axboe@kernel.dk, viro@zeniv.linux.org.uk, dm-devel@redhat.com
Subject: Re: [PATCH 6/7] block/partitions: use block_device name vsprintf helper
Date: Thu, 2 Apr 2015 14:58:24 +0900 [thread overview]
Message-ID: <20150402055824.GA548@swordfish> (raw)
In-Reply-To: <1427817681-4494-7-git-send-email-dmonakhov@openvz.org>
On (03/31/15 20:01), Dmitry Monakhov wrote:
[..]
> if(be32_to_cpu(magic) != SGI_LABEL_MAGIC) {
> - /*printk("Dev %s SGI disklabel: bad magic %08x\n",
> - bdevname(bdev, b), be32_to_cpu(magic));*/
> + /*printk("Dev %pg SGI disklabel: bad magic %08x\n",
> + bdev, be32_to_cpu(magic));*/
>
[..]
> p = label->partitions;
> if (be16_to_cpu(label->magic) != SUN_LABEL_MAGIC) {
> -/* printk(KERN_INFO "Dev %s Sun disklabel: bad magic %04x\n",
> - bdevname(bdev, b), be16_to_cpu(label->magic)); */
> +/* printk(KERN_INFO "Dev %pg Sun disklabel: bad magic %04x\n",
> + bdev, be16_to_cpu(label->magic)); */
> put_dev_sector(sect);
may be entirely remove these commented out printk()-s?
-ss
next prev parent reply other threads:[~2015-04-02 5:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-31 16:01 [RFC] [PATCH 0/7] fs: add blkdev name format specifier Dmitry Monakhov
2015-03-31 16:01 ` Dmitry Monakhov
2015-03-31 16:01 ` [PATCH 1/7] lib/vsprintf: add %*pg " Dmitry Monakhov
2015-03-31 16:01 ` Dmitry Monakhov
2015-03-31 17:06 ` Joe Perches
2015-03-31 17:37 ` Joe Perches
2015-04-01 8:43 ` Dmitry Monakhov
2015-03-31 16:01 ` [PATCH 2/7] fs: use gendisk->disk_name where possible Dmitry Monakhov
2015-03-31 16:01 ` Dmitry Monakhov
2015-03-31 16:01 ` [PATCH 3/7] block: use block_device name vsprintf helper Dmitry Monakhov
2015-03-31 16:01 ` Dmitry Monakhov
2015-03-31 16:01 ` [PATCH 4/7] fs: " Dmitry Monakhov
2015-03-31 16:01 ` Dmitry Monakhov
2015-03-31 16:01 ` [PATCH 5/7] md: " Dmitry Monakhov
2015-03-31 16:01 ` Dmitry Monakhov
2015-03-31 16:01 ` [PATCH 6/7] block/partitions: " Dmitry Monakhov
2015-03-31 16:01 ` Dmitry Monakhov
2015-04-02 5:58 ` Sergey Senozhatsky [this message]
2015-03-31 16:01 ` [PATCH 7/7] drivers: " Dmitry Monakhov
2015-03-31 16:01 ` Dmitry Monakhov
2015-03-31 16:43 ` [RFC] [PATCH 0/7] fs: add blkdev name format specifier Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2015-04-17 8:29 [PATCH 0/7] fs: add blkdev name format specifier v2 Dmitry Monakhov
2015-04-17 8:29 ` [PATCH 6/7] block/partitions: use block_device name vsprintf helper Dmitry Monakhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150402055824.GA548@swordfish \
--to=sergey.senozhatsky.work@gmail.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=dmonakhov@openvz.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.