From: Jens Axboe <axboe@kernel.dk>
To: Dmitry Monakhov <dmonakhov@openvz.org>, linux-kernel@vger.kernel.org
Cc: linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk,
dm-devel@redhat.com
Subject: Re: [RFC] [PATCH 0/7] fs: add blkdev name format specifier
Date: Tue, 31 Mar 2015 10:43:07 -0600 [thread overview]
Message-ID: <551ACE9B.5050608@kernel.dk> (raw)
In-Reply-To: <1427817681-4494-1-git-send-email-dmonakhov@openvz.org>
On 03/31/2015 10:01 AM, Dmitry Monakhov wrote:
> Currently in order to print block_device name one should use blkdev() helper
> which requires temproral buffer of size BDEVNAME_SIZE (32bytes). This is very
> ineffective because result in stack usage bloating for deep IO call traces where
> stack usage is close to maximum values.
>
> It is reasonable to introduce dedicated format specifier for block_device name,
> unfortunately "%pb", "%pB", "%pd" and "%pD" are already reserved for other data types
> I've pick "%pg" ala geometry. If some one want to offer sane spacifier name
> please let me know.
>
> Since this is RFC version I've pick rough patch split policy (based on subsystem).
> Please let me know if patchset should be split in different way.
I think this is looks good, nice improvement. I can take the lib and
block parts, Al can pick up the fs bits.
--
Jens Axboe
prev parent reply other threads:[~2015-03-31 16:43 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-31 16:01 [RFC] [PATCH 0/7] fs: add blkdev name format specifier Dmitry Monakhov
2015-03-31 16:01 ` Dmitry Monakhov
2015-03-31 16:01 ` [PATCH 1/7] lib/vsprintf: add %*pg " Dmitry Monakhov
2015-03-31 16:01 ` Dmitry Monakhov
2015-03-31 17:06 ` Joe Perches
2015-03-31 17:37 ` Joe Perches
2015-04-01 8:43 ` Dmitry Monakhov
2015-03-31 16:01 ` [PATCH 2/7] fs: use gendisk->disk_name where possible Dmitry Monakhov
2015-03-31 16:01 ` Dmitry Monakhov
2015-03-31 16:01 ` [PATCH 3/7] block: use block_device name vsprintf helper Dmitry Monakhov
2015-03-31 16:01 ` Dmitry Monakhov
2015-03-31 16:01 ` [PATCH 4/7] fs: " Dmitry Monakhov
2015-03-31 16:01 ` Dmitry Monakhov
2015-03-31 16:01 ` [PATCH 5/7] md: " Dmitry Monakhov
2015-03-31 16:01 ` Dmitry Monakhov
2015-03-31 16:01 ` [PATCH 6/7] block/partitions: " Dmitry Monakhov
2015-03-31 16:01 ` Dmitry Monakhov
2015-04-02 5:58 ` Sergey Senozhatsky
2015-03-31 16:01 ` [PATCH 7/7] drivers: " Dmitry Monakhov
2015-03-31 16:01 ` Dmitry Monakhov
2015-03-31 16:43 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=551ACE9B.5050608@kernel.dk \
--to=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=dmonakhov@openvz.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.