From: Pavel Machek <pavel@ucw.cz>
To: Grazvydas Ignotas <notasas@gmail.com>
Cc: Pali Rohar <pali.rohar@gmail.com>,
sre@debian.org, sre@ring0.de,
kernel list <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
Tony Lindgren <tony@atomide.com>,
khilman@kernel.org, Aaro Koskinen <aaro.koskinen@iki.fi>,
ivo.g.dimitrov.75@gmail.com, edubezval@gmail.com,
rui.zhang@intel.com, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH] ti-soc-thermal: implement omap3 support
Date: Thu, 2 Apr 2015 16:49:01 +0200 [thread overview]
Message-ID: <20150402144901.GC18125@amd> (raw)
In-Reply-To: <CANOLnOO4J3RQCJZB0ibkGc5KhvPu+Q1f-bwc8mpxKCPRgjw5PQ@mail.gmail.com>
> > +/* Thresholds and limits for OMAP34XX MPU temperature sensor */
> > +static struct temp_sensor_data omap34xx_mpu_temp_sensor_data = {
> > + .min_freq = 32768,
> > + .max_freq = 32768,
> > + .max_temp = -99000,
> > + .min_temp = 99000,
>
> This looks mixed up. Also, perhaps use -40000 to 125000 to match the
> table below?
Yes, that looks reasonable, thanks for review. v2 in minute or so.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
WARNING: multiple messages have this Message-ID (diff)
From: pavel@ucw.cz (Pavel Machek)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ti-soc-thermal: implement omap3 support
Date: Thu, 2 Apr 2015 16:49:01 +0200 [thread overview]
Message-ID: <20150402144901.GC18125@amd> (raw)
In-Reply-To: <CANOLnOO4J3RQCJZB0ibkGc5KhvPu+Q1f-bwc8mpxKCPRgjw5PQ@mail.gmail.com>
> > +/* Thresholds and limits for OMAP34XX MPU temperature sensor */
> > +static struct temp_sensor_data omap34xx_mpu_temp_sensor_data = {
> > + .min_freq = 32768,
> > + .max_freq = 32768,
> > + .max_temp = -99000,
> > + .min_temp = 99000,
>
> This looks mixed up. Also, perhaps use -40000 to 125000 to match the
> table below?
Yes, that looks reasonable, thanks for review. v2 in minute or so.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2015-04-02 14:49 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-03 11:46 [PATCH] ti-soc-thermal: implement eocz bit to make driver useful on omap3 Pavel Machek
2015-01-03 11:46 ` Pavel Machek
2015-01-03 12:26 ` Eduardo Valentin
2015-01-03 12:26 ` Eduardo Valentin
2015-01-03 16:22 ` Pavel Machek
2015-01-03 16:22 ` Pavel Machek
2015-01-05 21:35 ` Eduardo Valentin
2015-01-05 21:35 ` Eduardo Valentin
2015-01-18 20:18 ` Pavel Machek
2015-01-18 20:18 ` Pavel Machek
2015-01-21 5:21 ` Eduardo Valentin
2015-01-21 5:21 ` Eduardo Valentin
2015-01-18 20:20 ` [PATCHv2] " Pavel Machek
2015-01-18 20:20 ` Pavel Machek
2015-01-18 20:24 ` [PATCHv2] ti-soc-thermal: request temperature periodically if hw can't do that itself Pavel Machek
2015-01-18 20:24 ` Pavel Machek
2015-03-24 16:30 ` Eduardo Valentin
2015-03-24 16:30 ` Eduardo Valentin
2015-03-24 22:27 ` Pavel Machek
2015-03-24 22:27 ` Pavel Machek
2015-03-24 22:20 ` [PATCHv3] " Pavel Machek
2015-03-24 22:20 ` Pavel Machek
2015-03-31 8:42 ` [PATCH] ti-soc-thermal: implement omap3 support Pavel Machek
2015-03-31 8:42 ` Pavel Machek
2015-03-31 15:02 ` Grazvydas Ignotas
2015-03-31 15:02 ` Grazvydas Ignotas
2015-03-31 15:02 ` Grazvydas Ignotas
2015-04-02 14:49 ` Pavel Machek [this message]
2015-04-02 14:49 ` Pavel Machek
2015-04-02 14:49 ` [PATCHv2] " Pavel Machek
2015-04-02 14:49 ` Pavel Machek
2015-04-07 18:57 ` Eduardo Valentin
2015-04-07 18:57 ` Eduardo Valentin
2015-04-07 19:09 ` Eduardo Valentin
2015-04-07 19:09 ` Eduardo Valentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150402144901.GC18125@amd \
--to=pavel@ucw.cz \
--cc=aaro.koskinen@iki.fi \
--cc=devicetree@vger.kernel.org \
--cc=edubezval@gmail.com \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=notasas@gmail.com \
--cc=pali.rohar@gmail.com \
--cc=rui.zhang@intel.com \
--cc=sre@debian.org \
--cc=sre@ring0.de \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.