From: Pavel Machek <pavel@ucw.cz>
To: Sakari Ailus <sakari.ailus@iki.fi>
Cc: Andrew Morton <akpm@osdl.org>,
pali.rohar@gmail.com, sre@debian.org, sre@ring0.de,
kernel list <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-omap@vger.kernel.org, tony@atomide.com, khilman@kernel.org,
aaro.koskinen@iki.fi, ivo.g.dimitrov.75@gmail.com,
patrikbachan@gmail.com, galak@codeaurora.org,
bcousson@baylibre.com, m.chehab@samsung.com,
devicetree@vger.kernel.org
Subject: Re: [PATCHv3] media: i2c/adp1653: devicetree support for adp1653
Date: Fri, 3 Apr 2015 10:23:44 +0200 [thread overview]
Message-ID: <20150403082344.GA14721@amd> (raw)
In-Reply-To: <20150402234823.GI20756@valkosipuli.retiisi.org.uk>
Hi!
> Hi Pawel,
I'm still Pavel. v, not w.
> > > Hi Pawel,
> > > A corresponding change to the N900 dts would be very nice.
> >
> > Corresponding change to the dts will come in separate patch. Or do you
> > have n900 for testing?
>
> Yes, it should be a separate patch, I agree.
>
> I do have one but I can't say when I'd have time to test it. I'm fine with
> you having tested it though.
>
> > > I think you're missing change to adp1653_i2c_driver.driver.of_match_table.
> >
> > It actually worked for me, which means device tree somehow does it
> > magic.
>
> By magic? :-) It probably just ends up comparing the device and the driver
> names. How about adding the of_match_table?
I guess it uses adp1653_id_table. I'd hade to add redundand
information, because if it would just mask the errors if the code
changed...
Thanks,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
WARNING: multiple messages have this Message-ID (diff)
From: pavel@ucw.cz (Pavel Machek)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv3] media: i2c/adp1653: devicetree support for adp1653
Date: Fri, 3 Apr 2015 10:23:44 +0200 [thread overview]
Message-ID: <20150403082344.GA14721@amd> (raw)
In-Reply-To: <20150402234823.GI20756@valkosipuli.retiisi.org.uk>
Hi!
> Hi Pawel,
I'm still Pavel. v, not w.
> > > Hi Pawel,
> > > A corresponding change to the N900 dts would be very nice.
> >
> > Corresponding change to the dts will come in separate patch. Or do you
> > have n900 for testing?
>
> Yes, it should be a separate patch, I agree.
>
> I do have one but I can't say when I'd have time to test it. I'm fine with
> you having tested it though.
>
> > > I think you're missing change to adp1653_i2c_driver.driver.of_match_table.
> >
> > It actually worked for me, which means device tree somehow does it
> > magic.
>
> By magic? :-) It probably just ends up comparing the device and the driver
> names. How about adding the of_match_table?
I guess it uses adp1653_id_table. I'd hade to add redundand
information, because if it would just mask the errors if the code
changed...
Thanks,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2015-04-03 8:23 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-02 14:38 [PATCHv3] media: i2c/adp1653: devicetree support for adp1653 Pavel Machek
2015-04-02 14:38 ` Pavel Machek
2015-04-02 16:14 ` Sakari Ailus
2015-04-02 16:14 ` Sakari Ailus
2015-04-02 16:14 ` Sakari Ailus
[not found] ` <20150402161453.GH20756-S+BSfZ9RZZmRSg0ZkenSGLdO1Tsj/99ntUK59QYPAWc@public.gmane.org>
2015-04-02 20:30 ` Pavel Machek
2015-04-02 20:30 ` Pavel Machek
2015-04-02 20:30 ` Pavel Machek
2015-04-02 23:48 ` Sakari Ailus
2015-04-02 23:48 ` Sakari Ailus
2015-04-02 23:48 ` Sakari Ailus
2015-04-03 8:23 ` Pavel Machek [this message]
2015-04-03 8:23 ` Pavel Machek
2015-04-03 11:23 ` Sakari Ailus
2015-04-03 11:23 ` Sakari Ailus
2015-04-03 11:23 ` Sakari Ailus
2015-04-03 20:29 ` Pavel Machek
2015-04-03 20:29 ` Pavel Machek
2015-04-03 21:35 ` Sakari Ailus
2015-04-03 21:35 ` Sakari Ailus
2015-04-02 20:34 ` [PATCHv4] " Pavel Machek
2015-04-02 20:34 ` Pavel Machek
2015-04-02 20:34 ` Pavel Machek
2015-04-02 22:18 ` Javier Martinez Canillas
2015-04-02 22:18 ` Javier Martinez Canillas
[not found] ` <CABxcv=nfg_D9HvXUd4PBFJ5a1XST=PCDEZCjkTtbu_u7cc1+ug-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-04-03 8:21 ` Pavel Machek
2015-04-03 8:21 ` Pavel Machek
2015-04-03 8:21 ` Pavel Machek
2015-04-03 8:49 ` Javier Martinez Canillas
2015-04-03 8:49 ` Javier Martinez Canillas
2015-04-03 14:22 ` Sebastian Reichel
2015-04-03 14:22 ` Sebastian Reichel
2015-04-03 8:33 ` [PATCHv5] " Pavel Machek
2015-04-03 8:33 ` Pavel Machek
2015-04-03 11:32 ` Sakari Ailus
2015-04-03 11:32 ` Sakari Ailus
2015-04-03 20:26 ` [PATCHv6] media: i2c/adp1653: Documentation for " Pavel Machek
2015-04-03 20:26 ` Pavel Machek
2015-04-03 21:36 ` Sakari Ailus
2015-04-03 21:36 ` Sakari Ailus
2015-04-04 7:43 ` Pavel Machek
2015-04-04 7:43 ` Pavel Machek
2015-04-04 10:24 ` Sakari Ailus
2015-04-04 10:24 ` Sakari Ailus
2015-04-04 10:24 ` Sakari Ailus
[not found] ` <20150404102435.GR20756-S+BSfZ9RZZmRSg0ZkenSGLdO1Tsj/99ntUK59QYPAWc@public.gmane.org>
2015-04-04 17:11 ` Pavel Machek
2015-04-04 17:11 ` Pavel Machek
2015-04-04 17:11 ` Pavel Machek
2015-04-04 20:03 ` Sakari Ailus
2015-04-04 20:03 ` Sakari Ailus
2015-04-04 20:03 ` Sakari Ailus
2015-04-09 7:42 ` [PATCHv7] media: i2c/adp1653: Devicetree " Pavel Machek
2015-04-09 7:42 ` Pavel Machek
2015-04-09 9:10 ` Sebastian Reichel
2015-04-09 9:10 ` Sebastian Reichel
2015-04-09 9:10 ` Sebastian Reichel
2015-04-09 11:29 ` Pavel Machek
2015-04-09 11:29 ` Pavel Machek
2015-04-09 12:19 ` Sebastian Reichel
2015-04-09 12:19 ` Sebastian Reichel
2015-04-09 12:19 ` Sebastian Reichel
2015-04-09 12:31 ` [PATCHv7] media: i2c/adp1653: fix includes Pavel Machek
2015-04-09 12:31 ` Pavel Machek
2015-04-09 12:31 ` Pavel Machek
2015-04-09 12:43 ` Javier Martinez Canillas
2015-04-09 12:43 ` Javier Martinez Canillas
2015-04-09 12:59 ` Pali Rohár
2015-04-09 12:59 ` Pali Rohár
2015-04-09 12:59 ` Pali Rohár
2015-04-13 8:32 ` Javier Martinez Canillas
2015-04-13 8:32 ` Javier Martinez Canillas
2015-04-09 21:47 ` [PATCHv7] media: i2c/adp1653: Devicetree support for adp1653 Sakari Ailus
2015-04-09 21:47 ` Sakari Ailus
[not found] ` <20150409214739.GD20756-S+BSfZ9RZZmRSg0ZkenSGLdO1Tsj/99ntUK59QYPAWc@public.gmane.org>
2015-04-13 13:00 ` Pavel Machek
2015-04-13 13:00 ` Pavel Machek
2015-04-13 13:00 ` Pavel Machek
2015-04-03 21:39 ` [PATCHv6] media: i2c/adp1653: Documentation for devicetree " Sakari Ailus
2015-04-03 21:39 ` Sakari Ailus
2015-04-03 21:39 ` Sakari Ailus
[not found] ` <20150403113216.GK20756-S+BSfZ9RZZmRSg0ZkenSGLdO1Tsj/99ntUK59QYPAWc@public.gmane.org>
2015-04-03 21:04 ` [PATCHv5] media: i2c/adp1653: " Pavel Machek
2015-04-03 21:04 ` Pavel Machek
2015-04-03 21:04 ` Pavel Machek
-- strict thread matches above, loose matches on Subject: below --
2014-12-03 21:46 [PATCH] " Pavel Machek
2014-12-24 22:34 ` [PATCHv2] " Pavel Machek
2015-01-04 9:43 ` [PATCHv3] " Pavel Machek
2015-01-04 9:43 ` Pavel Machek
2015-01-18 22:02 ` Pavel Machek
2015-01-18 22:02 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150403082344.GA14721@amd \
--to=pavel@ucw.cz \
--cc=aaro.koskinen@iki.fi \
--cc=akpm@osdl.org \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=pali.rohar@gmail.com \
--cc=patrikbachan@gmail.com \
--cc=sakari.ailus@iki.fi \
--cc=sre@debian.org \
--cc=sre@ring0.de \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.