All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ed Bartosh <ed.bartosh@linux.intel.com>
To: Otavio Salvador <otavio@ossystems.com.br>
Cc: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [wic][PATCH] wic: extended list of paths in find_binary_path
Date: Sun, 5 Apr 2015 00:34:01 +0300	[thread overview]
Message-ID: <20150404213401.GA10453@linux.intel.com> (raw)
In-Reply-To: <CAP9ODKprO_BWYjr4x0w2PXELXrZa6Y4C2=XgKMWXE+ppULZXTQ@mail.gmail.com>

On Sat, Apr 04, 2015 at 03:34:59PM -0300, Otavio Salvador wrote:
> Em 04/04/2015 14:21, "Ed Bartosh" <ed.bartosh@linux.intel.com> escreveu:
> >
> > wic requires tools that are not always possible to find in $PATH.
> > This causes wic to fail with confusing errors like this:
> >  External command 'parted' not found, exiting.
> >    (Please install 'parted' on your host system)
> >
> > Adding ~/bin/, /usr/local/sbin, /usr/local/bin, /usr/sbin, /usr/bin,
> > /sbin and /bin to the list of paths makes find_binary_path to
> > produce more reliable results.
> >
> > [YOCTO #7122]
> >
> > Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
> 
> I think we shouldn't do that. If user wants something to be found the PATH
> environment variable should have them included.
> 
Some users think that this is confusing: https://bugzilla.yoctoproject.org/show_bug.cgi?id=7122
For current implementation of wic it practically means that it must be always run as "PATH=/usr/sbin:$PATH wic" on OpenSUSE systems.

> This also brings one serious error off wic which is it relying on host
> utilities. It should use parted from native sysroot instead otherwise we
> cannot be sure if witch version we will be using.

This makes sense to me. Not sure how easy is to do it as I suspect that not only parted is used this way.

BTW, this approach conflicts with this feature request: https://bugzilla.yoctoproject.org/show_bug.cgi?id=6558
So, should wic rely on system utilities or not?
If it should not then what would you suggest to do with #6558?

--
Regards,
Ed


  reply	other threads:[~2015-04-04 21:34 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-04 17:20 [wic][PATCH] wic: extended list of paths in find_binary_path Ed Bartosh
2015-04-04 18:34 ` Otavio Salvador
2015-04-04 21:34   ` Ed Bartosh [this message]
2015-04-05 19:13     ` Philip Balister
2015-04-06 17:43   ` [wic][PATCH] wic: use native parted Ed Bartosh
2015-04-06 18:20     ` Otavio Salvador
2015-04-05 19:16 ` [wic][PATCH] wic: extended list of paths in find_binary_path Philip Balister
2015-04-06 12:00   ` Otavio Salvador
2015-04-06 14:15     ` Ed Bartosh
2015-04-06 14:28       ` Otavio Salvador
2015-04-07 10:52         ` Ed Bartosh
2015-04-07 11:23           ` Otavio Salvador

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150404213401.GA10453@linux.intel.com \
    --to=ed.bartosh@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=otavio@ossystems.com.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.