Re: [wic][PATCH] wic: extended list of paths in find_binary_path

[Philip Balister <philip@balister.org>]

On 04/04/2015 02:34 PM, Ed Bartosh wrote:
> On Sat, Apr 04, 2015 at 03:34:59PM -0300, Otavio Salvador wrote:
>> Em 04/04/2015 14:21, "Ed Bartosh" <ed.bartosh@linux.intel.com> escreveu:
>>>
>>> wic requires tools that are not always possible to find in $PATH.
>>> This causes wic to fail with confusing errors like this:
>>>  External command 'parted' not found, exiting.
>>>    (Please install 'parted' on your host system)
>>>
>>> Adding ~/bin/, /usr/local/sbin, /usr/local/bin, /usr/sbin, /usr/bin,
>>> /sbin and /bin to the list of paths makes find_binary_path to
>>> produce more reliable results.
>>>
>>> [YOCTO #7122]
>>>
>>> Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
>>
>> I think we shouldn't do that. If user wants something to be found the PATH
>> environment variable should have them included.
>>
> Some users think that this is confusing: https://bugzilla.yoctoproject.org/show_bug.cgi?id=7122
> For current implementation of wic it practically means that it must be always run as "PATH=/usr/sbin:$PATH wic" on OpenSUSE systems.
> 
>> This also brings one serious error off wic which is it relying on host
>> utilities. It should use parted from native sysroot instead otherwise we
>> cannot be sure if witch version we will be using.
> 
> This makes sense to me. Not sure how easy is to do it as I suspect that not only parted is used this way.
> 
> BTW, this approach conflicts with this feature request: https://bugzilla.yoctoproject.org/show_bug.cgi?id=6558
> So, should wic rely on system utilities or not?
> If it should not then what would you suggest to do with #6558?

I added a comment to this. Basically wic is very dependent on data from
the build system. It has no knowledge of packages. If we want to build
images outside the build system from packages/package feeds, that would
be a different tool than wic.

Philip

> 
> --
> Regards,
> Ed
>