From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@fb.com>
Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org, hch@lst.de
Subject: Re: [PATCH 3/7] scsi: add scsi-mq helpers to retrieve pdu and check started state
Date: Sun, 5 Apr 2015 17:39:12 +0200 [thread overview]
Message-ID: <20150405153912.GA28173@lst.de> (raw)
In-Reply-To: <1428076703-31014-4-git-send-email-axboe@fb.com>
On Fri, Apr 03, 2015 at 09:58:19AM -0600, Jens Axboe wrote:
> +static inline void *scsi_mq_scmd_to_pdu(struct scsi_cmnd *scmd)
> +{
> + return blk_mq_rq_to_pdu(scmd->request) + sizeof(*scmd);
> +}
We've already got scsi_cmd_priv to cover this.
> +static inline bool scsi_mq_scmd_started(struct scsi_cmnd *scmd)
> +{
> + return blk_mq_request_started(scmd->request);
> +}
I don't really think we want to expose this functionality, but more
on that in my reply to the mpt2 patch.
next prev parent reply other threads:[~2015-04-05 15:39 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-03 15:58 [PATCH RFC] mpt2/mpt3sas lock reduction for scsi-mq Jens Axboe
2015-04-03 15:58 ` Jens Axboe
2015-04-03 15:58 ` [PATCH 1/7] blk-mq: allow the callback to blk_mq_tag_busy_iter() to stop looping Jens Axboe
2015-04-03 15:58 ` Jens Axboe
2015-04-03 15:58 ` [PATCH 2/7] blk-mq: add helper to iterate all busy tags on all hardware queues Jens Axboe
2015-04-03 15:58 ` Jens Axboe
2015-04-03 15:58 ` [PATCH 3/7] scsi: add scsi-mq helpers to retrieve pdu and check started state Jens Axboe
2015-04-03 15:58 ` Jens Axboe
2015-04-05 15:39 ` Christoph Hellwig [this message]
2015-04-03 15:58 ` [PATCH 4/7] scsi: add scsi-mq helper for iterating over busy commands Jens Axboe
2015-04-03 15:58 ` Jens Axboe
2015-04-05 15:40 ` Christoph Hellwig
2015-04-03 15:58 ` [PATCH 5/7] scsi: add host template init/exit_command hooks Jens Axboe
2015-04-03 15:58 ` Jens Axboe
2015-04-05 15:40 ` Christoph Hellwig
2015-04-03 15:58 ` [PATCH 6/7] mpt2sas: store scsi io tracker data in the scsi command / request Jens Axboe
2015-04-03 15:58 ` Jens Axboe
2015-04-05 16:03 ` Christoph Hellwig
2015-04-07 16:13 ` Jens Axboe
2015-04-07 16:18 ` Christoph Hellwig
2015-04-07 19:22 ` Jens Axboe
2015-04-03 15:58 ` [PATCH 7/7] mpt3sas: " Jens Axboe
2015-04-03 15:58 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150405153912.GA28173@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.