From: jason@lakedaemon.net (Jason Cooper)
To: linux-arm-kernel@lists.infradead.org
Subject: irqchip heirarchy DT "break" series awareness?
Date: Mon, 6 Apr 2015 14:46:47 +0000 [thread overview]
Message-ID: <20150406144647.GC7873@io.lakedaemon.net> (raw)
Arnd, Olof, others,
Have you been following Marc's irqchip series(es) leveraging stacked
domains to remove the abuse of gic_arch_extn ?
Tegra LIC
https://lkml.kernel.org/r/1426088583-15097-1-git-send-email-marc.zyngier at arm.com
OMAP Crossbar
https://lkml.kernel.org/r/1426088629-15377-1-git-send-email-marc.zyngier at arm.com
Exynos PM
https://lkml.kernel.org/r/1426088693-15724-1-git-send-email-marc.zyngier at arm.com
shmobile, ux500, zynq irq_set_wake
https://lkml.kernel.org/r/1426088737-15817-1-git-send-email-marc.zyngier at arm.com
imx6 was taken by Shawn
https://lkml.kernel.org/r/1426262737-32762-1-git-send-email-marc.zyngier at arm.com
You can find the patches in one series per branch at:
git://git.infradead.org/users/jcooper/linux.git irqchip/stacked-tegra
git://git.infradead.org/users/jcooper/linux.git irqchip/stacked-omap
git://git.infradead.org/users/jcooper/linux.git irqchip/stacked-exynos
git://git.infradead.org/users/jcooper/linux.git irqchip/stacked-irq_set_wake
I ask because with Thomas' (tglx) absence, it looks like I'm going to be
sending the pull request directly to Linus. This has increased my
pucker factor a bit. :-)
The logistical stuff is in order. It'll be my second pull request, and
it'll only contain the changes relevant. The whole set has gone through
several rounds of review. All the arm sub-arch maintainers have either
taken the part relevant to them, Acked me taking them, or failed to
object while they've been in linux-next for several weeks now.
My concern is the DT ABI stability problem. In short, we fucked up.
When we added several of the irqchip bindings, we designed them based on
the Linux implementation (gic_arch_extn). *Not* by describing the
hardware.
Marc's series undoes this in the best way possible. He changes the DT
bindings to actually describe the hardware, which then gets modeled in
stacked domains quite well.
This causes two problems:
1) Upgrade kernel, but not DTB.
System will boot, and print a big fat warning that
suspend/resume will not work until the DTB is upgraded.
2) Upgrade DTB, but not kernel.
System will fail to boot.
In light of Thomas Petazonni's well-researched talk at ELC:
"The Device Tree as a stable ABI: a fairy tale?"
http://events.linuxfoundation.org/sites/events/files/slides/petazzoni-dt-as-stable-abi-fairy-tale.pdf
I'm confident that #2 won't be an issue. Distro's and OEMs seem to have
worked around the instability by keeping the dtb tied to the kernel
version.
And, on the off chance that end users upgrade their kernel, say, by
building mainline, there's a very clear warning that tells them exactly
what to do: Upgrade the dtb as well.
Do you foresee any problem with this? Is there anything I haven't
considered? Or extra information I'll need to present in my pull
request?
thx,
Jason.
WARNING: multiple messages have this Message-ID (diff)
From: Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>
To: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>,
arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Cc: Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
Marc Zyngier <marc.zyngier-5wv7dgnIgG8@public.gmane.org>,
Linux ARM Kernel
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: irqchip heirarchy DT "break" series awareness?
Date: Mon, 6 Apr 2015 14:46:47 +0000 [thread overview]
Message-ID: <20150406144647.GC7873@io.lakedaemon.net> (raw)
Arnd, Olof, others,
Have you been following Marc's irqchip series(es) leveraging stacked
domains to remove the abuse of gic_arch_extn ?
Tegra LIC
https://lkml.kernel.org/r/1426088583-15097-1-git-send-email-marc.zyngier-5wv7dgnIgG8@public.gmane.org
OMAP Crossbar
https://lkml.kernel.org/r/1426088629-15377-1-git-send-email-marc.zyngier-5wv7dgnIgG8@public.gmane.org
Exynos PM
https://lkml.kernel.org/r/1426088693-15724-1-git-send-email-marc.zyngier-5wv7dgnIgG8@public.gmane.org
shmobile, ux500, zynq irq_set_wake
https://lkml.kernel.org/r/1426088737-15817-1-git-send-email-marc.zyngier-5wv7dgnIgG8@public.gmane.org
imx6 was taken by Shawn
https://lkml.kernel.org/r/1426262737-32762-1-git-send-email-marc.zyngier-5wv7dgnIgG8@public.gmane.org
You can find the patches in one series per branch at:
git://git.infradead.org/users/jcooper/linux.git irqchip/stacked-tegra
git://git.infradead.org/users/jcooper/linux.git irqchip/stacked-omap
git://git.infradead.org/users/jcooper/linux.git irqchip/stacked-exynos
git://git.infradead.org/users/jcooper/linux.git irqchip/stacked-irq_set_wake
I ask because with Thomas' (tglx) absence, it looks like I'm going to be
sending the pull request directly to Linus. This has increased my
pucker factor a bit. :-)
The logistical stuff is in order. It'll be my second pull request, and
it'll only contain the changes relevant. The whole set has gone through
several rounds of review. All the arm sub-arch maintainers have either
taken the part relevant to them, Acked me taking them, or failed to
object while they've been in linux-next for several weeks now.
My concern is the DT ABI stability problem. In short, we fucked up.
When we added several of the irqchip bindings, we designed them based on
the Linux implementation (gic_arch_extn). *Not* by describing the
hardware.
Marc's series undoes this in the best way possible. He changes the DT
bindings to actually describe the hardware, which then gets modeled in
stacked domains quite well.
This causes two problems:
1) Upgrade kernel, but not DTB.
System will boot, and print a big fat warning that
suspend/resume will not work until the DTB is upgraded.
2) Upgrade DTB, but not kernel.
System will fail to boot.
In light of Thomas Petazonni's well-researched talk at ELC:
"The Device Tree as a stable ABI: a fairy tale?"
http://events.linuxfoundation.org/sites/events/files/slides/petazzoni-dt-as-stable-abi-fairy-tale.pdf
I'm confident that #2 won't be an issue. Distro's and OEMs seem to have
worked around the instability by keeping the dtb tied to the kernel
version.
And, on the off chance that end users upgrade their kernel, say, by
building mainline, there's a very clear warning that tells them exactly
what to do: Upgrade the dtb as well.
Do you foresee any problem with this? Is there anything I haven't
considered? Or extra information I'll need to present in my pull
request?
thx,
Jason.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2015-04-06 14:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-06 14:46 Jason Cooper [this message]
2015-04-06 14:46 ` irqchip heirarchy DT "break" series awareness? Jason Cooper
2015-04-07 9:59 ` Thomas Petazzoni
2015-04-07 9:59 ` Thomas Petazzoni
2015-04-07 10:21 ` Marc Zyngier
2015-04-07 10:21 ` Marc Zyngier
2015-04-07 13:06 ` Jason Cooper
2015-04-07 13:06 ` Jason Cooper
2015-04-07 13:37 ` Mark Rutland
2015-04-07 13:37 ` Mark Rutland
2015-04-07 12:40 ` Jason Cooper
2015-04-07 12:40 ` Jason Cooper
2015-04-07 12:49 ` Thomas Petazzoni
2015-04-07 12:49 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150406144647.GC7873@io.lakedaemon.net \
--to=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.