All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrei Borzenkov <arvidjaar@gmail.com>
To: Michael Zimmermann <sigmaepsilon92@gmail.com>
Cc: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [PATCH] configure.ac: support -fdiagnostics-color=always
Date: Mon, 6 Apr 2015 21:24:26 +0300	[thread overview]
Message-ID: <20150406212426.6628bcf9@opensuse.site> (raw)
In-Reply-To: <CAN9vWDJZO0jx0aZCB+9RCrMdAq==jbdJeK-HXLgMokO_mJJ90A@mail.gmail.com>

В Mon, 6 Apr 2015 19:33:30 +0200
Michael Zimmermann <sigmaepsilon92@gmail.com> пишет:

> ---
>  configure.ac | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/configure.ac b/configure.ac
> index 891c14f..1f8cb2c 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1046,6 +1046,15 @@ if test "x$grub_cv_target_cc_qn" = xyes; then
>    TARGET_CFLAGS="$TARGET_CFLAGS -Qn"
>  fi
> 
> +AC_CACHE_CHECK([whether option -fdiagnostics-color=always works],
> grub_cv_target_cc_fdiagnostics_color, [
> +  CFLAGS="$TARGET_CFLAGS -fdiagnostics-color=always -Werror"
> +  AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[]], [[]])],
> +                   [grub_cv_target_cc_fdiagnostics_color=yes],
> +                   [grub_cv_target_cc_fdiagnostics_color=no])])
> +if test "x$grub_cv_target_cc_fdiagnostics_color" = xyes; then
> +  TARGET_CFLAGS="$TARGET_CFLAGS -fdiagnostics-color=always"
> +fi
> +
>  #
>  # Compiler features.
>  #

I think it should be left to distribution/user. You can always run

./configure TARGET_CFLAGS="-Os -fdiagnostic-color=always"


  reply	other threads:[~2015-04-06 18:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-06 17:33 [PATCH] configure.ac: support -fdiagnostics-color=always Michael Zimmermann
2015-04-06 18:24 ` Andrei Borzenkov [this message]
2015-04-07 15:54   ` Lennart Sorensen
2015-04-24 15:40   ` Vladimir 'φ-coder/phcoder' Serbinenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150406212426.6628bcf9@opensuse.site \
    --to=arvidjaar@gmail.com \
    --cc=grub-devel@gnu.org \
    --cc=sigmaepsilon92@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.