From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [PATCH] configure.ac: support -fdiagnostics-color=always
Date: Fri, 24 Apr 2015 17:40:29 +0200 [thread overview]
Message-ID: <553A63ED.7040702@gmail.com> (raw)
In-Reply-To: <20150406212426.6628bcf9@opensuse.site>
[-- Attachment #1: Type: text/plain, Size: 1413 bytes --]
On 06.04.2015 20:24, Andrei Borzenkov wrote:
> В Mon, 6 Apr 2015 19:33:30 +0200
> Michael Zimmermann <sigmaepsilon92@gmail.com> пишет:
>
>> ---
>> configure.ac | 9 +++++++++
>> 1 file changed, 9 insertions(+)
>>
>> diff --git a/configure.ac b/configure.ac
>> index 891c14f..1f8cb2c 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -1046,6 +1046,15 @@ if test "x$grub_cv_target_cc_qn" = xyes; then
>> TARGET_CFLAGS="$TARGET_CFLAGS -Qn"
>> fi
>>
>> +AC_CACHE_CHECK([whether option -fdiagnostics-color=always works],
>> grub_cv_target_cc_fdiagnostics_color, [
>> + CFLAGS="$TARGET_CFLAGS -fdiagnostics-color=always -Werror"
>> + AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[]], [[]])],
>> + [grub_cv_target_cc_fdiagnostics_color=yes],
>> + [grub_cv_target_cc_fdiagnostics_color=no])])
>> +if test "x$grub_cv_target_cc_fdiagnostics_color" = xyes; then
>> + TARGET_CFLAGS="$TARGET_CFLAGS -fdiagnostics-color=always"
>> +fi
>> +
>> #
>> # Compiler features.
>> #
>
> I think it should be left to distribution/user. You can always run
>
> ./configure TARGET_CFLAGS="-Os -fdiagnostic-color=always"
>
Agreed. Especially given that stdout isn't necessarily a terminal.
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 213 bytes --]
prev parent reply other threads:[~2015-04-24 15:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-06 17:33 [PATCH] configure.ac: support -fdiagnostics-color=always Michael Zimmermann
2015-04-06 18:24 ` Andrei Borzenkov
2015-04-07 15:54 ` Lennart Sorensen
2015-04-24 15:40 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=553A63ED.7040702@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.