From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/5] MFD/OF: document MFD devices and handle simple-mfd
Date: Tue, 7 Apr 2015 08:16:18 +0100 [thread overview]
Message-ID: <20150407071618.GE3461@x1> (raw)
In-Reply-To: <CAOesGMhz6WPweQFXfPhTO6Pz5L4Z1Si6YGiCRCiFD9B5qB9tVw@mail.gmail.com>
On Fri, 03 Apr 2015, Olof Johansson wrote:
> Hi,
>
> I understand this is bikeshedding to some extent, but I'd also like to
> avoid needless variation in binding formats:
>
> On Tue, Mar 3, 2015 at 1:32 AM, Linus Walleij <linus.walleij@linaro.org> wrote:
>
> > +
> > +foo at 1000 {
> > + compatible = "syscon", "simple-mfd";
> > + reg = <0x010000 0x1000>;
> > +
> > + led at 08.0 {
>
> This doesn't seem to be a typo, you're using a period in the unit
> address. I've never seen that done before, usually commas are used
> instead.
>
> Was there a reason for going with period?
LEDs have always done it [1]. I guess Bryan would be the best person
to answer the 'why'.
git grep "led.*@[0-9]*[.,][0-9]*" -- Documentation/devicetree/ arch/arm/boot/dts/
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
Cc: Linus Walleij
<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
Bryan Wu <cooloney-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Catalin Marinas <catalin.marinas-5wv7dgnIgG8@public.gmane.org>,
Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>,
Richard Purdie <rpurdie-Fm38FmjxZ/leoWH0uzbU5w@public.gmane.org>,
Devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Benjamin Herrenschmidt
<benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>,
Grant Likely
<grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Subject: Re: [PATCH 1/5] MFD/OF: document MFD devices and handle simple-mfd
Date: Tue, 7 Apr 2015 08:16:18 +0100 [thread overview]
Message-ID: <20150407071618.GE3461@x1> (raw)
In-Reply-To: <CAOesGMhz6WPweQFXfPhTO6Pz5L4Z1Si6YGiCRCiFD9B5qB9tVw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Fri, 03 Apr 2015, Olof Johansson wrote:
> Hi,
>
> I understand this is bikeshedding to some extent, but I'd also like to
> avoid needless variation in binding formats:
>
> On Tue, Mar 3, 2015 at 1:32 AM, Linus Walleij <linus.walleij@linaro.org> wrote:
>
> > +
> > +foo@1000 {
> > + compatible = "syscon", "simple-mfd";
> > + reg = <0x010000 0x1000>;
> > +
> > + led@08.0 {
>
> This doesn't seem to be a typo, you're using a period in the unit
> address. I've never seen that done before, usually commas are used
> instead.
>
> Was there a reason for going with period?
LEDs have always done it [1]. I guess Bryan would be the best person
to answer the 'why'.
git grep "led.*@[0-9]*[.,][0-9]*" -- Documentation/devicetree/ arch/arm/boot/dts/
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-04-07 7:16 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 9:32 [PATCH 0/5] simple-mfd and syscon LEDs Linus Walleij
2015-03-03 9:32 ` [PATCH 1/5] MFD/OF: document MFD devices and handle simple-mfd Linus Walleij
2015-03-03 9:32 ` Linus Walleij
2015-03-03 10:25 ` Lee Jones
2015-03-03 10:25 ` Lee Jones
2015-03-09 14:29 ` Linus Walleij
2015-03-09 14:29 ` Linus Walleij
2015-03-03 17:47 ` Rob Herring
2015-03-03 17:47 ` Rob Herring
2015-03-03 17:56 ` Lee Jones
2015-03-03 17:56 ` Lee Jones
2015-03-09 14:35 ` Linus Walleij
2015-03-09 14:35 ` Linus Walleij
2015-03-12 9:14 ` Alexandre Belloni
2015-03-12 9:14 ` Alexandre Belloni
2015-03-17 10:28 ` Linus Walleij
2015-03-17 10:28 ` Linus Walleij
2015-03-17 10:38 ` Linus Walleij
2015-03-17 10:38 ` Linus Walleij
2015-03-18 16:06 ` Alexandre Belloni
2015-03-18 16:06 ` Alexandre Belloni
2015-03-20 13:26 ` Antoine Tenart
2015-03-20 13:26 ` Antoine Tenart
2015-03-28 13:41 ` Grant Likely
2015-03-28 13:41 ` Grant Likely
2015-04-07 9:03 ` Linus Walleij
2015-04-07 9:03 ` Linus Walleij
2015-04-03 18:34 ` Olof Johansson
2015-04-03 18:34 ` Olof Johansson
2015-04-07 7:16 ` Lee Jones [this message]
2015-04-07 7:16 ` Lee Jones
2015-04-07 9:00 ` Linus Walleij
2015-04-07 9:00 ` Linus Walleij
2015-03-03 9:32 ` [PATCH 2/5] ARM: dts: update syscons to use simple-mfd Linus Walleij
2015-03-03 9:32 ` [PATCH 3/5] leds: syscon: instantiate from platform device Linus Walleij
2015-03-17 10:36 ` Linus Walleij
2015-03-24 16:50 ` Bjorn Andersson
2015-03-03 9:32 ` [PATCH 4/5] arm64: juno: Add APB registers and LEDs using syscon Linus Walleij
2015-03-04 15:57 ` Liviu Dudau
2015-03-03 9:32 ` [PATCH 5/5] arm64: add LEDs and some trigger support to defconfig Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150407071618.GE3461@x1 \
--to=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.