From: Johan Hovold <johan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Alan Stern <stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org>
Cc: Johan Hovold <johan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Greg Kroah-Hartman
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
Thierry Reding
<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Alexandre Courbot
<gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
stable <stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 2/2] USB: ehci-tegra: fix inefficient copy of unaligned buffers
Date: Tue, 7 Apr 2015 21:59:32 +0200 [thread overview]
Message-ID: <20150407195932.GB12027@localhost> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1504071127210.1430-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
On Tue, Apr 07, 2015 at 11:30:15AM -0400, Alan Stern wrote:
> On Tue, 7 Apr 2015, Johan Hovold wrote:
>
> > Make sure only to copy any actual data rather than the whole buffer,
> > when releasing the temporary buffer used for unaligned transfer buffers.
> >
> > Note that the corresponding fix of musb also fixes a lockup on
> > disconnect, where repeated failed transfers would starve the hub
> > workqueue from processing the disconnect, which would have prevented the
> > urbs from being resubmitted. In this case there is no data to forward,
> > but the full buffer length was being copied nonetheless.
>
> This is wrong for isochronous transfers, because the transfer data
> generally isn't contiguous in memory.
>
> It would be okay to do this for other transfer types, though.
Thanks for pointing that out. I'll re-spin the series tomorrow.
Johan
WARNING: multiple messages have this Message-ID (diff)
From: Johan Hovold <johan@kernel.org>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Johan Hovold <johan@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Felipe Balbi <balbi@ti.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Stephen Warren <swarren@wwwdotorg.org>,
Thierry Reding <thierry.reding@gmail.com>,
Alexandre Courbot <gnurou@gmail.com>,
linux-tegra@vger.kernel.org, stable <stable@vger.kernel.org>
Subject: Re: [PATCH 2/2] USB: ehci-tegra: fix inefficient copy of unaligned buffers
Date: Tue, 7 Apr 2015 21:59:32 +0200 [thread overview]
Message-ID: <20150407195932.GB12027@localhost> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1504071127210.1430-100000@iolanthe.rowland.org>
On Tue, Apr 07, 2015 at 11:30:15AM -0400, Alan Stern wrote:
> On Tue, 7 Apr 2015, Johan Hovold wrote:
>
> > Make sure only to copy any actual data rather than the whole buffer,
> > when releasing the temporary buffer used for unaligned transfer buffers.
> >
> > Note that the corresponding fix of musb also fixes a lockup on
> > disconnect, where repeated failed transfers would starve the hub
> > workqueue from processing the disconnect, which would have prevented the
> > urbs from being resubmitted. In this case there is no data to forward,
> > but the full buffer length was being copied nonetheless.
>
> This is wrong for isochronous transfers, because the transfer data
> generally isn't contiguous in memory.
>
> It would be okay to do this for other transfer types, though.
Thanks for pointing that out. I'll re-spin the series tomorrow.
Johan
next prev parent reply other threads:[~2015-04-07 19:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-07 9:46 [PATCH 0/2] USB: fix lockup on disconnect Johan Hovold
2015-04-07 9:46 ` Johan Hovold
[not found] ` <1428400012-7563-1-git-send-email-johan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2015-04-07 9:46 ` [PATCH 1/2] USB: musb: fix inefficient copy of unaligned buffers Johan Hovold
2015-04-07 9:46 ` Johan Hovold
2015-04-07 9:46 ` [PATCH 2/2] USB: ehci-tegra: " Johan Hovold
2015-04-07 9:46 ` Johan Hovold
2015-04-07 15:30 ` Alan Stern
2015-04-07 15:30 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.1504071127210.1430-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2015-04-07 19:59 ` Johan Hovold [this message]
2015-04-07 19:59 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150407195932.GB12027@localhost \
--to=johan-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=balbi-l0cyMroinI0@public.gmane.org \
--cc=gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.