* [PATCH] of/PCI: Add IORESOURCE_MEM_64 for 64-bit resource
@ 2015-04-08 0:24 Yinghai Lu
2015-04-08 1:30 ` Rob Herring
0 siblings, 1 reply; 4+ messages in thread
From: Yinghai Lu @ 2015-04-08 0:24 UTC (permalink / raw)
To: Bjorn Helgaas
Cc: linux-pci, Yinghai Lu, Grant Likely, Rob Herring, devicetree
For device resource PREF bit setting under bridge 64-bit pref resource,
we need to make sure only set PREF for 64bit resource, so set IORESOUCE_MEM_64
for 64bit resource during of device resource flags parsing.
Link: https://bugzilla.kernel.org/show_bug.cgi?id=96261
Link: https://bugzilla.kernel.org/show_bug.cgi?id=96241
Signed-off-by: Yinghai Lu <yinghai@kernel.org>
Cc: Grant Likely <grant.likely@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: devicetree@vger.kernel.org
---
drivers/of/address.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
Index: linux-2.6/drivers/of/address.c
===================================================================
--- linux-2.6.orig/drivers/of/address.c
+++ linux-2.6/drivers/of/address.c
@@ -128,9 +128,11 @@ static unsigned int of_bus_pci_get_flags
flags |= IORESOURCE_IO;
break;
case 0x02: /* 32 bits */
- case 0x03: /* 64 bits */
flags |= IORESOURCE_MEM;
break;
+ case 0x03: /* 64 bits */
+ flags |= IORESOURCE_MEM | IORESOURCE_MEM_64;
+ break;
}
if (w & 0x40000000)
flags |= IORESOURCE_PREFETCH;
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] of/PCI: Add IORESOURCE_MEM_64 for 64-bit resource
@ 2015-04-08 1:30 ` Rob Herring
0 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2015-04-08 1:30 UTC (permalink / raw)
To: Yinghai Lu
Cc: Bjorn Helgaas, linux-pci@vger.kernel.org, Grant Likely,
Rob Herring, devicetree@vger.kernel.org
On Tue, Apr 7, 2015 at 7:24 PM, Yinghai Lu <yinghai@kernel.org> wrote:
> For device resource PREF bit setting under bridge 64-bit pref resource,
> we need to make sure only set PREF for 64bit resource, so set IORESOUCE_MEM_64
> for 64bit resource during of device resource flags parsing.
>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=96261
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=96241
> Signed-off-by: Yinghai Lu <yinghai@kernel.org>
> Cc: Grant Likely <grant.likely@linaro.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: devicetree@vger.kernel.org
Acked-by: Rob Herring <robh@kernel.org>
Bjorn, are you collecting these or should I apply?
Rob
> ---
> drivers/of/address.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> Index: linux-2.6/drivers/of/address.c
> ===================================================================
> --- linux-2.6.orig/drivers/of/address.c
> +++ linux-2.6/drivers/of/address.c
> @@ -128,9 +128,11 @@ static unsigned int of_bus_pci_get_flags
> flags |= IORESOURCE_IO;
> break;
> case 0x02: /* 32 bits */
> - case 0x03: /* 64 bits */
> flags |= IORESOURCE_MEM;
> break;
> + case 0x03: /* 64 bits */
> + flags |= IORESOURCE_MEM | IORESOURCE_MEM_64;
> + break;
> }
> if (w & 0x40000000)
> flags |= IORESOURCE_PREFETCH;
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] of/PCI: Add IORESOURCE_MEM_64 for 64-bit resource
@ 2015-04-08 1:30 ` Rob Herring
0 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2015-04-08 1:30 UTC (permalink / raw)
To: Yinghai Lu
Cc: Bjorn Helgaas, linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Grant Likely, Rob Herring,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
On Tue, Apr 7, 2015 at 7:24 PM, Yinghai Lu <yinghai-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> For device resource PREF bit setting under bridge 64-bit pref resource,
> we need to make sure only set PREF for 64bit resource, so set IORESOUCE_MEM_64
> for 64bit resource during of device resource flags parsing.
>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=96261
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=96241
> Signed-off-by: Yinghai Lu <yinghai-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> Cc: Grant Likely <grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Bjorn, are you collecting these or should I apply?
Rob
> ---
> drivers/of/address.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> Index: linux-2.6/drivers/of/address.c
> ===================================================================
> --- linux-2.6.orig/drivers/of/address.c
> +++ linux-2.6/drivers/of/address.c
> @@ -128,9 +128,11 @@ static unsigned int of_bus_pci_get_flags
> flags |= IORESOURCE_IO;
> break;
> case 0x02: /* 32 bits */
> - case 0x03: /* 64 bits */
> flags |= IORESOURCE_MEM;
> break;
> + case 0x03: /* 64 bits */
> + flags |= IORESOURCE_MEM | IORESOURCE_MEM_64;
> + break;
> }
> if (w & 0x40000000)
> flags |= IORESOURCE_PREFETCH;
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] of/PCI: Add IORESOURCE_MEM_64 for 64-bit resource
2015-04-08 1:30 ` Rob Herring
(?)
@ 2015-04-08 15:33 ` Bjorn Helgaas
-1 siblings, 0 replies; 4+ messages in thread
From: Bjorn Helgaas @ 2015-04-08 15:33 UTC (permalink / raw)
To: Rob Herring
Cc: Yinghai Lu, linux-pci@vger.kernel.org, Grant Likely, Rob Herring,
devicetree@vger.kernel.org
On Tue, Apr 07, 2015 at 08:30:58PM -0500, Rob Herring wrote:
> On Tue, Apr 7, 2015 at 7:24 PM, Yinghai Lu <yinghai@kernel.org> wrote:
> > For device resource PREF bit setting under bridge 64-bit pref resource,
> > we need to make sure only set PREF for 64bit resource, so set IORESOUCE_MEM_64
> > for 64bit resource during of device resource flags parsing.
> >
> > Link: https://bugzilla.kernel.org/show_bug.cgi?id=96261
> > Link: https://bugzilla.kernel.org/show_bug.cgi?id=96241
> > Signed-off-by: Yinghai Lu <yinghai@kernel.org>
> > Cc: Grant Likely <grant.likely@linaro.org>
> > Cc: Rob Herring <robh+dt@kernel.org>
> > Cc: devicetree@vger.kernel.org
>
> Acked-by: Rob Herring <robh@kernel.org>
>
> Bjorn, are you collecting these or should I apply?
I am not collecting them, at least not yet. These seem a little more on
the OF side of the fence than PCI. They are a little intertwingled with
the sparc PCI bridge window issue, and Ben has some concerns, so maybe
we'll have to figure out what makes the most sense when that gets sorted
out.
I'm still curious whether all these functions can be consolidated. If
that's possible, it would be much nicer than having to fix all the copies.
Bjorn
> > ---
> > drivers/of/address.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > Index: linux-2.6/drivers/of/address.c
> > ===================================================================
> > --- linux-2.6.orig/drivers/of/address.c
> > +++ linux-2.6/drivers/of/address.c
> > @@ -128,9 +128,11 @@ static unsigned int of_bus_pci_get_flags
> > flags |= IORESOURCE_IO;
> > break;
> > case 0x02: /* 32 bits */
> > - case 0x03: /* 64 bits */
> > flags |= IORESOURCE_MEM;
> > break;
> > + case 0x03: /* 64 bits */
> > + flags |= IORESOURCE_MEM | IORESOURCE_MEM_64;
> > + break;
> > }
> > if (w & 0x40000000)
> > flags |= IORESOURCE_PREFETCH;
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-04-08 15:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-08 0:24 [PATCH] of/PCI: Add IORESOURCE_MEM_64 for 64-bit resource Yinghai Lu
2015-04-08 1:30 ` Rob Herring
2015-04-08 1:30 ` Rob Herring
2015-04-08 15:33 ` Bjorn Helgaas
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.