* [PATCH] pci: pci-exynos: fixed the sentence error
@ 2015-03-25 5:13 Jaehoon Chung
2015-03-25 9:44 ` Liviu Dudau
2015-04-08 19:33 ` Bjorn Helgaas
0 siblings, 2 replies; 4+ messages in thread
From: Jaehoon Chung @ 2015-03-25 5:13 UTC (permalink / raw)
To: linux-pci; +Cc: Jingoo Han, Bjorn Helgaas, Liviu.Dudau, cpgs, Jaehoon Chung
There is the sentence error.
Changed the semicolon instead of comma.
Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
---
drivers/pci/host/pci-exynos.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/host/pci-exynos.c b/drivers/pci/host/pci-exynos.c
index d202b37..c139237 100644
--- a/drivers/pci/host/pci-exynos.c
+++ b/drivers/pci/host/pci-exynos.c
@@ -396,7 +396,7 @@ static void exynos_pcie_enable_irq_pulse(struct pcie_port *pp)
/* enable INTX interrupt */
val = IRQ_INTA_ASSERT | IRQ_INTB_ASSERT |
- IRQ_INTC_ASSERT | IRQ_INTD_ASSERT,
+ IRQ_INTC_ASSERT | IRQ_INTD_ASSERT;
exynos_elb_writel(exynos_pcie, val, PCIE_IRQ_EN_PULSE);
}
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] pci: pci-exynos: fixed the sentence error
2015-03-25 5:13 [PATCH] pci: pci-exynos: fixed the sentence error Jaehoon Chung
@ 2015-03-25 9:44 ` Liviu Dudau
2015-03-25 10:12 ` Jaehoon Chung
2015-04-08 19:33 ` Bjorn Helgaas
1 sibling, 1 reply; 4+ messages in thread
From: Liviu Dudau @ 2015-03-25 9:44 UTC (permalink / raw)
To: Jaehoon Chung
Cc: linux-pci@vger.kernel.org, Jingoo Han, Bjorn Helgaas,
cpgs@samsung.com
On Wed, Mar 25, 2015 at 05:13:12AM +0000, Jaehoon Chung wrote:
> There is the sentence error.
> Changed the semicolon instead of comma.
>
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> ---
> drivers/pci/host/pci-exynos.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/host/pci-exynos.c b/drivers/pci/host/pci-exynos.c
> index d202b37..c139237 100644
> --- a/drivers/pci/host/pci-exynos.c
> +++ b/drivers/pci/host/pci-exynos.c
> @@ -396,7 +396,7 @@ static void exynos_pcie_enable_irq_pulse(struct pcie_port *pp)
>
> /* enable INTX interrupt */
> val = IRQ_INTA_ASSERT | IRQ_INTB_ASSERT |
> - IRQ_INTC_ASSERT | IRQ_INTD_ASSERT,
> + IRQ_INTC_ASSERT | IRQ_INTD_ASSERT;
> exynos_elb_writel(exynos_pcie, val, PCIE_IRQ_EN_PULSE);
> }
Well spotted. The original change dates from July 2013, I'm guessing no one uses
PCIe on Exynos?
Best regards,
Liviu
>
> --
> 1.9.1
>
>
--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] pci: pci-exynos: fixed the sentence error
2015-03-25 9:44 ` Liviu Dudau
@ 2015-03-25 10:12 ` Jaehoon Chung
0 siblings, 0 replies; 4+ messages in thread
From: Jaehoon Chung @ 2015-03-25 10:12 UTC (permalink / raw)
To: Liviu Dudau
Cc: linux-pci@vger.kernel.org, Jingoo Han, Bjorn Helgaas,
cpgs@samsung.com
Dear, Liviu.
On 03/25/2015 06:44 PM, Liviu Dudau wrote:
> On Wed, Mar 25, 2015 at 05:13:12AM +0000, Jaehoon Chung wrote:
>> There is the sentence error.
>> Changed the semicolon instead of comma.
>>
>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
>> ---
>> drivers/pci/host/pci-exynos.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/pci/host/pci-exynos.c b/drivers/pci/host/pci-exynos.c
>> index d202b37..c139237 100644
>> --- a/drivers/pci/host/pci-exynos.c
>> +++ b/drivers/pci/host/pci-exynos.c
>> @@ -396,7 +396,7 @@ static void exynos_pcie_enable_irq_pulse(struct pcie_port *pp)
>>
>> /* enable INTX interrupt */
>> val = IRQ_INTA_ASSERT | IRQ_INTB_ASSERT |
>> - IRQ_INTC_ASSERT | IRQ_INTD_ASSERT,
>> + IRQ_INTC_ASSERT | IRQ_INTD_ASSERT;
>> exynos_elb_writel(exynos_pcie, val, PCIE_IRQ_EN_PULSE);
>> }
>
> Well spotted. The original change dates from July 2013, I'm guessing no one uses
> PCIe on Exynos?
pci-exynos.c based on Exynos5440. I can't also see whoever use it.
But exynos5433 is used the PCIe.
There is difference between exynos5440 and exynos5433.
(i.e. Register base and offset..)
If exynos5440 is not used, i want to update pci-exynos.c to base on exynos5433.
In future, exynos should be use the PCIe...
ASAP, I will send the patch-set for exynos5433.
Before sending patch-set, just sent the patch for fixing it.
(Also, working on supporting ARM64 at pcie-designware.c)
Best Regards,
Jaehoon Chung
>
> Best regards,
> Liviu
>
>>
>> --
>> 1.9.1
>>
>>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] pci: pci-exynos: fixed the sentence error
2015-03-25 5:13 [PATCH] pci: pci-exynos: fixed the sentence error Jaehoon Chung
2015-03-25 9:44 ` Liviu Dudau
@ 2015-04-08 19:33 ` Bjorn Helgaas
1 sibling, 0 replies; 4+ messages in thread
From: Bjorn Helgaas @ 2015-04-08 19:33 UTC (permalink / raw)
To: Jaehoon Chung; +Cc: linux-pci, Jingoo Han, Liviu.Dudau, cpgs
On Wed, Mar 25, 2015 at 02:13:12PM +0900, Jaehoon Chung wrote:
> There is the sentence error.
> Changed the semicolon instead of comma.
>
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
Applied to pci/host-exynos for v4.1. Jingoo, speak up if you object, but
this looks like a pretty obvious error.
> ---
> drivers/pci/host/pci-exynos.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/host/pci-exynos.c b/drivers/pci/host/pci-exynos.c
> index d202b37..c139237 100644
> --- a/drivers/pci/host/pci-exynos.c
> +++ b/drivers/pci/host/pci-exynos.c
> @@ -396,7 +396,7 @@ static void exynos_pcie_enable_irq_pulse(struct pcie_port *pp)
>
> /* enable INTX interrupt */
> val = IRQ_INTA_ASSERT | IRQ_INTB_ASSERT |
> - IRQ_INTC_ASSERT | IRQ_INTD_ASSERT,
> + IRQ_INTC_ASSERT | IRQ_INTD_ASSERT;
> exynos_elb_writel(exynos_pcie, val, PCIE_IRQ_EN_PULSE);
> }
>
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-04-08 19:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-25 5:13 [PATCH] pci: pci-exynos: fixed the sentence error Jaehoon Chung
2015-03-25 9:44 ` Liviu Dudau
2015-03-25 10:12 ` Jaehoon Chung
2015-04-08 19:33 ` Bjorn Helgaas
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.