From: Alberto Garcia <berto@igalia.com>
To: Eric Blake <eblake@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, Markus Armbruster <armbru@redhat.com>,
qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/3] block: add 'node-name' field to BLOCK_IMAGE_CORRUPTED
Date: Thu, 9 Apr 2015 09:30:06 +0200 [thread overview]
Message-ID: <20150409073006.GA10878@igalia.com> (raw)
In-Reply-To: <5525BA9F.4070406@redhat.com>
On Wed, Apr 08, 2015 at 05:32:47PM -0600, Eric Blake wrote:
> > +- "device": Device name (json-string)
> > +- "node-name": Node name (json-string, optional)
> > +- "msg": Informative message (e.g., reason for the corruption)
> > + (json-string)
> > +- "offset": If the corruption resulted from an image access, this
> > + is the access offset into the image (json-int)
> > +- "size": If the corruption resulted from an image access, this
> > + is the access size (json-int)
>
> Not your fault (so don't worry about fixing it here), but I still
> find this definition of 'offset' confusing - is it the guest's
> offset, or the host's offset?
From the code it looks like it's the host's offset. And now that it
look into it both 'offset' and 'size' should be marked as optional
there (they are in block-core.json). I'll send a separate patch
correcting all those.
Berto
next prev parent reply other threads:[~2015-04-09 7:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-08 9:29 [Qemu-devel] [PATCH v4 0/3] Add bdrv_get_device_or_node_name() Alberto Garcia
2015-04-08 9:29 ` [Qemu-devel] [PATCH 1/3] block: add bdrv_get_device_or_node_name() Alberto Garcia
2015-04-08 16:32 ` Eric Blake
2015-04-08 9:29 ` [Qemu-devel] [PATCH 2/3] block: use bdrv_get_device_or_node_name() in error messages Alberto Garcia
2015-04-08 16:27 ` Eric Blake
2015-04-09 8:25 ` Alberto Garcia
2015-04-08 9:29 ` [Qemu-devel] [PATCH 3/3] block: add 'node-name' field to BLOCK_IMAGE_CORRUPTED Alberto Garcia
2015-04-08 23:32 ` Eric Blake
2015-04-09 7:30 ` Alberto Garcia [this message]
2015-04-15 13:24 ` Max Reitz
2015-04-21 13:47 ` [Qemu-devel] [Qemu-block] [PATCH v4 0/3] Add bdrv_get_device_or_node_name() Stefan Hajnoczi
-- strict thread matches above, loose matches on Subject: below --
2015-03-20 14:33 [Qemu-devel] [PATCH v3 " Alberto Garcia
2015-03-20 14:33 ` [Qemu-devel] [PATCH 3/3] block: add 'node-name' field to BLOCK_IMAGE_CORRUPTED Alberto Garcia
2015-03-20 19:26 ` Max Reitz
2015-03-23 9:20 ` Markus Armbruster
2015-03-23 9:53 ` Alberto Garcia
2015-03-23 11:55 ` Markus Armbruster
2015-03-20 10:19 [Qemu-devel] [PATCH v2 0/3] Add bdrv_get_device_or_node_name() Alberto Garcia
2015-03-20 10:19 ` [Qemu-devel] [PATCH 3/3] block: add 'node-name' field to BLOCK_IMAGE_CORRUPTED Alberto Garcia
2015-03-20 13:24 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150409073006.GA10878@igalia.com \
--to=berto@igalia.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.