Re: [Qemu-devel] [PATCH 3/3] block: add 'node-name' field to BLOCK_IMAGE_CORRUPTED

[Eric Blake <eblake@redhat.com>]

On 04/08/2015 03:29 AM, Alberto Garcia wrote:
> Since this event can occur in nodes that cannot have a device name
> associated, include also a field with the node name.
> 
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> ---
>  block/qcow2.c           |  8 ++++++--
>  docs/qmp/qmp-events.txt | 21 +++++++++++++--------
>  qapi/block-core.json    | 17 +++++++++++------
>  3 files changed, 30 insertions(+), 16 deletions(-)
> 
>  
> -- "device": Device name (json-string)
> -- "msg":    Informative message (e.g., reason for the corruption) (json-string)
> -- "offset": If the corruption resulted from an image access, this is the access
> -            offset into the image (json-int)
> -- "size":   If the corruption resulted from an image access, this is the access
> -            size (json-int)
> +- "device":    Device name (json-string)
> +- "node-name": Node name (json-string, optional)
> +- "msg":       Informative message (e.g., reason for the corruption)
> +               (json-string)
> +- "offset":    If the corruption resulted from an image access, this
> +               is the access offset into the image (json-int)
> +- "size":      If the corruption resulted from an image access, this
> +               is the access size (json-int)

Not your fault (so don't worry about fixing it here), but I still find
this definition of 'offset' confusing - is it the guest's offset, or the
host's offset?  I'm going to assume the host's offset (remember, on
qcow2, the guest offset 0 is never at host offset 0, because that is
reserved for the qcow2 header - but we CAN encounter a read error while
reading the qcow2 header).

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org